From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Vaibhav Gupta <vaibhavgupta40@gmail.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Bjorn Helgaas <bjorn@helgaas.com>,
Vaibhav Gupta <vaibhav.varodek@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] spi: spi-topcliff-pch: drop call to wakeup-disable
Date: Mon, 27 Jul 2020 07:17:10 -0700 [thread overview]
Message-ID: <a594ffa8112a9696260d8a01fa7941b125cf6226.camel@perches.com> (raw)
In-Reply-To: <CAHp75Vfuw1rAYxy41hVKNaqZQg4W-_Y=6St-X0yb5O4zN6qCfw@mail.gmail.com>
On Mon, 2020-07-27 at 17:08 +0300, Andy Shevchenko wrote:
> Joe, can we amend checkpatch to at least shout about simple typos in
> the tag area?
> See below for the context.
>
> On Mon, Jul 27, 2020 at 4:48 PM Vaibhav Gupta <vaibhavgupta40@gmail.com> wrote:
> > On Mon, Jul 27, 2020 at 04:38:40PM +0300, Andy Shevchenko wrote:
> > > On Mon, Jul 27, 2020 at 4:21 PM Vaibhav Gupta <vaibhavgupta40@gmail.com> wrote:
>
> ...
>
> > > > Fix: f185bcc77980("spi: spi-topcliff-pch: use generic power management")
> > >
> > > Fixes: and missed space.
>
> (1)
>
> > > > Reported by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > >
> > > Missed dash.
> > > Does checkpatch complain?
> > No, I got this message:
> > "* .patch has no obvious style problems and is ready for submission"
>
> (2)
Not reasonably so far as I can tell, no.
The test for a signature uses -by:
Fix: starting a line seems a reasonable thing
that someone might want to have in a commit
message.
next prev parent reply other threads:[~2020-07-27 14:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 15:57 [PATCH v1] spi: spi-topcliff-pch: use generic power management Vaibhav Gupta
2020-07-22 13:45 ` Mark Brown
2020-07-22 20:01 ` Vaibhav Gupta
2020-07-24 10:51 ` Andy Shevchenko
2020-07-24 15:16 ` Vaibhav Gupta
2020-07-24 20:16 ` Andy Shevchenko
2020-07-24 22:37 ` Bjorn Helgaas
2020-07-25 10:42 ` Andy Shevchenko
2020-07-25 10:44 ` Andy Shevchenko
2020-07-27 7:06 ` Vaibhav Gupta
2020-07-27 11:12 ` Andy Shevchenko
2020-07-27 13:08 ` Vaibhav Gupta
2020-07-27 13:17 ` [PATCH v2] spi: spi-topcliff-pch: drop call to wakeup-disable Vaibhav Gupta
2020-07-27 13:38 ` Andy Shevchenko
2020-07-27 13:46 ` Vaibhav Gupta
2020-07-27 14:08 ` Andy Shevchenko
2020-07-27 14:17 ` Joe Perches [this message]
2020-07-27 17:29 ` [PATCH v3] " Vaibhav Gupta
2020-07-27 19:21 ` Andy Shevchenko
2020-07-28 16:31 ` Mark Brown
2020-07-28 16:31 ` [PATCH v2] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a594ffa8112a9696260d8a01fa7941b125cf6226.camel@perches.com \
--to=joe@perches.com \
--cc=andy.shevchenko@gmail.com \
--cc=bhelgaas@google.com \
--cc=bjorn@helgaas.com \
--cc=broonie@kernel.org \
--cc=helgaas@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vaibhav.varodek@gmail.com \
--cc=vaibhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).