From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Bjorn Helgaas <bjorn@helgaas.com>,
Vaibhav Gupta <vaibhav.varodek@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] spi: spi-topcliff-pch: drop call to wakeup-disable
Date: Mon, 27 Jul 2020 19:16:46 +0530 [thread overview]
Message-ID: <20200727134646.GA114726@gmail.com> (raw)
In-Reply-To: <CAHp75VfmKvAy6bSk70g3c2qJcUzzo0AUhzxR6dFja+ZppGMLRg@mail.gmail.com>
On Mon, Jul 27, 2020 at 04:38:40PM +0300, Andy Shevchenko wrote:
> On Mon, Jul 27, 2020 at 4:21 PM Vaibhav Gupta <vaibhavgupta40@gmail.com> wrote:
> >
> > Before generic upgrade, both .suspend() and .resume() were invoking
> > pci_enable_wake(pci_dev, PCI_D3hot, 0). Hence, disabling wakeup in both
> > states. (Normal trend is .suspend() enables and .resume() disables the
> > wakeup.)
> >
> > This was ambiguous and may be buggy. Instead of replicating the legacy
> > behavior, drop the wakeup-disable call.
> >
>
> > Fix: f185bcc77980("spi: spi-topcliff-pch: use generic power management")
>
> Fixes: and missed space.
>
> Note:
>
> % grep one ~/.gitconfig
> one = show -s --pretty='format:%h (\"%s\")'
>
> % git one f185bcc77980
> f185bcc77980 ("spi: spi-topcliff-pch: use generic power management")
>
> > Reported by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> Missed dash.
> Does checkpatch complain?
No, I got this message:
"* .patch has no obvious style problems and is ready for submission"
I will fix the commit message.
Thanks!
Vaibhav Gupta
>
> > Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
> > ---
> > drivers/spi/spi-topcliff-pch.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
> > index 281a90f1b5d8..c73a03ddf5f3 100644
> > --- a/drivers/spi/spi-topcliff-pch.c
> > +++ b/drivers/spi/spi-topcliff-pch.c
> > @@ -1648,8 +1648,6 @@ static int __maybe_unused pch_spi_resume(struct device *dev)
> >
> > dev_dbg(dev, "%s ENTRY\n", __func__);
> >
> > - device_wakeup_disable(dev);
> > -
> > /* set suspend status to false */
> > pd_dev_save->board_dat->suspend_sts = false;
> >
> > --
> > 2.27.0
> >
>
>
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2020-07-27 13:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 15:57 [PATCH v1] spi: spi-topcliff-pch: use generic power management Vaibhav Gupta
2020-07-22 13:45 ` Mark Brown
2020-07-22 20:01 ` Vaibhav Gupta
2020-07-24 10:51 ` Andy Shevchenko
2020-07-24 15:16 ` Vaibhav Gupta
2020-07-24 20:16 ` Andy Shevchenko
2020-07-24 22:37 ` Bjorn Helgaas
2020-07-25 10:42 ` Andy Shevchenko
2020-07-25 10:44 ` Andy Shevchenko
2020-07-27 7:06 ` Vaibhav Gupta
2020-07-27 11:12 ` Andy Shevchenko
2020-07-27 13:08 ` Vaibhav Gupta
2020-07-27 13:17 ` [PATCH v2] spi: spi-topcliff-pch: drop call to wakeup-disable Vaibhav Gupta
2020-07-27 13:38 ` Andy Shevchenko
2020-07-27 13:46 ` Vaibhav Gupta [this message]
2020-07-27 14:08 ` Andy Shevchenko
2020-07-27 14:17 ` Joe Perches
2020-07-27 17:29 ` [PATCH v3] " Vaibhav Gupta
2020-07-27 19:21 ` Andy Shevchenko
2020-07-28 16:31 ` Mark Brown
2020-07-28 16:31 ` [PATCH v2] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727134646.GA114726@gmail.com \
--to=vaibhavgupta40@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=bhelgaas@google.com \
--cc=bjorn@helgaas.com \
--cc=broonie@kernel.org \
--cc=helgaas@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vaibhav.varodek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).