* [PATCH 20/38] move spidev_remove to .devexit.text [not found] ` <1259096853-18909-19-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> @ 2009-11-24 21:07 ` Uwe Kleine-König [not found] ` <1259096853-18909-21-git-send-email-u.kleine-koenig@pengutronix.de> 2009-11-24 21:22 ` [PATCH 20/38] move spidev_remove to .devexit.text Mike Frysinger 0 siblings, 2 replies; 4+ messages in thread From: Uwe Kleine-König @ 2009-11-24 21:07 UTC (permalink / raw) To: linux-kernel-u79uwXL29TY76Z2rM5mHXA Cc: David Brownell, Mike Frysinger, Greg Kroah-Hartman, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b, Alexey Dobriyan The function spidev_remove is used only wrapped by __devexit_p so define it using __devexit. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Sam Ravnborg <sam@ravnborg.org> Cc: David Brownell <dbrownell@users.sourceforge.net> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Wolfgang Ocker <weo@reccoware.de> Cc: Greg Kroah-Hartman <gregkh@suse.de> Cc: spi-devel-general@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Cc: Mike Frysinger <vapier@gentoo.org> Cc: Alexey Dobriyan <adobriyan@gmail.com> --- drivers/spi/spidev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index 5d23983..5471bfc 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -610,7 +610,7 @@ static int spidev_probe(struct spi_device *spi) return status; } -static int spidev_remove(struct spi_device *spi) +static int __devexit spidev_remove(struct spi_device *spi) { struct spidev_data *spidev = spi_get_drvdata(spi); -- 1.6.5.2 ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general ^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <1259096853-18909-21-git-send-email-u.kleine-koenig@pengutronix.de>]
[parent not found: <1259096853-18909-22-git-send-email-u.kleine-koenig@pengutronix.de>]
[parent not found: <1259096853-18909-23-git-send-email-u.kleine-koenig@pengutronix.de>]
[parent not found: <1259096853-18909-24-git-send-email-u.kleine-koenig@pengutronix.de>]
[parent not found: <1259096853-18909-25-git-send-email-u.kleine-koenig@pengutronix.de>]
[parent not found: <1259096853-18909-26-git-send-email-u.kleine-koenig@pengutronix.de>]
[parent not found: <1259096853-18909-27-git-send-email-u.kleine-koenig@pengutronix.de>]
[parent not found: <1259096853-18909-28-git-send-email-u.kleine-koenig@pengutronix.de>]
[parent not found: <1259096853-18909-29-git-send-email-u.kleine-koenig@pengutronix.de>]
[parent not found: <1259096853-18909-30-git-send-email-u.kleine-koenig@pengutronix.de>]
[parent not found: <1259096853-18909-31-git-send-email-u.kleine-koenig@pengutronix.de>]
[parent not found: <1259096853-18909-31-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]
* [PATCH 32/38] don't use __exit_p to wrap plat_mpc8xxx_spi_remove [not found] ` <1259096853-18909-31-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> @ 2009-11-24 21:07 ` Uwe Kleine-König [not found] ` <1259096853-18909-32-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Uwe Kleine-König @ 2009-11-24 21:07 UTC (permalink / raw) To: linux-kernel-u79uwXL29TY76Z2rM5mHXA Cc: David Brownell, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b The function plat_mpc8xxx_spi_remove is defined using __devexit, so don't use __exit_p but __devexit_p to wrap it. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Kumar Gala <galak@kernel.crashing.org> Cc: Anton Vorontsov <avorontsov@ru.mvista.com> Cc: Grant Likely <grant.likely@secretlab.ca> Cc: linux-kernel@vger.kernel.org Cc: devicetree-discuss@lists.ozlabs.org Cc: David Brownell <dbrownell@users.sourceforge.net> Cc: spi-devel-general@lists.sourceforge.net --- drivers/spi/spi_mpc8xxx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi_mpc8xxx.c b/drivers/spi/spi_mpc8xxx.c index 0fd0ec4..1d98be9 100644 --- a/drivers/spi/spi_mpc8xxx.c +++ b/drivers/spi/spi_mpc8xxx.c @@ -900,7 +900,7 @@ static int __devexit plat_mpc8xxx_spi_remove(struct platform_device *pdev) MODULE_ALIAS("platform:mpc8xxx_spi"); static struct platform_driver mpc8xxx_spi_driver = { .probe = plat_mpc8xxx_spi_probe, - .remove = __exit_p(plat_mpc8xxx_spi_remove), + .remove = __devexit_p(plat_mpc8xxx_spi_remove), .driver = { .name = "mpc8xxx_spi", .owner = THIS_MODULE, -- 1.6.5.2 ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general ^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <1259096853-18909-32-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]
* Re: [PATCH 32/38] don't use __exit_p to wrap plat_mpc8xxx_spi_remove [not found] ` <1259096853-18909-32-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> @ 2009-11-24 21:42 ` Grant Likely 0 siblings, 0 replies; 4+ messages in thread From: Grant Likely @ 2009-11-24 21:42 UTC (permalink / raw) To: Uwe Kleine-König Cc: David Brownell, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, linux-kernel-u79uwXL29TY76Z2rM5mHXA, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b, Anton Vorontsov 2009/11/24 Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>: > The function plat_mpc8xxx_spi_remove is defined using __devexit, so don't > use __exit_p but __devexit_p to wrap it. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Obviously correct. Acked-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> g. > Cc: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> > Cc: Kumar Gala <galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org> > Cc: Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org> > Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> > Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org > Cc: David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> > Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org > --- > drivers/spi/spi_mpc8xxx.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/spi/spi_mpc8xxx.c b/drivers/spi/spi_mpc8xxx.c > index 0fd0ec4..1d98be9 100644 > --- a/drivers/spi/spi_mpc8xxx.c > +++ b/drivers/spi/spi_mpc8xxx.c > @@ -900,7 +900,7 @@ static int __devexit plat_mpc8xxx_spi_remove(struct platform_device *pdev) > MODULE_ALIAS("platform:mpc8xxx_spi"); > static struct platform_driver mpc8xxx_spi_driver = { > .probe = plat_mpc8xxx_spi_probe, > - .remove = __exit_p(plat_mpc8xxx_spi_remove), > + .remove = __devexit_p(plat_mpc8xxx_spi_remove), > .driver = { > .name = "mpc8xxx_spi", > .owner = THIS_MODULE, > -- > 1.6.5.2 > > -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 20/38] move spidev_remove to .devexit.text 2009-11-24 21:07 ` [PATCH 20/38] move spidev_remove to .devexit.text Uwe Kleine-König [not found] ` <1259096853-18909-21-git-send-email-u.kleine-koenig@pengutronix.de> @ 2009-11-24 21:22 ` Mike Frysinger 1 sibling, 0 replies; 4+ messages in thread From: Mike Frysinger @ 2009-11-24 21:22 UTC (permalink / raw) To: Uwe Kleine-König Cc: linux-kernel, akpm, David Brownell, Wolfgang Ocker, Greg Kroah-Hartman, spi-devel-general, Alexey Dobriyan 2009/11/24 Uwe Kleine-König > The function spidev_remove is used only wrapped by __devexit_p so define > it using __devexit. this doesnt go far enough to address actual section mismatch issues in the driver. i posted a more complete one here: http://lkml.org/lkml/2009/10/13/76 and akpm has picked that up -mike ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-11-24 21:42 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <1259096853-18909-1-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-2-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-3-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-4-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-5-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-6-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-7-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-8-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-9-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-10-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-11-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-12-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-13-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-14-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-15-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-16-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-17-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-18-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-19-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-19-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2009-11-24 21:07 ` [PATCH 20/38] move spidev_remove to .devexit.text Uwe Kleine-König [not found] ` <1259096853-18909-21-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-22-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-23-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-24-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-25-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-26-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-27-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-28-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-29-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-30-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-31-git-send-email-u.kleine-koenig@pengutronix.de> [not found] ` <1259096853-18909-31-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2009-11-24 21:07 ` [PATCH 32/38] don't use __exit_p to wrap plat_mpc8xxx_spi_remove Uwe Kleine-König [not found] ` <1259096853-18909-32-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2009-11-24 21:42 ` Grant Likely 2009-11-24 21:22 ` [PATCH 20/38] move spidev_remove to .devexit.text Mike Frysinger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).