linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Fabio Aiuto <fabioaiuto83@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 18/19] staging: rtl8723bs: split long lines
Date: Tue, 13 Apr 2021 17:57:12 +0300	[thread overview]
Message-ID: <20210413145712.GH6021@kadam> (raw)
In-Reply-To: <814139162ef516bb07bb50876578b032573271ac.1617802415.git.fabioaiuto83@gmail.com>

On Wed, Apr 07, 2021 at 03:49:42PM +0200, Fabio Aiuto wrote:
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index 7f998a2f8001..a1e27ba4707e 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -619,8 +619,9 @@ unsigned int OnProbeReq(struct adapter *padapter, union recv_frame *precv_frame)
>  			return _SUCCESS;
>  
>  _issue_probersp:
> -		if ((check_fwstate(pmlmepriv, _FW_LINKED)  &&
> -			pmlmepriv->cur_network.join_res) || check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))
> +		if ((check_fwstate(pmlmepriv, _FW_LINKED) &&
> +		     pmlmepriv->cur_network.join_res) ||
> +		     check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))

The last line is indented one space character too much.  It should be:

		if ((check_fwstate(pmlmepriv, _FW_LINKED) &&
		     pmlmepriv->cur_network.join_res) ||
		    check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))

regards,
dan carpenter


  reply	other threads:[~2021-04-13 15:51 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07 13:49 [PATCH 00/19] staging: rtl8723bs: remove DBG_871X trace macro Fabio Aiuto
2021-04-07 13:49 ` [PATCH 01/19] staging: rtl8723bs: remove DBG_871X log argument Fabio Aiuto
2021-04-07 13:49 ` [PATCH 02/19] staging: rtl8723bs: remove all DBG_871X logs Fabio Aiuto
2021-04-07 13:49 ` [PATCH 03/19] staging: rtl8723bs: remove DBG_871CX log unmatched by cocci Fabio Aiuto
2021-04-07 13:49 ` [PATCH 04/19] staging: rtl8723bs: remove commented out DBG_871X logs Fabio Aiuto
2021-04-07 13:49 ` [PATCH 05/19] staging: rtl8723bs: remove DBG_871X macro definitions Fabio Aiuto
2021-04-07 13:49 ` [PATCH 06/19] staging: rtl8723bs: remove all if-else empty blocks left by DBG_871X removal Fabio Aiuto
2021-04-07 13:49 ` [PATCH 07/19] drivers: rtl8723bs: rewrite comparison to null Fabio Aiuto
2021-04-07 15:14   ` Greg KH
2021-04-07 15:25     ` Fabio Aiuto
2021-04-07 15:30       ` Greg KH
2021-04-07 15:38         ` Fabio Aiuto
2021-04-07 13:49 ` [PATCH 08/19] staging: rtl8723bs: put constant on the right side in if condition Fabio Aiuto
2021-04-07 13:49 ` [PATCH 09/19] staging: rtl8723bs: remove empty for cycles left by DBG_871X removal Fabio Aiuto
2021-04-07 13:49 ` [PATCH 10/19] staging: rtl8723bs: remove empty tracing function dump_rx_packet Fabio Aiuto
2021-04-07 13:49 ` [PATCH 11/19] staging: rtl8723bs: remove empty #ifdef blocks after DBG_871X removal Fabio Aiuto
2021-04-07 13:49 ` [PATCH 12/19] staging: rtl8723bs: remove unnecessary bracks on DBG_871X removal sites Fabio Aiuto
2021-04-13 14:52   ` Dan Carpenter
2021-04-14  8:32     ` Joe Perches
2021-04-07 13:49 ` [PATCH 13/19] staging: rtl8723bs: remove unnecessary parentheses in if condition Fabio Aiuto
2021-04-07 13:49 ` [PATCH 14/19] staging: rtl8723bs: add spaces around operators Fabio Aiuto
2021-04-07 13:49 ` [PATCH 15/19] staging: rtl8723bs: rewrite comparison to null Fabio Aiuto
2021-04-07 13:49 ` [PATCH 16/19] staging: rtl8723bs: remove unnecessary parentheses Fabio Aiuto
2021-04-07 13:49 ` [PATCH 17/19] staging: rtl8723bs: fix comparison in if condition Fabio Aiuto
2021-04-07 13:49 ` [PATCH 18/19] staging: rtl8723bs: split long lines Fabio Aiuto
2021-04-13 14:57   ` Dan Carpenter [this message]
2021-04-14  8:17     ` [PATCH] staging: rtl8723bs: fix indentation issue introduced by long line split Fabio Aiuto
2021-04-07 13:49 ` [PATCH 19/19] staging: rtl8723bs: remove unnecessary parentheses Fabio Aiuto
2021-04-07 15:14 ` [PATCH 00/19] staging: rtl8723bs: remove DBG_871X trace macro Greg KH
2021-04-07 16:49   ` Fabio Aiuto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210413145712.GH6021@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=fabioaiuto83@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).