linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Fabio Aiuto <fabioaiuto83@gmail.com>
Subject: [PATCH 01/19] staging: rtl8723bs: remove DBG_871X log argument
Date: Wed,  7 Apr 2021 15:49:25 +0200	[thread overview]
Message-ID: <3473925ae9ee5a3bcd0ab86613dbce80b6d3f33f.1617802415.git.fabioaiuto83@gmail.com> (raw)
In-Reply-To: <cover.1617802415.git.fabioaiuto83@gmail.com>

This patch prepares the application of the semantic
patch aimed to remove all DBG_871X logs.

One occurrence of the DBG_871X macro has one
repeated argument, that's not even comma separated
value with the previous one nor a format string
parameter associated.

In normal conditions this worked, for the macro
is usually not expanded (the do nothing behaviour),
but if I try to apply the sempantic patch to remove
all macro occurrences, all macros call after that
abnormal declaration are left untouched (not removed).

Remove all of the DBG_871X logs as they currently
do nothing as they require the code to be modified by
hand in order to be turned on. This obviously has not happened
since the code was merged, so just remove them as they are unused.

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index eac663119290..f18a7afcc0d3 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -823,7 +823,7 @@ static signed int ap2sta_data_frame(struct adapter *adapter, union recv_frame *p
 			#ifdef DBG_RX_DROP_FRAME
 			DBG_871X("DBG_RX_DROP_FRAME %s BSSID =%pM, mybssid =%pM\n",
 				__func__, MAC_ARG(pattrib->bssid), MAC_ARG(mybssid));
-			DBG_871X("this adapter = %d, buddy adapter = %d\n", adapter->adapter_type, adapter->pbuddystruct adapter->adapter_type);
+			DBG_871X("this adapter = %d, buddy adapter = %d\n", adapter->adapter_type, adapter->pbuddystruct);
 			#endif
 
 			if (!bmcast) {
-- 
2.20.1


  reply	other threads:[~2021-04-07 13:49 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07 13:49 [PATCH 00/19] staging: rtl8723bs: remove DBG_871X trace macro Fabio Aiuto
2021-04-07 13:49 ` Fabio Aiuto [this message]
2021-04-07 13:49 ` [PATCH 02/19] staging: rtl8723bs: remove all DBG_871X logs Fabio Aiuto
2021-04-07 13:49 ` [PATCH 03/19] staging: rtl8723bs: remove DBG_871CX log unmatched by cocci Fabio Aiuto
2021-04-07 13:49 ` [PATCH 04/19] staging: rtl8723bs: remove commented out DBG_871X logs Fabio Aiuto
2021-04-07 13:49 ` [PATCH 05/19] staging: rtl8723bs: remove DBG_871X macro definitions Fabio Aiuto
2021-04-07 13:49 ` [PATCH 06/19] staging: rtl8723bs: remove all if-else empty blocks left by DBG_871X removal Fabio Aiuto
2021-04-07 13:49 ` [PATCH 07/19] drivers: rtl8723bs: rewrite comparison to null Fabio Aiuto
2021-04-07 15:14   ` Greg KH
2021-04-07 15:25     ` Fabio Aiuto
2021-04-07 15:30       ` Greg KH
2021-04-07 15:38         ` Fabio Aiuto
2021-04-07 13:49 ` [PATCH 08/19] staging: rtl8723bs: put constant on the right side in if condition Fabio Aiuto
2021-04-07 13:49 ` [PATCH 09/19] staging: rtl8723bs: remove empty for cycles left by DBG_871X removal Fabio Aiuto
2021-04-07 13:49 ` [PATCH 10/19] staging: rtl8723bs: remove empty tracing function dump_rx_packet Fabio Aiuto
2021-04-07 13:49 ` [PATCH 11/19] staging: rtl8723bs: remove empty #ifdef blocks after DBG_871X removal Fabio Aiuto
2021-04-07 13:49 ` [PATCH 12/19] staging: rtl8723bs: remove unnecessary bracks on DBG_871X removal sites Fabio Aiuto
2021-04-13 14:52   ` Dan Carpenter
2021-04-14  8:32     ` Joe Perches
2021-04-07 13:49 ` [PATCH 13/19] staging: rtl8723bs: remove unnecessary parentheses in if condition Fabio Aiuto
2021-04-07 13:49 ` [PATCH 14/19] staging: rtl8723bs: add spaces around operators Fabio Aiuto
2021-04-07 13:49 ` [PATCH 15/19] staging: rtl8723bs: rewrite comparison to null Fabio Aiuto
2021-04-07 13:49 ` [PATCH 16/19] staging: rtl8723bs: remove unnecessary parentheses Fabio Aiuto
2021-04-07 13:49 ` [PATCH 17/19] staging: rtl8723bs: fix comparison in if condition Fabio Aiuto
2021-04-07 13:49 ` [PATCH 18/19] staging: rtl8723bs: split long lines Fabio Aiuto
2021-04-13 14:57   ` Dan Carpenter
2021-04-14  8:17     ` [PATCH] staging: rtl8723bs: fix indentation issue introduced by long line split Fabio Aiuto
2021-04-07 13:49 ` [PATCH 19/19] staging: rtl8723bs: remove unnecessary parentheses Fabio Aiuto
2021-04-07 15:14 ` [PATCH 00/19] staging: rtl8723bs: remove DBG_871X trace macro Greg KH
2021-04-07 16:49   ` Fabio Aiuto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3473925ae9ee5a3bcd0ab86613dbce80b6d3f33f.1617802415.git.fabioaiuto83@gmail.com \
    --to=fabioaiuto83@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).