From: Dan Carpenter <dan.carpenter@oracle.com>
To: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v2] staging: media: atomisp: pci: Format comments according to coding-style in file atomisp_cmd.c
Date: Thu, 15 Apr 2021 08:48:51 +0300 [thread overview]
Message-ID: <20210415054851.GA6021@kadam> (raw)
In-Reply-To: <20210414204244.GA8287@focaruja>
On Wed, Apr 14, 2021 at 05:42:44PM -0300, Aline Santana Cordeiro wrote:
> @@ -90,18 +92,14 @@ struct camera_mipi_info *atomisp_to_sensor_mipi_info(struct v4l2_subdev *sd)
> return (struct camera_mipi_info *)v4l2_get_subdev_hostdata(sd);
> }
>
> -/*
> - * get struct atomisp_video_pipe from v4l2 video_device
> - */
> +/* get struct atomisp_video_pipe from v4l2 video_device */
This code is obvious and the comment doesn't add anything except noise.
Just delete it. Same for a lot of the other one line comments
describing functions in this patch.
> struct atomisp_video_pipe *atomisp_to_video_pipe(struct video_device *dev)
> {
> return (struct atomisp_video_pipe *)
> container_of(dev, struct atomisp_video_pipe, vdev);
> }
>
> -/*
> - * get struct atomisp_acc_pipe from v4l2 video_device
> - */
> +/* get struct atomisp_acc_pipe from v4l2 video_device */
> struct atomisp_acc_pipe *atomisp_to_acc_pipe(struct video_device *dev)
> {
> return (struct atomisp_acc_pipe *)
> @@ -269,7 +267,7 @@ int atomisp_freq_scaling(struct atomisp_device *isp,
> ATOMISP_RUN_MODE_CONTINUOUS_CAPTURE;
> }
>
> - /* search for the target frequency by looping freq rules*/
> + /* search for the target frequency by looping freq rules */
> for (i = 0; i < dfs->dfs_table_size; i++) {
> if (curr_rules.width != dfs->dfs_table[i].width &&
> dfs->dfs_table[i].width != ISP_FREQ_RULE_ANY)
> @@ -307,9 +305,7 @@ int atomisp_freq_scaling(struct atomisp_device *isp,
> return ret;
> }
>
> -/*
> - * reset and restore ISP
> - */
> +/* reset and restore ISP */
Obvious
> int atomisp_reset(struct atomisp_device *isp)
> {
> /* Reset ISP by power-cycling it */
> @@ -338,9 +334,7 @@ int atomisp_reset(struct atomisp_device *isp)
> return ret;
> }
>
> -/*
> - * interrupt disable functions
> - */
> +/* interrupt disable functions */
Obvious
> static void disable_isp_irq(enum hrt_isp_css_irq irq)
> {
> irq_disable_channel(IRQ0_ID, irq);
> @@ -351,9 +345,7 @@ static void disable_isp_irq(enum hrt_isp_css_irq irq)
> cnd_sp_irq_enable(SP0_ID, false);
> }
>
> -/*
> - * interrupt clean function
> - */
> +/* interrupt clean function */
Obvious
> static void clear_isp_irq(enum hrt_isp_css_irq irq)
> {
> irq_clear_all(IRQ0_ID);
[ snip ]
> @@ -1918,10 +1914,7 @@ irqreturn_t atomisp_isr_thread(int irq, void *isp_ptr)
> return IRQ_HANDLED;
> }
>
> -/*
> - * utils for buffer allocation/free
> - */
> -
> +/* utils for buffer allocation/free */
What? This one seems actively wrong.
> int atomisp_get_frame_pgnr(struct atomisp_device *isp,
> const struct ia_css_frame *frame, u32 *p_pgnr)
> {
etc.
regards,
dan carpenter
next prev parent reply other threads:[~2021-04-15 5:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 20:42 [PATCH v2] staging: media: atomisp: pci: Format comments according to coding-style in file atomisp_cmd.c Aline Santana Cordeiro
2021-04-14 20:55 ` Sakari Ailus
2021-04-15 5:48 ` Dan Carpenter [this message]
2021-04-15 12:27 ` ascordeiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210415054851.GA6021@kadam \
--to=dan.carpenter@oracle.com \
--cc=alinesantanacordeiro@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).