From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Sven Van Asbroeck <TheSven73@gmail.com>,
linux-staging@lists.linux.dev, kernel@pengutronix.de,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/2] staging: fieldbus: anybus: Make remove callback return void
Date: Thu, 6 May 2021 10:40:18 +0200 [thread overview]
Message-ID: <20210506084017.GB1432@agape.jhs> (raw)
In-Reply-To: <20210506075213.uytlw6txmgstapam@pengutronix.de>
On Thu, May 06, 2021 at 09:52:13AM +0200, Uwe Kleine-König wrote:
> On Thu, May 06, 2021 at 08:48:44AM +0200, Fabio Aiuto wrote:
> > Hello Uwe,
> >
> > On Wed, May 05, 2021 at 10:29:22PM +0200, Uwe Kleine-König wrote:
> > > The driver core ignores the return value of struct bus_type::remove()
> > > because there is only little that can be done. To simplify the quest to
> > > make this function return void, let struct vio_driver::remove() return
> > > void, too. All users already unconditionally return 0, this commit makes
> > > it obvious that returning an error code is a bad idea.
> >
> > looks like that the commit description hardly matches what you changed
> > here. You changed the return type of handler remove() of struct
> > anybuss_client_driver. Are the latter and bus_type tied in some
> > fashion?
>
> Oh, vio_driver leaked from my copy-and-paste template.
>
> > Why using :: notation?
>
> If you have a better suggestion I'm all ears.
maybe a simple dot? '::' reminds c++ or rust, this patch fixes c code.
But I don't think it is a real issue, I was just wondering why you choose
'::'
>
> Will resend with Sven's Reviewed-by and
> s/vio_driver/anybuss_client_driver/
>
> Thanks
> Uwe
>
> --
> Pengutronix e.K. | Uwe Kleine-König |
> Industrial Linux Solutions | https://www.pengutronix.de/ |
thank you,
fabio
next prev parent reply other threads:[~2021-05-06 8:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 20:29 [PATCH 1/2] staging: fieldbus: anybus: Make remove callback return void Uwe Kleine-König
2021-05-05 20:29 ` [PATCH 2/2] staging: fieldbus: anybus: Refuse registering drivers without .probe() Uwe Kleine-König
2021-05-05 21:04 ` Sven Van Asbroeck
2021-05-06 6:17 ` Uwe Kleine-König
2021-05-06 13:38 ` Sven Van Asbroeck
2021-05-06 8:49 ` Fabio Aiuto
2021-05-06 13:54 ` Sven Van Asbroeck
2021-05-06 17:14 ` Fabio Aiuto
2021-05-06 6:48 ` [PATCH 1/2] staging: fieldbus: anybus: Make remove callback return void Fabio Aiuto
2021-05-06 7:52 ` Uwe Kleine-König
2021-05-06 8:40 ` Fabio Aiuto [this message]
2021-05-06 9:44 ` Dan Carpenter
2021-05-06 13:23 ` Sven Van Asbroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506084017.GB1432@agape.jhs \
--to=fabioaiuto83@gmail.com \
--cc=TheSven73@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-staging@lists.linux.dev \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).