From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: Sven Van Asbroeck <thesven73@gmail.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev,
"Sascha Hauer" <kernel@pengutronix.de>
Subject: Re: [PATCH 2/2] staging: fieldbus: anybus: Refuse registering drivers without .probe()
Date: Thu, 6 May 2021 10:49:56 +0200 [thread overview]
Message-ID: <20210506084955.GC1432@agape.jhs> (raw)
In-Reply-To: <CAGngYiViy_o2Wzdn0axWeR1FSijH+5d7yLDTkAL+mQnEMkuJBQ@mail.gmail.com>
On Wed, May 05, 2021 at 05:04:55PM -0400, Sven Van Asbroeck wrote:
> On Wed, May 5, 2021 at 4:29 PM Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> >
> > A driver without .probe() callback could never bind to a device because
> > anybus_bus_probe() returned an error for such a driver. So refuse to
> > register such a useless driver.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Looks good to me. For the series:
> Reviewed-by: Sven Van Asbroeck <TheSven73@gmail.com>
>
> Uwe, I'm glad you're submitting patches for fieldbus. Hope you find it
> useful. This code is in staging mainly because only a single
> company/developer is using it. So if you are actively using this, or
> planning to use it, we can work towards taking this out of staging, if
> you like.
>
> Sven
>
Hi Sven,
I'm trying to make my way in linux kernel device driver development and
hopefully find a job soon. If the task 'moving fieldbus out of staging' will
give me opportunity to play with real hardware, and so gain more experience,
we can talk about it.
thank you,
fabio
next prev parent reply other threads:[~2021-05-06 8:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 20:29 [PATCH 1/2] staging: fieldbus: anybus: Make remove callback return void Uwe Kleine-König
2021-05-05 20:29 ` [PATCH 2/2] staging: fieldbus: anybus: Refuse registering drivers without .probe() Uwe Kleine-König
2021-05-05 21:04 ` Sven Van Asbroeck
2021-05-06 6:17 ` Uwe Kleine-König
2021-05-06 13:38 ` Sven Van Asbroeck
2021-05-06 8:49 ` Fabio Aiuto [this message]
2021-05-06 13:54 ` Sven Van Asbroeck
2021-05-06 17:14 ` Fabio Aiuto
2021-05-06 6:48 ` [PATCH 1/2] staging: fieldbus: anybus: Make remove callback return void Fabio Aiuto
2021-05-06 7:52 ` Uwe Kleine-König
2021-05-06 8:40 ` Fabio Aiuto
2021-05-06 9:44 ` Dan Carpenter
2021-05-06 13:23 ` Sven Van Asbroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506084955.GC1432@agape.jhs \
--to=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-staging@lists.linux.dev \
--cc=thesven73@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).