From: Martin Kaiser <martin@kaiser.cx>
To: Michael Straube <straube.linux@gmail.com>
Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
phil@philpotter.co.uk, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: remove useless comment
Date: Sun, 20 Jun 2021 15:31:57 +0200 [thread overview]
Message-ID: <20210620133157.myatkutw2ts26cvj@viti.kaiser.cx> (raw)
In-Reply-To: <20210619175055.5122-1-straube.linux@gmail.com>
Thus wrote Michael Straube (straube.linux@gmail.com):
> Remove block comment about function HwSuspendModeEnable92Cu.
> The comment contains no useful information and there is even
> no HwSuspendModeEnable92Cu function in the driver code.
> 'git grep -n HwSuspendModeEnable92Cu drivers/staging/rtl8188eu'
> returns nothing.
> Signed-off-by: Michael Straube <straube.linux@gmail.com>
> ---
> drivers/staging/rtl8188eu/hal/usb_halinit.c | 16 ----------------
> 1 file changed, 16 deletions(-)
> diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> index dcdf868b394d..6c88675ae251 100644
> --- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> @@ -601,22 +601,6 @@ static void _InitAntenna_Selection(struct adapter *Adapter)
> haldata->CurAntenna = Antenna_B;
> }
> -/*-----------------------------------------------------------------------------
> - * Function: HwSuspendModeEnable92Cu()
> - *
> - * Overview: HW suspend mode switch.
> - *
> - * Input: NONE
> - *
> - * Output: NONE
> - *
> - * Return: NONE
> - *
> - * Revised History:
> - * When Who Remark
> - * 08/23/2010 MHC HW suspend mode switch test..
> - *---------------------------------------------------------------------------
> - */
> enum rt_rf_power_state RfOnOffDetect(struct adapter *adapt)
> {
> u8 val8;
> --
> 2.32.0
You're right. The function for this comment is already gone.
Reviewed-by: Martin Kaiser <martin@kaiser.cx>
prev parent reply other threads:[~2021-06-20 13:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-19 17:50 [PATCH] staging: rtl8188eu: remove useless comment Michael Straube
2021-06-20 13:31 ` Martin Kaiser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210620133157.myatkutw2ts26cvj@viti.kaiser.cx \
--to=martin@kaiser.cx \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).