* [PATCHv2 1/1] media: imx: Round line size to 4 bytes
@ 2022-09-14 15:32 Dorota Czaplejewicz
2022-09-14 15:45 ` Dan Carpenter
2022-09-14 16:11 ` [PATCHv3 " Dorota Czaplejewicz
0 siblings, 2 replies; 4+ messages in thread
From: Dorota Czaplejewicz @ 2022-09-14 15:32 UTC (permalink / raw)
To: Laurent Pinchart, Steve Longerbeam, Philipp Zabel,
Mauro Carvalho Chehab, Greg Kroah-Hartman, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-media, linux-staging, linux-arm-kernel,
linux-kernel, kernel, phone-devel
[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]
Section 13.7.6.13 "CSI Image Parameter Register" of the
i.MX 8M Quad Applications Processors Reference Manual
states that the line size should be divisible by 8 bytes.
However, the hardware also accepts sizes divisible by 4 bytes,
which are needed to fully utilize the S5K3L6XX sensors.
This patch accepts line sizes divisible 4-bytes in non-planar mode.
---
Hello,
the Librem 5 is using an out-of-tree driver for s5k3l6xx, and rounding to 4 is optimal to operate it.
Please ignore my previous series, I sent it by mistake.
Cheers,
Dorota Czaplejewicz
drivers/staging/media/imx/imx7-media-csi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c
index a0553c24cce4..af821b410c3f 100644
--- a/drivers/staging/media/imx/imx7-media-csi.c
+++ b/drivers/staging/media/imx/imx7-media-csi.c
@@ -999,10 +999,10 @@ static int imx7_csi_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix,
}
/* Round up width for minimum burst size */
- width = round_up(mbus->width, 8);
+ width = round_up(mbus->width, 4);
/* Round up stride for IDMAC line start address alignment */
- stride = round_up((width * cc->bpp) >> 3, 8);
+ stride = round_up((width * cc->bpp) >> 3, 4);
pix->width = width;
pix->height = mbus->height;
--
2.37.3
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCHv2 1/1] media: imx: Round line size to 4 bytes
2022-09-14 15:32 [PATCHv2 1/1] media: imx: Round line size to 4 bytes Dorota Czaplejewicz
@ 2022-09-14 15:45 ` Dan Carpenter
2022-09-14 16:09 ` Dorota Czaplejewicz
2022-09-14 16:11 ` [PATCHv3 " Dorota Czaplejewicz
1 sibling, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2022-09-14 15:45 UTC (permalink / raw)
To: Dorota Czaplejewicz
Cc: Laurent Pinchart, Steve Longerbeam, Philipp Zabel,
Mauro Carvalho Chehab, Greg Kroah-Hartman, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-media, linux-staging, linux-arm-kernel,
linux-kernel, kernel, phone-devel
On Wed, Sep 14, 2022 at 05:32:36PM +0200, Dorota Czaplejewicz wrote:
> Section 13.7.6.13 "CSI Image Parameter Register" of the
> i.MX 8M Quad Applications Processors Reference Manual
> states that the line size should be divisible by 8 bytes.
> However, the hardware also accepts sizes divisible by 4 bytes,
> which are needed to fully utilize the S5K3L6XX sensors.
>
> This patch accepts line sizes divisible 4-bytes in non-planar mode.
>
> ---
So do we need a Fixes tag? Was this ever working in kernel?
Definitely need a Signed-off-by line, though. ;)
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHv2 1/1] media: imx: Round line size to 4 bytes
2022-09-14 15:45 ` Dan Carpenter
@ 2022-09-14 16:09 ` Dorota Czaplejewicz
0 siblings, 0 replies; 4+ messages in thread
From: Dorota Czaplejewicz @ 2022-09-14 16:09 UTC (permalink / raw)
To: Dan Carpenter
Cc: Laurent Pinchart, Steve Longerbeam, Philipp Zabel,
Mauro Carvalho Chehab, Greg Kroah-Hartman, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-media, linux-staging, linux-arm-kernel,
linux-kernel, kernel, phone-devel
[-- Attachment #1: Type: text/plain, Size: 864 bytes --]
On Wed, 14 Sep 2022 18:45:05 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Wed, Sep 14, 2022 at 05:32:36PM +0200, Dorota Czaplejewicz wrote:
> > Section 13.7.6.13 "CSI Image Parameter Register" of the
> > i.MX 8M Quad Applications Processors Reference Manual
> > states that the line size should be divisible by 8 bytes.
> > However, the hardware also accepts sizes divisible by 4 bytes,
> > which are needed to fully utilize the S5K3L6XX sensors.
> >
> > This patch accepts line sizes divisible 4-bytes in non-planar mode.
> >
> > ---
>
> So do we need a Fixes tag? Was this ever working in kernel?
>
No, it wasn't actually ever working upstream, just in a patched up branch I mixed up with the real thing.
> Definitely need a Signed-off-by line, though. ;)
Thanks again!
--Dorota
>
> regards,
> dan carpenter
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCHv3 1/1] media: imx: Round line size to 4 bytes
2022-09-14 15:32 [PATCHv2 1/1] media: imx: Round line size to 4 bytes Dorota Czaplejewicz
2022-09-14 15:45 ` Dan Carpenter
@ 2022-09-14 16:11 ` Dorota Czaplejewicz
1 sibling, 0 replies; 4+ messages in thread
From: Dorota Czaplejewicz @ 2022-09-14 16:11 UTC (permalink / raw)
To: Laurent Pinchart, Steve Longerbeam, Philipp Zabel,
Mauro Carvalho Chehab, Greg Kroah-Hartman, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-media, linux-staging, linux-arm-kernel,
linux-kernel, kernel, phone-devel
[-- Attachment #1: Type: text/plain, Size: 1420 bytes --]
Section 13.7.6.13 "CSI Image Parameter Register" of the
i.MX 8M Quad Applications Processors Reference Manual
states that the line size should be divisible by 8 bytes.
However, the hardware also accepts sizes divisible by 4 bytes,
which are needed to fully utilize the S5K3L6XX sensors.
This patch accepts line sizes divisible by 4 bytes.
Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
---
Hello,
the Librem 5 is using an out-of-tree driver for s5k3l6xx, and rounding to 4 is optimal to operate it.
This revision improves the commit message.
Cheers,
Dorota Czaplejewicz
drivers/staging/media/imx/imx7-media-csi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c
index a0553c24cce4..af821b410c3f 100644
--- a/drivers/staging/media/imx/imx7-media-csi.c
+++ b/drivers/staging/media/imx/imx7-media-csi.c
@@ -999,10 +999,10 @@ static int imx7_csi_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix,
}
/* Round up width for minimum burst size */
- width = round_up(mbus->width, 8);
+ width = round_up(mbus->width, 4);
/* Round up stride for IDMAC line start address alignment */
- stride = round_up((width * cc->bpp) >> 3, 8);
+ stride = round_up((width * cc->bpp) >> 3, 4);
pix->width = width;
pix->height = mbus->height;
--
2.37.3
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-14 16:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-14 15:32 [PATCHv2 1/1] media: imx: Round line size to 4 bytes Dorota Czaplejewicz
2022-09-14 15:45 ` Dan Carpenter
2022-09-14 16:09 ` Dorota Czaplejewicz
2022-09-14 16:11 ` [PATCHv3 " Dorota Czaplejewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).