From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Saurav Girepunje <saurav.girepunje@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
saurav.girepunje@hotmail.com, Larry.Finger@lwfinger.net,
phil@philpotter.co.uk, straube.linux@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: core: remove the function power_saving_wk_hdl
Date: Mon, 20 Sep 2021 14:31:28 +0200 [thread overview]
Message-ID: <2311011.CixZWWR6MO@localhost.localdomain> (raw)
In-Reply-To: <20210920113221.GP2088@kadam>
On Monday, September 20, 2021 1:32:21 PM CEST Dan Carpenter wrote:
> On Mon, Sep 20, 2021 at 01:13:54PM +0200, Fabio M. De Francesco wrote:
> > On Monday, September 20, 2021 12:36:06 PM CEST Greg KH wrote:
> > > On Sat, Sep 18, 2021 at 10:52:50PM +0530, Saurav Girepunje wrote:
> > > >
> > > >
> > > > On 13/09/21 9:48 pm, Greg KH wrote:
> > > > > On Fri, Sep 10, 2021 at 11:24:39PM +0530, Saurav Girepunje wrote:
> > > > > > Remove the function power_saving_wk_hdl() as it just calling
> > > > > > the rtw_ps_processor().Instead of power_saving_wk_hdl() call
directly
> > > > > > rtw_ps_processor().
> > > > > >
> > > > > > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> > > > >
> > > > > []
> > > > >
> > > > > Also does not apply to my tree. Please rebase against my staging-
next
> > > > > branch and resend.
> > > > >
> > > > > thanks,
> > > > >
> > > > > greg k-h
> > > > >
> > > >
> > > > Hi Greg,
> > > >
> > > > I always do rebase against your staging-testing branch. Can you help
me
> > to
> > > > understand.When we need to rebase on staging-next. Do we always need
to
> > > > rebase against staging-next..!
> > >
> > > Yes, you should. When you are working on code that lots of other
people
> > > are working on, there will be conflicts like this, and you just need to
> > > stay on top of it.
> > >
> > > thanks,
> > >
> > > greg k-h
> > >
> >
> > Sorry, Greg. I'm confused... :(
> >
> > As far as I know, everyone here make patches for staging-testing.
>
> Nope. It's only you.
And Saurav (at least) :)
I've been misled and in turn I misled Pavel. This is due to a guide in
kernelnewbies.org that explicitly says to use staging-testing:
https://kernelnewbies.org/OutreachyfirstpatchSetup
In that page the is a section ("Set up your Linux kernel code repository")
which says: "[] Then use the revision control system called git to clone Greg
Kroah-Hartman's staging tree repository: git clone -b staging-testing git://
git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git".
I assumed that those instructions must be followed also by developers that
are not (anymore) in the Outreachy program.
Obviously, I was wrong in assuming the above.
Thanks for your reply, Dan.
Regards,
Fabio
>
> The staging-testing branch can be rebased so maybe you will write a
> patch against something that never makes it to staging-next and everyone
> will be puzzled.
>
> That's unlikely to happen and we won't be puzzled for long because we
> try not to invest too much time wondering why patches don't apply.
>
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2021-09-20 12:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 17:54 [PATCH] staging: r8188eu: core: remove the function power_saving_wk_hdl Saurav Girepunje
2021-09-13 16:18 ` Greg KH
2021-09-18 17:22 ` Saurav Girepunje
2021-09-20 10:36 ` Greg KH
2021-09-20 11:13 ` Fabio M. De Francesco
2021-09-20 11:32 ` Dan Carpenter
2021-09-20 12:31 ` Fabio M. De Francesco [this message]
2021-09-20 12:39 ` Dan Carpenter
2021-09-20 13:54 ` Fabio M. De Francesco
2021-09-25 6:14 ` Saurav Girepunje
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2311011.CixZWWR6MO@localhost.localdomain \
--to=fmdefrancesco@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).