From: Saurav Girepunje <saurav.girepunje@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: saurav.girepunje@hotmail.com, Larry.Finger@lwfinger.net,
phil@philpotter.co.uk, straube.linux@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: core: remove the function power_saving_wk_hdl
Date: Sat, 18 Sep 2021 22:52:50 +0530 [thread overview]
Message-ID: <45c4de06-f618-4352-91ea-885edecdf8bb@gmail.com> (raw)
In-Reply-To: <YT951VyaUEX8uFpz@kroah.com>
On 13/09/21 9:48 pm, Greg KH wrote:
> On Fri, Sep 10, 2021 at 11:24:39PM +0530, Saurav Girepunje wrote:
>> Remove the function power_saving_wk_hdl() as it just calling
>> the rtw_ps_processor().Instead of power_saving_wk_hdl() call directly
>> rtw_ps_processor().
>>
>> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
>> ---
>> drivers/staging/r8188eu/core/rtw_cmd.c | 7 +------
>> 1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c
>> index ce73ac7cf973..35e6a943c556 100644
>> --- a/drivers/staging/r8188eu/core/rtw_cmd.c
>> +++ b/drivers/staging/r8188eu/core/rtw_cmd.c
>> @@ -1669,11 +1669,6 @@ u8 rtw_antenna_select_cmd(struct adapter *padapter, u8 antenna, u8 enqueue)
>> return res;
>> }
>>
>> -static void power_saving_wk_hdl(struct adapter *padapter, u8 *pbuf, int sz)
>> -{
>> - rtw_ps_processor(padapter);
>> -}
>> -
>> #ifdef CONFIG_88EU_P2P
>> u8 p2p_protocol_wk_cmd(struct adapter *padapter, int intCmdType)
>> {
>> @@ -1941,7 +1936,7 @@ u8 rtw_drvextra_cmd_hdl(struct adapter *padapter, unsigned char *pbuf)
>> dynamic_chk_wk_hdl(padapter, pdrvextra_cmd->pbuf, pdrvextra_cmd->type_size);
>> break;
>> case POWER_SAVING_CTRL_WK_CID:
>> - power_saving_wk_hdl(padapter, pdrvextra_cmd->pbuf, pdrvextra_cmd->type_size);
>> + rtw_ps_processor(padapter);
>> break;
>> case LPS_CTRL_WK_CID:
>> lps_ctrl_wk_hdl(padapter, (u8)pdrvextra_cmd->type_size);
>> --
>> 2.32.0
>>
>>
>
> Also does not apply to my tree. Please rebase against my staging-next
> branch and resend.
>
> thanks,
>
> greg k-h
>
Hi Greg,
I always do rebase against your staging-testing branch. Can you help me
to understand.When we need to rebase on staging-next. Do we always need
to rebase against staging-next..!
Regards,
Saurav Girepunje
next prev parent reply other threads:[~2021-09-18 17:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 17:54 [PATCH] staging: r8188eu: core: remove the function power_saving_wk_hdl Saurav Girepunje
2021-09-13 16:18 ` Greg KH
2021-09-18 17:22 ` Saurav Girepunje [this message]
2021-09-20 10:36 ` Greg KH
2021-09-20 11:13 ` Fabio M. De Francesco
2021-09-20 11:32 ` Dan Carpenter
2021-09-20 12:31 ` Fabio M. De Francesco
2021-09-20 12:39 ` Dan Carpenter
2021-09-20 13:54 ` Fabio M. De Francesco
2021-09-25 6:14 ` Saurav Girepunje
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45c4de06-f618-4352-91ea-885edecdf8bb@gmail.com \
--to=saurav.girepunje@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=saurav.girepunje@hotmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).