* [PATCH] staging: rtl8192e: Rename Tx_Retry_Count_Reg
@ 2022-09-24 22:51 Dragan Cvetic
2022-09-25 19:26 ` Philipp Hortmann
0 siblings, 1 reply; 2+ messages in thread
From: Dragan Cvetic @ 2022-09-24 22:51 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Dragan Cvetic
Rename: Current_Tx_Rate_Reg to CURRENT_TX_RATE_REG, Initial_Tx_Rate_Reg to
INITIAL_TX_RATE_REG and Tx_Retry_Count_Reg to TX_RETRY_COUNT_REG to avoid
CamelCase which is not accepted by checkpatch.pl.
Signed-off-by: Dragan Cvetic <dragan.m.cvetic@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 11 +++--------
drivers/staging/rtl8192e/rtl8192e/rtl_dm.h | 6 +++---
2 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
index 3ee52147960e..9fefa1a7ae75 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
@@ -2499,14 +2499,9 @@ static void _rtl92e_dm_check_txrateandretrycount(struct net_device *dev)
struct r8192_priv *priv = rtllib_priv(dev);
struct rtllib_device *ieee = priv->rtllib;
- ieee->softmac_stats.CurrentShowTxate = rtl92e_readb(dev,
- Current_Tx_Rate_Reg);
-
- ieee->softmac_stats.last_packet_rate = rtl92e_readb(dev,
- Initial_Tx_Rate_Reg);
-
- ieee->softmac_stats.txretrycount = rtl92e_readl(dev,
- Tx_Retry_Count_Reg);
+ ieee->softmac_stats.CurrentShowTxate = rtl92e_readb(dev, CURRENT_TX_RATE_REG);
+ ieee->softmac_stats.last_packet_rate = rtl92e_readb(dev, INITIAL_TX_RATE_REG);
+ ieee->softmac_stats.txretrycount = rtl92e_readl(dev, TX_RETRY_COUNT_REG);
}
static void _rtl92e_dm_send_rssi_to_fw(struct net_device *dev)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h
index ea1b14bbcdcd..51e295d389a8 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h
@@ -42,9 +42,9 @@
#define TX_POWER_ATHEROAP_THRESH_HIGH 78
#define TX_POWER_ATHEROAP_THRESH_LOW 72
-#define Current_Tx_Rate_Reg 0x1e0
-#define Initial_Tx_Rate_Reg 0x1e1
-#define Tx_Retry_Count_Reg 0x1ac
+#define CURRENT_TX_RATE_REG 0x1e0
+#define INITIAL_TX_RATE_REG 0x1e1
+#define TX_RETRY_COUNT_REG 0x1ac
#define RegC38_TH 20
#define DM_Type_ByDriver 1
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8192e: Rename Tx_Retry_Count_Reg
2022-09-24 22:51 [PATCH] staging: rtl8192e: Rename Tx_Retry_Count_Reg Dragan Cvetic
@ 2022-09-25 19:26 ` Philipp Hortmann
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Hortmann @ 2022-09-25 19:26 UTC (permalink / raw)
To: Dragan Cvetic, gregkh; +Cc: linux-staging, linux-kernel
On 9/25/22 00:51, Dragan Cvetic wrote:
> Rename: Current_Tx_Rate_Reg to CURRENT_TX_RATE_REG, Initial_Tx_Rate_Reg to
> INITIAL_TX_RATE_REG and Tx_Retry_Count_Reg to TX_RETRY_COUNT_REG to avoid
> CamelCase which is not accepted by checkpatch.pl.
>
> Signed-off-by: Dragan Cvetic <dragan.m.cvetic@gmail.com>
> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 11 +++--------
> drivers/staging/rtl8192e/rtl8192e/rtl_dm.h | 6 +++---
> 2 files changed, 6 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> index 3ee52147960e..9fefa1a7ae75 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> @@ -2499,14 +2499,9 @@ static void _rtl92e_dm_check_txrateandretrycount(struct net_device *dev)
> struct r8192_priv *priv = rtllib_priv(dev);
> struct rtllib_device *ieee = priv->rtllib;
>
> - ieee->softmac_stats.CurrentShowTxate = rtl92e_readb(dev,
> - Current_Tx_Rate_Reg);
> -
> - ieee->softmac_stats.last_packet_rate = rtl92e_readb(dev,
> - Initial_Tx_Rate_Reg);
> -
> - ieee->softmac_stats.txretrycount = rtl92e_readl(dev,
> - Tx_Retry_Count_Reg);
> + ieee->softmac_stats.CurrentShowTxate = rtl92e_readb(dev, CURRENT_TX_RATE_REG);
> + ieee->softmac_stats.last_packet_rate = rtl92e_readb(dev, INITIAL_TX_RATE_REG);
> + ieee->softmac_stats.txretrycount = rtl92e_readl(dev, TX_RETRY_COUNT_REG);
> }
>
> static void _rtl92e_dm_send_rssi_to_fw(struct net_device *dev)
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h
> index ea1b14bbcdcd..51e295d389a8 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h
> @@ -42,9 +42,9 @@
> #define TX_POWER_ATHEROAP_THRESH_HIGH 78
> #define TX_POWER_ATHEROAP_THRESH_LOW 72
>
> -#define Current_Tx_Rate_Reg 0x1e0
> -#define Initial_Tx_Rate_Reg 0x1e1
> -#define Tx_Retry_Count_Reg 0x1ac
> +#define CURRENT_TX_RATE_REG 0x1e0
> +#define INITIAL_TX_RATE_REG 0x1e1
> +#define TX_RETRY_COUNT_REG 0x1ac
> #define RegC38_TH 20
>
> #define DM_Type_ByDriver 1
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-25 19:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-24 22:51 [PATCH] staging: rtl8192e: Rename Tx_Retry_Count_Reg Dragan Cvetic
2022-09-25 19:26 ` Philipp Hortmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).