From: Felix Schlepper <f3sch.git@outlook.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
wjsota@gmail.com, Felix Schlepper <f3sch.git@outlook.com>
Subject: [PATCH v3 4/6] Staging: rtl8192e: Added braces around else
Date: Fri, 1 Jul 2022 11:24:52 +0200 [thread overview]
Message-ID: <651f51d9f92e8a445ceaf9f2073f16dd10458a74.1656667089.git.f3sch.git@outlook.com> (raw)
In-Reply-To: <cover.1656667089.git.f3sch.git@outlook.com>
This addresses two issues raised by checkpatch.pl:
$ ./scripts/checkpatch.pl --terse -f drivers/staging/rtl8192e/rtllib_wx.c
CHECK: braces {} should be used on all arms of this statement
CHECK: Unbalanced braces around else statement
The coding style rule with not using unnecessary braces around if/else
does not apply if only one branch is a single statement.
Signed-off-by: Felix Schlepper <f3sch.git@outlook.com>
---
drivers/staging/rtl8192e/rtllib_wx.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c
index db076e819993..b949e7234150 100644
--- a/drivers/staging/rtl8192e/rtllib_wx.c
+++ b/drivers/staging/rtl8192e/rtllib_wx.c
@@ -304,8 +304,9 @@ int rtllib_wx_set_encode(struct rtllib_device *ieee,
netdev_dbg(ieee->dev,
"Disabling encryption on key %d.\n", key);
lib80211_crypt_delayed_deinit(&ieee->crypt_info, crypt);
- } else
+ } else {
netdev_dbg(ieee->dev, "Disabling encryption.\n");
+ }
/* Check all the keys to see if any are still configured,
* and if no key index was provided, de-init them all
@@ -724,8 +725,9 @@ int rtllib_wx_set_auth(struct rtllib_device *ieee,
} else if (data->value & IW_AUTH_ALG_LEAP) {
ieee->open_wep = 1;
ieee->auth_mode = 2;
- } else
+ } else {
return -EINVAL;
+ }
break;
case IW_AUTH_WPA_ENABLED:
--
2.36.1
next prev parent reply other threads:[~2022-07-01 9:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 9:24 [PATCH v3 0/6] Staging: rtl8192e: rtllib_wx Felix Schlepper
2022-07-01 9:24 ` [PATCH v3 1/6] Staging: rtl8192e: Refactored rtllib_modes Felix Schlepper
2022-07-02 6:07 ` Philipp Hortmann
2022-07-01 9:24 ` [PATCH v3 2/6] Staging: rtl8192e: Avoid multiple assignments Felix Schlepper
2022-07-02 6:08 ` Philipp Hortmann
2022-07-01 9:24 ` [PATCH v3 3/6] Staging: rtl8192e: Remove unnecessary parentheses Felix Schlepper
2022-07-02 6:09 ` Philipp Hortmann
2022-07-01 9:24 ` Felix Schlepper [this message]
2022-07-02 6:10 ` [PATCH v3 4/6] Staging: rtl8192e: Added braces around else Philipp Hortmann
2022-07-01 9:24 ` [PATCH v3 5/6] Staging: rtl8192e: Remove unnecessary blank line Felix Schlepper
2022-07-02 6:11 ` Philipp Hortmann
2022-07-01 9:24 ` [PATCH v3 6/6] Staging: rtl8192e: Added spaces around '+' Felix Schlepper
2022-07-02 6:11 ` Philipp Hortmann
2022-07-02 6:17 ` [PATCH v3 0/6] Staging: rtl8192e: rtllib_wx Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=651f51d9f92e8a445ceaf9f2073f16dd10458a74.1656667089.git.f3sch.git@outlook.com \
--to=f3sch.git@outlook.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=wjsota@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).