From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Felix Schlepper <f3sch.git@outlook.com>, gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
wjsota@gmail.com
Subject: Re: [PATCH v3 3/6] Staging: rtl8192e: Remove unnecessary parentheses
Date: Sat, 2 Jul 2022 08:09:01 +0200 [thread overview]
Message-ID: <9c7673b3-29ec-8a4d-0571-c869bc60b567@gmail.com> (raw)
In-Reply-To: <0e4e340be3f4c7f35a5381b726b1db5fc6842f10.1656667089.git.f3sch.git@outlook.com>
On 7/1/22 11:24, Felix Schlepper wrote:
> This addresses an issue raised by checkpatch.pl:
>
> $ ./scripts/checkpatch.pl --terse -f drivers/staging/rtl8192e/rtllib_wx.c
> Unnecessary parentheses around wrqu->encoding
>
> Signed-off-by: Felix Schlepper <f3sch.git@outlook.com>
> ---
> drivers/staging/rtl8192e/rtllib_wx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c
> index 121bf939c6a4..db076e819993 100644
> --- a/drivers/staging/rtl8192e/rtllib_wx.c
> +++ b/drivers/staging/rtl8192e/rtllib_wx.c
> @@ -277,7 +277,7 @@ int rtllib_wx_set_encode(struct rtllib_device *ieee,
> struct iw_request_info *info,
> union iwreq_data *wrqu, char *keybuf)
> {
> - struct iw_point *erq = &(wrqu->encoding);
> + struct iw_point *erq = &wrqu->encoding;
> struct net_device *dev = ieee->dev;
> struct rtllib_security sec = {
> .flags = 0
> @@ -449,7 +449,7 @@ int rtllib_wx_get_encode(struct rtllib_device *ieee,
> struct iw_request_info *info,
> union iwreq_data *wrqu, char *keybuf)
> {
> - struct iw_point *erq = &(wrqu->encoding);
> + struct iw_point *erq = &wrqu->encoding;
> int len, key;
> struct lib80211_crypt_data *crypt;
>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
next prev parent reply other threads:[~2022-07-02 6:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 9:24 [PATCH v3 0/6] Staging: rtl8192e: rtllib_wx Felix Schlepper
2022-07-01 9:24 ` [PATCH v3 1/6] Staging: rtl8192e: Refactored rtllib_modes Felix Schlepper
2022-07-02 6:07 ` Philipp Hortmann
2022-07-01 9:24 ` [PATCH v3 2/6] Staging: rtl8192e: Avoid multiple assignments Felix Schlepper
2022-07-02 6:08 ` Philipp Hortmann
2022-07-01 9:24 ` [PATCH v3 3/6] Staging: rtl8192e: Remove unnecessary parentheses Felix Schlepper
2022-07-02 6:09 ` Philipp Hortmann [this message]
2022-07-01 9:24 ` [PATCH v3 4/6] Staging: rtl8192e: Added braces around else Felix Schlepper
2022-07-02 6:10 ` Philipp Hortmann
2022-07-01 9:24 ` [PATCH v3 5/6] Staging: rtl8192e: Remove unnecessary blank line Felix Schlepper
2022-07-02 6:11 ` Philipp Hortmann
2022-07-01 9:24 ` [PATCH v3 6/6] Staging: rtl8192e: Added spaces around '+' Felix Schlepper
2022-07-02 6:11 ` Philipp Hortmann
2022-07-02 6:17 ` [PATCH v3 0/6] Staging: rtl8192e: rtllib_wx Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c7673b3-29ec-8a4d-0571-c869bc60b567@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=f3sch.git@outlook.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=wjsota@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).