linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	f3sch.git@outlook.com, guozihua@huawei.com,
	 linux-staging@lists.linux.dev,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] staging: rtl8192e: removes blank line
Date: Mon, 19 Sep 2022 15:19:19 -0400	[thread overview]
Message-ID: <CAFSeFg-awEMyZjePcvO_Mo3k_pFX-Kq85Uvbub6bmA7XkQ7zZA@mail.gmail.com> (raw)
In-Reply-To: <590b49c9-5940-c7e6-0a23-9a82cd06fe62@gmail.com>

On Mon, Sep 19, 2022 at 2:41 PM Philipp Hortmann
<philipp.g.hortmann@gmail.com> wrote:
>
> On 9/19/22 15:58, Aruna Hewapathirane wrote:
> > This patch fixes a checkpatch CHECK issue
> > CHECK: Please don't use multiple blank lines
> >
> > Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
> > ---
> >   drivers/staging/rtl8192e/rtllib_tx.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
> > index d5275319a486..f651947f6b44 100644
> > --- a/drivers/staging/rtl8192e/rtllib_tx.c
> > +++ b/drivers/staging/rtl8192e/rtllib_tx.c
> > @@ -920,7 +920,6 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
> >                                       tcb_desc->bTxDisableRateFallBack = 1;
> >                               }
> >
> > -
> >                               tcb_desc->RATRIndex = 7;
> >                               tcb_desc->bTxUseDriverAssingedRate = 1;
> >                               tcb_desc->bdhcp = 1;
>
> Please avoid the 2/2 in the subject. This is only for patch series.

I will do so in future I did not know this. My apologies.

> Create a version 2 of this patch with change history.

I have no idea how to create a version2 with a change history but I am
going to Google and see what I can find.

> Removing blank lines is OK but do this for the entire document.

Ah.. of course makes  sense. Once again my apologies.

> Add the file name to the subject to make it more unique.

I will do so. Thank you Philipp.

>
>
> Bye Philipp


On Mon, Sep 19, 2022 at 2:41 PM Philipp Hortmann
<philipp.g.hortmann@gmail.com> wrote:
>
> On 9/19/22 15:58, Aruna Hewapathirane wrote:
> > This patch fixes a checkpatch CHECK issue
> > CHECK: Please don't use multiple blank lines
> >
> > Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
> > ---
> >   drivers/staging/rtl8192e/rtllib_tx.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
> > index d5275319a486..f651947f6b44 100644
> > --- a/drivers/staging/rtl8192e/rtllib_tx.c
> > +++ b/drivers/staging/rtl8192e/rtllib_tx.c
> > @@ -920,7 +920,6 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
> >                                       tcb_desc->bTxDisableRateFallBack = 1;
> >                               }
> >
> > -
> >                               tcb_desc->RATRIndex = 7;
> >                               tcb_desc->bTxUseDriverAssingedRate = 1;
> >                               tcb_desc->bdhcp = 1;
>
> Please avoid the 2/2 in the subject. This is only for patch series.
> Create a version 2 of this patch with change history.
> Removing blank lines is OK but do this for the entire document.
> Add the file name to the subject to make it more unique.
>
> Bye Philipp

      reply	other threads:[~2022-09-19 19:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-19 13:58 [PATCH 2/2] staging: rtl8192e: removes blank line Aruna Hewapathirane
2022-09-19 18:41 ` Philipp Hortmann
2022-09-19 19:19   ` Aruna Hewapathirane [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFSeFg-awEMyZjePcvO_Mo3k_pFX-Kq85Uvbub6bmA7XkQ7zZA@mail.gmail.com \
    --to=aruna.hewapathirane@gmail.com \
    --cc=f3sch.git@outlook.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=guozihua@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).