* [PATCH 2/2] staging: rtl8192e: removes blank line
@ 2022-09-19 13:58 Aruna Hewapathirane
2022-09-19 18:41 ` Philipp Hortmann
0 siblings, 1 reply; 3+ messages in thread
From: Aruna Hewapathirane @ 2022-09-19 13:58 UTC (permalink / raw)
To: gregkh
Cc: f3sch.git, guozihua, linux-staging, aruna.hewapathirane, linux-kernel
This patch fixes a checkpatch CHECK issue
CHECK: Please don't use multiple blank lines
Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
---
drivers/staging/rtl8192e/rtllib_tx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
index d5275319a486..f651947f6b44 100644
--- a/drivers/staging/rtl8192e/rtllib_tx.c
+++ b/drivers/staging/rtl8192e/rtllib_tx.c
@@ -920,7 +920,6 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
tcb_desc->bTxDisableRateFallBack = 1;
}
-
tcb_desc->RATRIndex = 7;
tcb_desc->bTxUseDriverAssingedRate = 1;
tcb_desc->bdhcp = 1;
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] staging: rtl8192e: removes blank line
2022-09-19 13:58 [PATCH 2/2] staging: rtl8192e: removes blank line Aruna Hewapathirane
@ 2022-09-19 18:41 ` Philipp Hortmann
2022-09-19 19:19 ` Aruna Hewapathirane
0 siblings, 1 reply; 3+ messages in thread
From: Philipp Hortmann @ 2022-09-19 18:41 UTC (permalink / raw)
To: Aruna Hewapathirane, gregkh
Cc: f3sch.git, guozihua, linux-staging, linux-kernel
On 9/19/22 15:58, Aruna Hewapathirane wrote:
> This patch fixes a checkpatch CHECK issue
> CHECK: Please don't use multiple blank lines
>
> Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
> ---
> drivers/staging/rtl8192e/rtllib_tx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
> index d5275319a486..f651947f6b44 100644
> --- a/drivers/staging/rtl8192e/rtllib_tx.c
> +++ b/drivers/staging/rtl8192e/rtllib_tx.c
> @@ -920,7 +920,6 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
> tcb_desc->bTxDisableRateFallBack = 1;
> }
>
> -
> tcb_desc->RATRIndex = 7;
> tcb_desc->bTxUseDriverAssingedRate = 1;
> tcb_desc->bdhcp = 1;
Please avoid the 2/2 in the subject. This is only for patch series.
Create a version 2 of this patch with change history.
Removing blank lines is OK but do this for the entire document.
Add the file name to the subject to make it more unique.
Bye Philipp
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] staging: rtl8192e: removes blank line
2022-09-19 18:41 ` Philipp Hortmann
@ 2022-09-19 19:19 ` Aruna Hewapathirane
0 siblings, 0 replies; 3+ messages in thread
From: Aruna Hewapathirane @ 2022-09-19 19:19 UTC (permalink / raw)
To: Philipp Hortmann
Cc: Greg KH, f3sch.git, guozihua, linux-staging, linux-kernel
On Mon, Sep 19, 2022 at 2:41 PM Philipp Hortmann
<philipp.g.hortmann@gmail.com> wrote:
>
> On 9/19/22 15:58, Aruna Hewapathirane wrote:
> > This patch fixes a checkpatch CHECK issue
> > CHECK: Please don't use multiple blank lines
> >
> > Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
> > ---
> > drivers/staging/rtl8192e/rtllib_tx.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
> > index d5275319a486..f651947f6b44 100644
> > --- a/drivers/staging/rtl8192e/rtllib_tx.c
> > +++ b/drivers/staging/rtl8192e/rtllib_tx.c
> > @@ -920,7 +920,6 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
> > tcb_desc->bTxDisableRateFallBack = 1;
> > }
> >
> > -
> > tcb_desc->RATRIndex = 7;
> > tcb_desc->bTxUseDriverAssingedRate = 1;
> > tcb_desc->bdhcp = 1;
>
> Please avoid the 2/2 in the subject. This is only for patch series.
I will do so in future I did not know this. My apologies.
> Create a version 2 of this patch with change history.
I have no idea how to create a version2 with a change history but I am
going to Google and see what I can find.
> Removing blank lines is OK but do this for the entire document.
Ah.. of course makes sense. Once again my apologies.
> Add the file name to the subject to make it more unique.
I will do so. Thank you Philipp.
>
>
> Bye Philipp
On Mon, Sep 19, 2022 at 2:41 PM Philipp Hortmann
<philipp.g.hortmann@gmail.com> wrote:
>
> On 9/19/22 15:58, Aruna Hewapathirane wrote:
> > This patch fixes a checkpatch CHECK issue
> > CHECK: Please don't use multiple blank lines
> >
> > Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
> > ---
> > drivers/staging/rtl8192e/rtllib_tx.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
> > index d5275319a486..f651947f6b44 100644
> > --- a/drivers/staging/rtl8192e/rtllib_tx.c
> > +++ b/drivers/staging/rtl8192e/rtllib_tx.c
> > @@ -920,7 +920,6 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
> > tcb_desc->bTxDisableRateFallBack = 1;
> > }
> >
> > -
> > tcb_desc->RATRIndex = 7;
> > tcb_desc->bTxUseDriverAssingedRate = 1;
> > tcb_desc->bdhcp = 1;
>
> Please avoid the 2/2 in the subject. This is only for patch series.
> Create a version 2 of this patch with change history.
> Removing blank lines is OK but do this for the entire document.
> Add the file name to the subject to make it more unique.
>
> Bye Philipp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-19 19:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-19 13:58 [PATCH 2/2] staging: rtl8192e: removes blank line Aruna Hewapathirane
2022-09-19 18:41 ` Philipp Hortmann
2022-09-19 19:19 ` Aruna Hewapathirane
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).