* [PATCH v6 1/2] staging: rtl8192e: remove parentheses around boolean expression
2021-04-14 7:21 [PATCH v6 0/2] staging: rtl8192e: Clean up patchset for style issues in rtl819x_HTProc.c Mitali Borkar
@ 2021-04-14 7:21 ` Mitali Borkar
2021-04-14 8:31 ` Greg KH
2021-04-14 7:22 ` [PATCH v6 2/2] staging: rtl8192e: remove casts and parentheses Mitali Borkar
1 sibling, 1 reply; 4+ messages in thread
From: Mitali Borkar @ 2021-04-14 7:21 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, outreachy-kernel, mitali_s
Removed unnecessary parentheses around '!xyz' boolean expression as '!'
has higher precedance than '||'
Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
---
Changes from v5:- No changes.
Changes from v4:- No changes.
Changes from v3:- No changes.
Changes from v2:- Modified subject description. Changes has been made in
v3.
Changes from v1:- Removed unnecessary parentheses around boolean
expression. Changes has been made in v2.
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index b1fa8e9a4f28..431202927036 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -276,7 +276,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,
struct rt_hi_throughput *pHT = ieee->pHTInfo;
struct ht_capab_ele *pCapELE = NULL;
- if ((!posHTCap) || (!pHT)) {
+ if (!posHTCap || !pHT) {
netdev_warn(ieee->dev,
"%s(): posHTCap and pHTInfo are null\n", __func__);
return;
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v6 2/2] staging: rtl8192e: remove casts and parentheses
2021-04-14 7:21 [PATCH v6 0/2] staging: rtl8192e: Clean up patchset for style issues in rtl819x_HTProc.c Mitali Borkar
2021-04-14 7:21 ` [PATCH v6 1/2] staging: rtl8192e: remove parentheses around boolean expression Mitali Borkar
@ 2021-04-14 7:22 ` Mitali Borkar
1 sibling, 0 replies; 4+ messages in thread
From: Mitali Borkar @ 2021-04-14 7:22 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, outreachy-kernel, mitali_s
Removed unnecessary (void *) cast and parentheses to meet linux kernel
coding style.
Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
---
Changes from v5:- No changes.
Changes from v4:- Removed unnecessary casts and parentheses.
Changes from v3:- No changes.
Changes from v2:- Rectified spelling mistake in subject description.
Changes has been made in v3.
Changes from v1:- No changes.
drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 431202927036..ec6b46166e84 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -646,14 +646,10 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density;
pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;
- memset((void *)(&pHTInfo->SelfHTCap), 0,
- sizeof(pHTInfo->SelfHTCap));
- memset((void *)(&pHTInfo->SelfHTInfo), 0,
- sizeof(pHTInfo->SelfHTInfo));
- memset((void *)(&pHTInfo->PeerHTCapBuf), 0,
- sizeof(pHTInfo->PeerHTCapBuf));
- memset((void *)(&pHTInfo->PeerHTInfoBuf), 0,
- sizeof(pHTInfo->PeerHTInfoBuf));
+ memset(&pHTInfo->SelfHTCap, 0, sizeof(pHTInfo->SelfHTCap));
+ memset(&pHTInfo->SelfHTInfo, 0, sizeof(pHTInfo->SelfHTInfo));
+ memset(&pHTInfo->PeerHTCapBuf, 0, sizeof(pHTInfo->PeerHTCapBuf));
+ memset(&pHTInfo->PeerHTInfoBuf, 0, sizeof(pHTInfo->PeerHTInfoBuf));
pHTInfo->bSwBwInProgress = false;
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread