Linux kernel staging patches
 help / color / Atom feed
* [PATCH] staging: rtl8188eu: core: Remove set but unused variable
@ 2021-07-01 15:46 Fabio M. De Francesco
  2021-07-21  8:18 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 4+ messages in thread
From: Fabio M. De Francesco @ 2021-07-01 15:46 UTC (permalink / raw)
  To: Larry Finger, Greg Kroah-Hartman, linux-staging, linux-kernel
  Cc: Fabio M. De Francesco

Remove variable sec_idx because is set but unused. Issue detected by
GCC with -Wunused-variable.

Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
---
 drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c b/drivers/staging/rtl8188eu/core/rtw_ieee80211.c
index e431914db008..ce82b866c633 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8188eu/core/rtw_ieee80211.c
@@ -465,7 +465,7 @@ int rtw_parse_wpa2_ie(u8 *rsn_ie, int rsn_ie_len, int *group_cipher, int *pairwi
 
 void rtw_get_sec_ie(u8 *in_ie, uint in_len, u8 *rsn_ie, u16 *rsn_len, u8 *wpa_ie, u16 *wpa_len)
 {
-	u8 authmode, sec_idx;
+	u8 authmode;
 	u8 wpa_oui[4] = {0x0, 0x50, 0xf2, 0x01};
 	uint cnt;
 
@@ -473,8 +473,6 @@ void rtw_get_sec_ie(u8 *in_ie, uint in_len, u8 *rsn_ie, u16 *rsn_len, u8 *wpa_ie
 
 	cnt = _TIMESTAMP_ + _BEACON_ITERVAL_ + _CAPABILITY_;
 
-	sec_idx = 0;
-
 	while (cnt < in_len) {
 		authmode = in_ie[cnt];
 
-- 
2.32.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] staging: rtl8188eu: core: Remove set but unused variable
  2021-07-01 15:46 [PATCH] staging: rtl8188eu: core: Remove set but unused variable Fabio M. De Francesco
@ 2021-07-21  8:18 ` Greg Kroah-Hartman
  2021-07-21 13:35   ` Fabio M. De Francesco
  0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2021-07-21  8:18 UTC (permalink / raw)
  To: Fabio M. De Francesco; +Cc: Larry Finger, linux-staging, linux-kernel

On Thu, Jul 01, 2021 at 05:46:47PM +0200, Fabio M. De Francesco wrote:
> Remove variable sec_idx because is set but unused. Issue detected by
> GCC with -Wunused-variable.
> 
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Does not apply to my tree :(

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] staging: rtl8188eu: core: Remove set but unused variable
  2021-07-21  8:18 ` Greg Kroah-Hartman
@ 2021-07-21 13:35   ` Fabio M. De Francesco
  2021-07-21 13:41     ` Greg Kroah-Hartman
  0 siblings, 1 reply; 4+ messages in thread
From: Fabio M. De Francesco @ 2021-07-21 13:35 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: Larry Finger, linux-staging

On Wednesday, July 21, 2021 10:18:34 AM CEST Greg Kroah-Hartman wrote:
> On Thu, Jul 01, 2021 at 05:46:47PM +0200, Fabio M. De Francesco wrote:
> > Remove variable sec_idx because is set but unused. Issue detected by
> > GCC with -Wunused-variable.
> > 
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > ---
> > 
> >  drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> Does not apply to my tree :(
>
Your tree changed while my patch was expecting your review. This happened 
because someone else worked on the same code while 
"the development tree you have sent a patch for is "closed"
due to the timing of the merge window".

Unfortunately,  I was unaware of a similar patch in your queue because I 
didn't notice that it was sent to the linux-staging list a few days before 
mine.

This is not the first time that something like this happens, so I think it's 
better to not work and send patches while you keep the development tree 
closed.

Sorry for wasting your time.

Thanks,

Fabio




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] staging: rtl8188eu: core: Remove set but unused variable
  2021-07-21 13:35   ` Fabio M. De Francesco
@ 2021-07-21 13:41     ` Greg Kroah-Hartman
  0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2021-07-21 13:41 UTC (permalink / raw)
  To: Fabio M. De Francesco; +Cc: Larry Finger, linux-staging

On Wed, Jul 21, 2021 at 03:35:18PM +0200, Fabio M. De Francesco wrote:
> On Wednesday, July 21, 2021 10:18:34 AM CEST Greg Kroah-Hartman wrote:
> > On Thu, Jul 01, 2021 at 05:46:47PM +0200, Fabio M. De Francesco wrote:
> > > Remove variable sec_idx because is set but unused. Issue detected by
> > > GCC with -Wunused-variable.
> > > 
> > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > > ---
> > > 
> > >  drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > Does not apply to my tree :(
> >
> Your tree changed while my patch was expecting your review. This happened 
> because someone else worked on the same code while 
> "the development tree you have sent a patch for is "closed"
> due to the timing of the merge window".
> 
> Unfortunately,  I was unaware of a similar patch in your queue because I 
> didn't notice that it was sent to the linux-staging list a few days before 
> mine.
> 
> This is not the first time that something like this happens, so I think it's 
> better to not work and send patches while you keep the development tree 
> closed.

The only time it is "closed" is during the merge window.  No need to
stop doing work during then, it's easy to rebase and resend if there are
ever problems.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-01 15:46 [PATCH] staging: rtl8188eu: core: Remove set but unused variable Fabio M. De Francesco
2021-07-21  8:18 ` Greg Kroah-Hartman
2021-07-21 13:35   ` Fabio M. De Francesco
2021-07-21 13:41     ` Greg Kroah-Hartman

Linux kernel staging patches

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-staging/0 linux-staging/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-staging linux-staging/ https://lore.kernel.org/linux-staging \
		linux-staging@lists.linux.dev
	public-inbox-index linux-staging

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/dev.linux.lists.linux-staging


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git