* [RFC PATCH v4 11/11] fbdev: Make registered_fb[] private to fbmem.c
[not found] <20220429084253.1085911-1-javierm@redhat.com>
@ 2022-04-29 8:42 ` Javier Martinez Canillas
2022-04-29 15:02 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2022-04-29 8:42 UTC (permalink / raw)
To: linux-kernel
Cc: dri-devel, Daniel Vetter, Greg Kroah-Hartman, Thomas Zimmermann,
kernel test robot, Jens Frederich, Jon Nettleton, linux-staging,
Daniel Vetter, Javier Martinez Canillas, Daniel Vetter,
Helge Deller, Matthew Wilcox, Sam Ravnborg, Tetsuo Handa,
Zhen Lei, Alex Deucher, Xiyu Yang, linux-fbdev, Zheyu Ma,
Guenter Roeck, Changcheng Deng
From: Daniel Vetter <daniel.vetter@ffwll.ch>
Well except when the olpc dcon fbdev driver is enabled, that thing
digs around in there in rather unfixable ways.
Cc oldc_dcon maintainers as fyi.
v2: I typoed the config name (0day)
Cc: kernel test robot <lkp@intel.com>
Cc: Jens Frederich <jfrederich@gmail.com>
Cc: Jon Nettleton <jon.nettleton@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Helge Deller <deller@gmx.de>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Cc: linux-fbdev@vger.kernel.org
Cc: Zheyu Ma <zheyuma97@gmail.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
(no changes since v1)
drivers/video/fbdev/core/fbmem.c | 8 ++++++--
include/linux/fb.h | 7 +++----
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c
index 7583296481b0..1ce5b0f3abd4 100644
--- a/drivers/video/fbdev/core/fbmem.c
+++ b/drivers/video/fbdev/core/fbmem.c
@@ -50,10 +50,14 @@
static DEFINE_MUTEX(registration_lock);
struct fb_info *registered_fb[FB_MAX] __read_mostly;
-EXPORT_SYMBOL(registered_fb);
-
int num_registered_fb __read_mostly;
+#if IS_ENABLED(CONFIG_FB_OLPC_DCON)
+EXPORT_SYMBOL(registered_fb);
EXPORT_SYMBOL(num_registered_fb);
+#endif
+#define for_each_registered_fb(i) \
+ for (i = 0; i < FB_MAX; i++) \
+ if (!registered_fb[i]) {} else
bool fb_center_logo __read_mostly;
diff --git a/include/linux/fb.h b/include/linux/fb.h
index b781bc721113..208bca693b33 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -623,16 +623,15 @@ extern int fb_get_color_depth(struct fb_var_screeninfo *var,
extern int fb_get_options(const char *name, char **option);
extern int fb_new_modelist(struct fb_info *info);
+#if IS_ENABLED(CONFIG_FB_OLPC_DCON)
extern struct fb_info *registered_fb[FB_MAX];
+
extern int num_registered_fb;
+#endif
extern bool fb_center_logo;
extern int fb_logo_count;
extern struct class *fb_class;
-#define for_each_registered_fb(i) \
- for (i = 0; i < FB_MAX; i++) \
- if (!registered_fb[i]) {} else
-
static inline void lock_fb_info(struct fb_info *info)
{
mutex_lock(&info->lock);
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC PATCH v4 11/11] fbdev: Make registered_fb[] private to fbmem.c
2022-04-29 8:42 ` [RFC PATCH v4 11/11] fbdev: Make registered_fb[] private to fbmem.c Javier Martinez Canillas
@ 2022-04-29 15:02 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2022-04-29 15:02 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, dri-devel, Daniel Vetter, Greg Kroah-Hartman,
Thomas Zimmermann, kernel test robot, Jens Frederich,
Jon Nettleton, linux-staging, Daniel Vetter, Daniel Vetter,
Helge Deller, Matthew Wilcox, Sam Ravnborg, Tetsuo Handa,
Zhen Lei, Alex Deucher, Xiyu Yang, linux-fbdev, Zheyu Ma,
Guenter Roeck, Changcheng Deng
On Fri, Apr 29, 2022 at 10:42:53AM +0200, Javier Martinez Canillas wrote:
> From: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Well except when the olpc dcon fbdev driver is enabled, that thing
> digs around in there in rather unfixable ways.
>
> Cc oldc_dcon maintainers as fyi.
>
> v2: I typoed the config name (0day)
We should not keep broken code and/or core code ifdefs around for
staging drivers. Just disable the driver if it is in such a bad
state.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-29 15:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220429084253.1085911-1-javierm@redhat.com>
2022-04-29 8:42 ` [RFC PATCH v4 11/11] fbdev: Make registered_fb[] private to fbmem.c Javier Martinez Canillas
2022-04-29 15:02 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).