* [PATCH]: staging: wlan-ng: Remove unnecessary Parentheses
@ 2023-03-25 0:22 Dalvin-Ehinoma Noah Aiguobas
2023-03-25 7:27 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Dalvin-Ehinoma Noah Aiguobas @ 2023-03-25 0:22 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel
Clean up Checkpatch issues by removing unnecessary Parentheses.
Signed-off-by: Dalvin-Ehinoma Noah Aiguobas <pharcodra@gmail.com>
---
drivers/staging/wlan-ng/cfg80211.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
index 471bb310176f..0b4d40ec7456 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -247,7 +247,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
memset(sinfo, 0, sizeof(*sinfo));
- if (!wlandev || (wlandev->msdstate != WLAN_MSD_RUNNING))
+ if (!wlandev || wlandev->msdstate != WLAN_MSD_RUNNING)
return -EOPNOTSUPP;
/* build request message */
@@ -351,8 +351,8 @@ static int prism2_scan(struct wiphy *wiphy,
msg2->bssindex.data = i;
result = p80211req_dorequest(wlandev, (u8 *)&msg2);
- if ((result != 0) ||
- (msg2->resultcode.data != P80211ENUM_resultcode_success)) {
+ if (result != 0 ||
+ msg2->resultcode.data != P80211ENUM_resultcode_success) {
break;
}
@@ -459,8 +459,8 @@ static int prism2_connect(struct wiphy *wiphy, struct net_device *dev,
}
/* Set the authorization */
- if ((sme->auth_type == NL80211_AUTHTYPE_OPEN_SYSTEM) ||
- ((sme->auth_type == NL80211_AUTHTYPE_AUTOMATIC) && !is_wep))
+ if (sme->auth_type == NL80211_AUTHTYPE_OPEN_SYSTEM ||
+ (sme->auth_type == NL80211_AUTHTYPE_AUTOMATIC && !is_wep))
msg_join.authtype.data = P80211ENUM_authalg_opensystem;
else if ((sme->auth_type == NL80211_AUTHTYPE_SHARED_KEY) ||
((sme->auth_type == NL80211_AUTHTYPE_AUTOMATIC) && is_wep))
@@ -478,7 +478,7 @@ static int prism2_connect(struct wiphy *wiphy, struct net_device *dev,
result = prism2_domibset_uint32(wlandev,
DIDMIB_DOT11SMT_PRIVACYTABLE_WEPDEFAULTKEYID,
- sme->key_idx);
+ sme->key_idx);
if (result)
goto exit;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH]: staging: wlan-ng: Remove unnecessary Parentheses
2023-03-25 0:22 [PATCH]: staging: wlan-ng: Remove unnecessary Parentheses Dalvin-Ehinoma Noah Aiguobas
@ 2023-03-25 7:27 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2023-03-25 7:27 UTC (permalink / raw)
To: Dalvin-Ehinoma Noah Aiguobas; +Cc: gregkh, linux-staging, linux-kernel
The subject has an extra : after the "[PATCH]:".
On Sat, Mar 25, 2023 at 01:22:25AM +0100, Dalvin-Ehinoma Noah Aiguobas wrote:
> Clean up Checkpatch issues by removing unnecessary Parentheses.
>
Just ignore checkpatch on this. Greg likes parentheses.
> @@ -478,7 +478,7 @@ static int prism2_connect(struct wiphy *wiphy, struct net_device *dev,
>
> result = prism2_domibset_uint32(wlandev,
> DIDMIB_DOT11SMT_PRIVACYTABLE_WEPDEFAULTKEYID,
> - sme->key_idx);
> + sme->key_idx);
Don't mix unrelated changes into the patch.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-25 7:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-25 0:22 [PATCH]: staging: wlan-ng: Remove unnecessary Parentheses Dalvin-Ehinoma Noah Aiguobas
2023-03-25 7:27 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).