archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] ata: ahci_sunxi: Disable DIPM
@ 2021-05-01 12:40 Timo Sigurdsson
  0 siblings, 0 replies; only message in thread
From: Timo Sigurdsson @ 2021-05-01 12:40 UTC (permalink / raw)
  To: axboe, mripard, wens, jernej.skrabec, linux-ide,
	linux-arm-kernel, linux-sunxi, linux-kernel
  Cc: sergei.shtylyov, gregkh, oliver, Timo Sigurdsson

DIPM is unsupported or broken on sunxi. Trying to enable the power
management policy med_power_with_dipm on an Allwinner A20 SoC based board
leads to immediate I/O errors and the attached SATA disk disappears from
the /dev filesystem. A reset (power cycle) is required to make the SATA
controller or disk work again. The A10 and A20 SoC data sheets and manuals
don't mention DIPM at all [1], so it's fair to assume that it's simply not
supported. But even if it was, it should be considered broken and best be
disabled in the ahci_sunxi driver.


Fixes: c5754b5220f0 ("ARM: sunxi: Add support for Allwinner SUNXi SoCs sata to ahci_platform")
Signed-off-by: Timo Sigurdsson <>
Tested-by: Timo Sigurdsson <>
Changes since v1:

- Formal changes to the commit message as suggested by Greg Kroah-Hartman
  and Sergei Shtylyov (Fixes and Cc lines). No changes to the patch
 drivers/ata/ahci_sunxi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/ahci_sunxi.c b/drivers/ata/ahci_sunxi.c
index cb69b737cb49..56b695136977 100644
--- a/drivers/ata/ahci_sunxi.c
+++ b/drivers/ata/ahci_sunxi.c
@@ -200,7 +200,7 @@ static void ahci_sunxi_start_engine(struct ata_port *ap)
 static const struct ata_port_info ahci_sunxi_port_info = {
 	.pio_mask	= ATA_PIO4,
 	.udma_mask	= ATA_UDMA6,
 	.port_ops	= &ahci_platform_ops,

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-05-01 12:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-01 12:40 [PATCH v2] ata: ahci_sunxi: Disable DIPM Timo Sigurdsson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).