linux-sunxi.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] ARM: dts: sun8i: v3s: add pwm controller to v3s dts
@ 2021-05-13 20:35 Tobias Schramm
  2021-05-13 20:35 ` [PATCH v2 1/2] dt-bindings: pwm: allwinner: add v3s pwm compatible Tobias Schramm
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Tobias Schramm @ 2021-05-13 20:35 UTC (permalink / raw)
  To: Jernej Škrabec, devicetree
  Cc: Rob Herring, Maxime Ripard, Chen-Yu Tsai, linux-arm-kernel,
	linux-sunxi, linux-kernel, Tobias Schramm

This patchset adds the pwm controller to the Allwinner V3s dts. The PWM
controller is compatible with the one found in the Allwinner A20.

This is v2 of this patchset.

Cheers,
Tobias

Changelog:
 - v2: add compatible for pwm controller of the V3s SoC

Tobias Schramm (2):
  dt-bindings: pwm: allwinner: add v3s pwm compatible
  ARM: dts: sun8i: v3s: add pwm controller to v3s dts

 .../devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml | 3 +++
 arch/arm/boot/dts/sun8i-v3s.dtsi                         | 9 +++++++++
 2 files changed, 12 insertions(+)

-- 
2.31.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v2 1/2] dt-bindings: pwm: allwinner: add v3s pwm compatible
  2021-05-13 20:35 [PATCH v2 0/2] ARM: dts: sun8i: v3s: add pwm controller to v3s dts Tobias Schramm
@ 2021-05-13 20:35 ` Tobias Schramm
  2021-05-14  7:02   ` Andre Przywara
  2021-05-18  1:15   ` Rob Herring
  2021-05-13 20:35 ` [PATCH v2 2/2] ARM: dts: sun8i: v3s: add pwm controller to v3s dts Tobias Schramm
  2021-05-18 14:41 ` [PATCH v2 0/2] " Maxime Ripard
  2 siblings, 2 replies; 7+ messages in thread
From: Tobias Schramm @ 2021-05-13 20:35 UTC (permalink / raw)
  To: Jernej Škrabec, devicetree
  Cc: Rob Herring, Maxime Ripard, Chen-Yu Tsai, linux-arm-kernel,
	linux-sunxi, linux-kernel, Tobias Schramm

The Allwinner V3s pwm peripheral is compatible with the pwm peripheral
inside the Allwinner A20.
This patch adds a compatible string for it.

Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>
---
 .../devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml       | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
index 7dcab2bf8128..04ff708fdc86 100644
--- a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
@@ -24,6 +24,9 @@ properties:
       - items:
           - const: allwinner,sun8i-a83t-pwm
           - const: allwinner,sun8i-h3-pwm
+      - items:
+          - const: allwinner,sun8i-v3s-pwm
+          - const: allwinner,sun7i-a20-pwm
       - items:
           - const: allwinner,sun50i-a64-pwm
           - const: allwinner,sun5i-a13-pwm
-- 
2.31.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v2 2/2] ARM: dts: sun8i: v3s: add pwm controller to v3s dts
  2021-05-13 20:35 [PATCH v2 0/2] ARM: dts: sun8i: v3s: add pwm controller to v3s dts Tobias Schramm
  2021-05-13 20:35 ` [PATCH v2 1/2] dt-bindings: pwm: allwinner: add v3s pwm compatible Tobias Schramm
@ 2021-05-13 20:35 ` Tobias Schramm
  2021-05-14  7:03   ` Andre Przywara
  2021-05-18 14:41 ` [PATCH v2 0/2] " Maxime Ripard
  2 siblings, 1 reply; 7+ messages in thread
From: Tobias Schramm @ 2021-05-13 20:35 UTC (permalink / raw)
  To: Jernej Škrabec, devicetree
  Cc: Rob Herring, Maxime Ripard, Chen-Yu Tsai, linux-arm-kernel,
	linux-sunxi, linux-kernel, Tobias Schramm

The Allwinner V3s and V3 SoCs feature a pwm controller identical to the
one used in the Allwinner A20.
This commit adds it to the V3s dtsi.

Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>
---
 arch/arm/boot/dts/sun8i-v3s.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi
index eb4cb63fef13..456dee9de87f 100644
--- a/arch/arm/boot/dts/sun8i-v3s.dtsi
+++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
@@ -422,6 +422,15 @@ wdt0: watchdog@1c20ca0 {
 			clocks = <&osc24M>;
 		};
 
+		pwm: pwm@1c21400 {
+			compatible = "allwinner,sun8i-v3s-pwm",
+				     "allwinner,sun7i-a20-pwm";
+			reg = <0x01c21400 0xc>;
+			clocks = <&osc24M>;
+			#pwm-cells = <3>;
+			status = "disabled";
+		};
+
 		lradc: lradc@1c22800 {
 			compatible = "allwinner,sun4i-a10-lradc-keys";
 			reg = <0x01c22800 0x400>;
-- 
2.31.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: pwm: allwinner: add v3s pwm compatible
  2021-05-13 20:35 ` [PATCH v2 1/2] dt-bindings: pwm: allwinner: add v3s pwm compatible Tobias Schramm
@ 2021-05-14  7:02   ` Andre Przywara
  2021-05-18  1:15   ` Rob Herring
  1 sibling, 0 replies; 7+ messages in thread
From: Andre Przywara @ 2021-05-14  7:02 UTC (permalink / raw)
  To: Tobias Schramm
  Cc: Jernej Škrabec, devicetree, Rob Herring, Maxime Ripard,
	Chen-Yu Tsai, linux-arm-kernel, linux-sunxi, linux-kernel

On Thu, 13 May 2021 22:35:26 +0200
Tobias Schramm <t.schramm@manjaro.org> wrote:

> The Allwinner V3s pwm peripheral is compatible with the pwm peripheral
> inside the Allwinner A20.
> This patch adds a compatible string for it.
> 
> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>

Compared the A20 and V3s manuals, the register description on the
PWM peripherals look indeed identical.

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
>  .../devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml       | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
> index 7dcab2bf8128..04ff708fdc86 100644
> --- a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
> @@ -24,6 +24,9 @@ properties:
>        - items:
>            - const: allwinner,sun8i-a83t-pwm
>            - const: allwinner,sun8i-h3-pwm
> +      - items:
> +          - const: allwinner,sun8i-v3s-pwm
> +          - const: allwinner,sun7i-a20-pwm
>        - items:
>            - const: allwinner,sun50i-a64-pwm
>            - const: allwinner,sun5i-a13-pwm


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 2/2] ARM: dts: sun8i: v3s: add pwm controller to v3s dts
  2021-05-13 20:35 ` [PATCH v2 2/2] ARM: dts: sun8i: v3s: add pwm controller to v3s dts Tobias Schramm
@ 2021-05-14  7:03   ` Andre Przywara
  0 siblings, 0 replies; 7+ messages in thread
From: Andre Przywara @ 2021-05-14  7:03 UTC (permalink / raw)
  To: Tobias Schramm
  Cc: Jernej Škrabec, devicetree, Rob Herring, Maxime Ripard,
	Chen-Yu Tsai, linux-arm-kernel, linux-sunxi, linux-kernel

On Thu, 13 May 2021 22:35:27 +0200
Tobias Schramm <t.schramm@manjaro.org> wrote:

> The Allwinner V3s and V3 SoCs feature a pwm controller identical to the
> one used in the Allwinner A20.
> This commit adds it to the V3s dtsi.
> 
> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>

Address and size match the manual, and the register description look
identical between A20 and V3s.

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
>  arch/arm/boot/dts/sun8i-v3s.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi
> index eb4cb63fef13..456dee9de87f 100644
> --- a/arch/arm/boot/dts/sun8i-v3s.dtsi
> +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
> @@ -422,6 +422,15 @@ wdt0: watchdog@1c20ca0 {
>  			clocks = <&osc24M>;
>  		};
>  
> +		pwm: pwm@1c21400 {
> +			compatible = "allwinner,sun8i-v3s-pwm",
> +				     "allwinner,sun7i-a20-pwm";
> +			reg = <0x01c21400 0xc>;
> +			clocks = <&osc24M>;
> +			#pwm-cells = <3>;
> +			status = "disabled";
> +		};
> +
>  		lradc: lradc@1c22800 {
>  			compatible = "allwinner,sun4i-a10-lradc-keys";
>  			reg = <0x01c22800 0x400>;


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: pwm: allwinner: add v3s pwm compatible
  2021-05-13 20:35 ` [PATCH v2 1/2] dt-bindings: pwm: allwinner: add v3s pwm compatible Tobias Schramm
  2021-05-14  7:02   ` Andre Przywara
@ 2021-05-18  1:15   ` Rob Herring
  1 sibling, 0 replies; 7+ messages in thread
From: Rob Herring @ 2021-05-18  1:15 UTC (permalink / raw)
  To: Tobias Schramm
  Cc: linux-arm-kernel, Rob Herring, devicetree, Chen-Yu Tsai,
	linux-sunxi, linux-kernel, Maxime Ripard, Jernej Škrabec

On Thu, 13 May 2021 22:35:26 +0200, Tobias Schramm wrote:
> The Allwinner V3s pwm peripheral is compatible with the pwm peripheral
> inside the Allwinner A20.
> This patch adds a compatible string for it.
> 
> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>
> ---
>  .../devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml       | 3 +++
>  1 file changed, 3 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 0/2] ARM: dts: sun8i: v3s: add pwm controller to v3s dts
  2021-05-13 20:35 [PATCH v2 0/2] ARM: dts: sun8i: v3s: add pwm controller to v3s dts Tobias Schramm
  2021-05-13 20:35 ` [PATCH v2 1/2] dt-bindings: pwm: allwinner: add v3s pwm compatible Tobias Schramm
  2021-05-13 20:35 ` [PATCH v2 2/2] ARM: dts: sun8i: v3s: add pwm controller to v3s dts Tobias Schramm
@ 2021-05-18 14:41 ` Maxime Ripard
  2 siblings, 0 replies; 7+ messages in thread
From: Maxime Ripard @ 2021-05-18 14:41 UTC (permalink / raw)
  To: Tobias Schramm
  Cc: Jernej Škrabec, devicetree, Rob Herring, Chen-Yu Tsai,
	linux-arm-kernel, linux-sunxi, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

On Thu, May 13, 2021 at 10:35:25PM +0200, Tobias Schramm wrote:
> This patchset adds the pwm controller to the Allwinner V3s dts. The PWM
> controller is compatible with the one found in the Allwinner A20.
> 
> This is v2 of this patchset.

Applied both, thanks
Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-05-18 14:42 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-13 20:35 [PATCH v2 0/2] ARM: dts: sun8i: v3s: add pwm controller to v3s dts Tobias Schramm
2021-05-13 20:35 ` [PATCH v2 1/2] dt-bindings: pwm: allwinner: add v3s pwm compatible Tobias Schramm
2021-05-14  7:02   ` Andre Przywara
2021-05-18  1:15   ` Rob Herring
2021-05-13 20:35 ` [PATCH v2 2/2] ARM: dts: sun8i: v3s: add pwm controller to v3s dts Tobias Schramm
2021-05-14  7:03   ` Andre Przywara
2021-05-18 14:41 ` [PATCH v2 0/2] " Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).