archive mirror
 help / color / mirror / Atom feed
From: Maxime Ripard <>
To: Tobias Schramm <>
Cc: Chen-Yu Tsai <>,
	Jernej Skrabec <>,
	Michael Turquette <>,
	Stephen Boyd <>,,,,
Subject: Re: [PATCH] clk: sunxi-ng: v3s: fix incorrect postdivider on pll-audio
Date: Mon, 24 May 2021 13:57:47 +0200	[thread overview]
Message-ID: <20210524115747.2vv3kigu7wcrgpmj@gilmour> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 1482 bytes --]

On Thu, May 13, 2021 at 03:13:15PM +0200, Tobias Schramm wrote:
> Commit 46060be6d840 ("clk: sunxi-ng: v3s: use sigma-delta modulation for audio-pll")
> changed the audio pll on the Allwinner V3s and V3 SoCs to use
> sigma-delta modulation. In the process the declaration of fixed postdivider
> providing "pll-audio" was adjusted to provide the desired clock rates from
> the now sigma-delta modulated pll.
> However, while the divider used for calculations by the clock framework
> was adjusted the actual divider programmed into the hardware in
> sun8i_v3_v3s_ccu_init was left at "divide by four". This broke the
> "pll-audio" clock, now only providing quater the expected clock rate.
> It would in general be desirable to program the postdivider for
> "pll-audio" to four, such that a broader range of frequencies were
> available on the pll outputs. But the clock for the integrated codec
> "ac-dig" does not feature a mux that allows to select from all pll outputs
> as it is just a simple clock gate connected to "pll-audio". Thus we need
> to set the postdivider to one to be able to provide the 22.5792MHz and
> 24.576MHz rates required by the internal sun4i codec.
> This patches fixes the incorrect clock rate by forcing the postdivider to
> one in sun8i_v3_v3s_ccu_init.
> Fixes: 46060be6d840 ("clk: sunxi-ng: v3s: use sigma-delta modulation for audio-pll")
> Signed-off-by: Tobias Schramm <>

Applied, thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2021-05-24 11:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-13 13:13 [PATCH] clk: sunxi-ng: v3s: fix incorrect postdivider on pll-audio Tobias Schramm
2021-05-24 11:57 ` Maxime Ripard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210524115747.2vv3kigu7wcrgpmj@gilmour \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).