From: Samuel Holland <samuel@sholland.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Gregory CLEMENT <gregory.clement@bootlin.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 1/3] dt-bindings: i2c: mv64xxx: Document DMA properties
Date: Tue, 30 Aug 2022 08:10:01 -0500 [thread overview]
Message-ID: <7fd702e9-dedc-e5bf-fd54-f07d053b1870@sholland.org> (raw)
In-Reply-To: <1c9cb6c2-2030-257d-a50d-dada0ab4449e@linaro.org>
On 8/30/22 4:36 AM, Krzysztof Kozlowski wrote:
> On 30/08/2022 05:08, Samuel Holland wrote:
>> Allwinner's I2C offload engine includes bidirectional DMA support. Add
>> the properties for describing this in the devicetree. "dmas" is optional
>> because not all instances of the controller have their DRQs hooked up.
>> For example, R_I2C0 and R_I2C1 on V536 have no DRQ number assigned.
>>
>> Signed-off-by: Samuel Holland <samuel@sholland.org>
>
> Thank you for your patch. There is something to discuss/improve.
>
>> ---
>>
>> .../bindings/i2c/marvell,mv64xxx-i2c.yaml | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
>> index 0ec033e48830..63d665a4f9bb 100644
>> --- a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
>> +++ b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
>> @@ -66,6 +66,19 @@ properties:
>> resets:
>> maxItems: 1
>>
>> + dmas:
>> + items:
>> + - description: RX DMA Channel
>> + - description: TX DMA Channel
>> +
>> + dma-names:
>> + items:
>> + - const: rx
>> + - const: tx
>> +
>> +dependencies:
>> + dmas: [ dma-names ]
>
> Dependency is not needed. meta-schema has it.
The only dma-names dependencies I see in dtschema (meta-schemas/dma.yaml and
schemas/dma/dma.yaml) are in the other direction. Those are saying that
dma-names only makes sense if dmas is provided.
Here I am saying that the two DMA requests are optional, but only optional
"together". The node must either have no DMA properties or both DMA properties.
Regards,
Samuel
next prev parent reply other threads:[~2022-08-30 13:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 2:08 [PATCH 0/3] DMA binding for Allwinner V536/newer I2C Samuel Holland
2022-08-30 2:08 ` [PATCH 1/3] dt-bindings: i2c: mv64xxx: Document DMA properties Samuel Holland
2022-08-30 9:36 ` Krzysztof Kozlowski
2022-08-30 13:10 ` Samuel Holland [this message]
2022-08-30 13:23 ` Krzysztof Kozlowski
2022-09-07 20:02 ` Wolfram Sang
2022-08-30 2:08 ` [PATCH 2/3] arm64: dts: allwinner: a100: Add device node for DMA controller Samuel Holland
2022-09-06 21:09 ` Jernej Škrabec
2022-09-08 20:01 ` Jernej Škrabec
2022-08-30 2:08 ` [PATCH 3/3] arm64: dts: allwinner: a100: Add I2C DMA requests Samuel Holland
2022-09-06 21:11 ` Jernej Škrabec
2022-09-08 20:01 ` Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fd702e9-dedc-e5bf-fd54-f07d053b1870@sholland.org \
--to=samuel@sholland.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).