* DE2.0 YV12 playback issues after ea067aee45a8
@ 2021-08-27 13:12 Roman Stratiienko
2021-08-27 13:16 ` Roman Stratiienko
0 siblings, 1 reply; 6+ messages in thread
From: Roman Stratiienko @ 2021-08-27 13:12 UTC (permalink / raw)
To: Jernej Skrabec; +Cc: dri-devel, linux-sunxi
Hello Jernej,
During local testing I faced an issue where YV12 buffers are displayed
all in blue.
Issue can be fixed by reverting:
ea067aee45a8 ("drm/sun4i: de2/de3: Remove redundant CSC matrices")
Could you have a look please?
Best regards,
Roman Stratiienko
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: DE2.0 YV12 playback issues after ea067aee45a8
2021-08-27 13:12 DE2.0 YV12 playback issues after ea067aee45a8 Roman Stratiienko
@ 2021-08-27 13:16 ` Roman Stratiienko
2021-08-31 16:38 ` Jernej Škrabec
2021-08-31 16:52 ` Jernej Škrabec
0 siblings, 2 replies; 6+ messages in thread
From: Roman Stratiienko @ 2021-08-27 13:16 UTC (permalink / raw)
To: jernej.skrabec; +Cc: dri-devel, linux-sunxi
+CC: jernej.skrabec@gmail.com
пт, 27 авг. 2021 г. в 16:12, Roman Stratiienko <r.stratiienko@gmail.com>:
>
> Hello Jernej,
>
> During local testing I faced an issue where YV12 buffers are displayed
> all in blue.
>
> Issue can be fixed by reverting:
> ea067aee45a8 ("drm/sun4i: de2/de3: Remove redundant CSC matrices")
>
> Could you have a look please?
>
> Best regards,
> Roman Stratiienko
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Re: DE2.0 YV12 playback issues after ea067aee45a8
2021-08-27 13:16 ` Roman Stratiienko
@ 2021-08-31 16:38 ` Jernej Škrabec
2021-08-31 16:52 ` Jernej Škrabec
1 sibling, 0 replies; 6+ messages in thread
From: Jernej Škrabec @ 2021-08-31 16:38 UTC (permalink / raw)
To: Roman Stratiienko; +Cc: dri-devel, linux-sunxi
Hi Roman!
Dne petek, 27. avgust 2021 ob 15:16:03 CEST je Roman Stratiienko napisal(a):
> +CC: jernej.skrabec@gmail.com
>
> пт, 27 авг. 2021 г. в 16:12, Roman Stratiienko <r.stratiienko@gmail.com>:
> >
> > Hello Jernej,
> >
> > During local testing I faced an issue where YV12 buffers are displayed
> > all in blue.
> >
> > Issue can be fixed by reverting:
> > ea067aee45a8 ("drm/sun4i: de2/de3: Remove redundant CSC matrices")
> >
> > Could you have a look please?
Yes, but I need more info - which SoCs are you using? Different routes are
taken for DE3 and DE2. In theory, they should be the same...
Best regards,
Jernej
> >
> > Best regards,
> > Roman Stratiienko
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Re: DE2.0 YV12 playback issues after ea067aee45a8
2021-08-27 13:16 ` Roman Stratiienko
2021-08-31 16:38 ` Jernej Škrabec
@ 2021-08-31 16:52 ` Jernej Škrabec
2021-08-31 17:18 ` Roman Stratiienko
1 sibling, 1 reply; 6+ messages in thread
From: Jernej Škrabec @ 2021-08-31 16:52 UTC (permalink / raw)
To: Roman Stratiienko; +Cc: dri-devel, linux-sunxi
Hi!
Dne petek, 27. avgust 2021 ob 15:16:03 CEST je Roman Stratiienko napisal(a):
> +CC: jernej.skrabec@gmail.com
>
> пт, 27 авг. 2021 г. в 16:12, Roman Stratiienko <r.stratiienko@gmail.com>:
> >
> > Hello Jernej,
> >
> > During local testing I faced an issue where YV12 buffers are displayed
> > all in blue.
> >
> > Issue can be fixed by reverting:
> > ea067aee45a8 ("drm/sun4i: de2/de3: Remove redundant CSC matrices")
> >
> > Could you have a look please?
I believe I found the issue. Can you try replacing this line:
https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/sun4i/
sun8i_csc.h#L20
with:
#define SUN8I_CSC_COEFF(base, i) (base + 0x10 + 4 * (i))
Note that "i" is in parenthesis.
Best regards,
Jernej
> >
> > Best regards,
> > Roman Stratiienko
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Re: DE2.0 YV12 playback issues after ea067aee45a8
2021-08-31 16:52 ` Jernej Škrabec
@ 2021-08-31 17:18 ` Roman Stratiienko
2021-08-31 18:49 ` Jernej Škrabec
0 siblings, 1 reply; 6+ messages in thread
From: Roman Stratiienko @ 2021-08-31 17:18 UTC (permalink / raw)
To: Jernej Škrabec; +Cc: dri-devel, linux-sunxi
Hi Jernej,
вт, 31 авг. 2021 г. в 19:52, Jernej Škrabec <jernej.skrabec@gmail.com>:
>
> Hi!
>
> Dne petek, 27. avgust 2021 ob 15:16:03 CEST je Roman Stratiienko napisal(a):
> > +CC: jernej.skrabec@gmail.com
> >
> > пт, 27 авг. 2021 г. в 16:12, Roman Stratiienko <r.stratiienko@gmail.com>:
> > >
> > > Hello Jernej,
> > >
> > > During local testing I faced an issue where YV12 buffers are displayed
> > > all in blue.
> > >
> > > Issue can be fixed by reverting:
> > > ea067aee45a8 ("drm/sun4i: de2/de3: Remove redundant CSC matrices")
> > >
> > > Could you have a look please?
>
> I believe I found the issue. Can you try replacing this line:
> https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/sun4i/
> sun8i_csc.h#L20
>
> with:
> #define SUN8I_CSC_COEFF(base, i) (base + 0x10 + 4 * (i))
>
> Note that "i" is in parenthesis.
Thank you for your quick response.
Yeah, that's it. Adding parenthesis solves the issue.
>
> Best regards,
> Jernej
>
> > >
> > > Best regards,
> > > Roman Stratiienko
> >
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Re: Re: DE2.0 YV12 playback issues after ea067aee45a8
2021-08-31 17:18 ` Roman Stratiienko
@ 2021-08-31 18:49 ` Jernej Škrabec
0 siblings, 0 replies; 6+ messages in thread
From: Jernej Škrabec @ 2021-08-31 18:49 UTC (permalink / raw)
To: Roman Stratiienko; +Cc: dri-devel, linux-sunxi
Dne torek, 31. avgust 2021 ob 19:18:42 CEST je Roman Stratiienko napisal(a):
> Hi Jernej,
>
> вт, 31 авг. 2021 г. в 19:52, Jernej Škrabec <jernej.skrabec@gmail.com>:
> >
> > Hi!
> >
> > Dne petek, 27. avgust 2021 ob 15:16:03 CEST je Roman Stratiienko
napisal(a):
> > > +CC: jernej.skrabec@gmail.com
> > >
> > > пт, 27 авг. 2021 г. в 16:12, Roman Stratiienko
<r.stratiienko@gmail.com>:
> > > >
> > > > Hello Jernej,
> > > >
> > > > During local testing I faced an issue where YV12 buffers are displayed
> > > > all in blue.
> > > >
> > > > Issue can be fixed by reverting:
> > > > ea067aee45a8 ("drm/sun4i: de2/de3: Remove redundant CSC matrices")
> > > >
> > > > Could you have a look please?
> >
> > I believe I found the issue. Can you try replacing this line:
> > https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/sun4i/
> > sun8i_csc.h#L20
> >
> > with:
> > #define SUN8I_CSC_COEFF(base, i) (base + 0x10 + 4 * (i))
> >
> > Note that "i" is in parenthesis.
>
> Thank you for your quick response.
> Yeah, that's it. Adding parenthesis solves the issue.
Thanks for reporting & testing!
Best regards,
Jernej
>
> >
> > Best regards,
> > Jernej
> >
> > > >
> > > > Best regards,
> > > > Roman Stratiienko
> > >
> >
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-08-31 18:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-27 13:12 DE2.0 YV12 playback issues after ea067aee45a8 Roman Stratiienko
2021-08-27 13:16 ` Roman Stratiienko
2021-08-31 16:38 ` Jernej Škrabec
2021-08-31 16:52 ` Jernej Škrabec
2021-08-31 17:18 ` Roman Stratiienko
2021-08-31 18:49 ` Jernej Škrabec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).