linux-sunxi.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Saravana Kannan <saravanak@google.com>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>
Cc: linux-sunxi@lists.linux.dev,
	Android Kernel Team <kernel-team@android.com>
Subject: Re: Issue with fw_devlink=on on 5.14
Date: Wed, 15 Sep 2021 11:23:58 -0700	[thread overview]
Message-ID: <CAGETcx9_dy4qdmZ-+X+WLsezPKWfZzmRU8QmhKOu6FdZcysWDA@mail.gmail.com> (raw)
In-Reply-To: <5570111.f9yF5Hohu3@kista>

On Wed, Sep 15, 2021 at 11:07 AM Jernej Škrabec
<jernej.skrabec@gmail.com> wrote:
>
> Hi Saravana!
>
> I noticed that in kernel 5.14, at least on Allwinner H3, deinterlace driver
> doesn't load anymore if fw_devlink is set to on. If I set it to off, driver
> loads and works without problems. If I remove interconnects property in DT
> node and use driver hack instead, it also loads and work ok.
>
> For reference, I speak about this node:
> https://elixir.bootlin.com/linux/v5.14/source/arch/arm/boot/dts/sun8i-h3.dtsi#L153
>
> Do you have any clue why it doesn't work?

Kinda busy today and I'll take a close look later, but if you delete
"interconnect" but it works, then it seems like you have no driver for
your "mbus" interconnect? Is that expected?

If you have a driver, then make it use the proper driver model (probe
a platform device).

If you don't have a driver for it, I'm assuming you have
CONFIG_MODULES enabled. Otherwise, fw_devlink=on is smart enough to
know not to block on devices that'll never be probed.

If you do need CONFIG_MODULES enabled, then use
deferred_probe_timeout=xxx so that fw_devlink doesn't wait for more
modules to be loaded past xxx seconds.

Also I like to look up emails on lore, so when emailing me about
fw_devlink (or any Linux stuff in general I suppose), it'd be nice if
you can cc LKML.

Thanks,
Saravana

  reply	other threads:[~2021-09-15 18:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15 18:07 Issue with fw_devlink=on on 5.14 Jernej Škrabec
2021-09-15 18:23 ` Saravana Kannan [this message]
2021-09-15 18:36   ` Saravana Kannan
2021-09-15 18:59     ` Jernej Škrabec
2021-09-17  2:55       ` Saravana Kannan
2021-09-17  4:32         ` Jernej Škrabec
2021-09-17 15:48           ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGETcx9_dy4qdmZ-+X+WLsezPKWfZzmRU8QmhKOu6FdZcysWDA@mail.gmail.com \
    --to=saravanak@google.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=kernel-team@android.com \
    --cc=linux-sunxi@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).