Re: [PATCH 0/2] arm64: dts: allwinner: Add BananaPi M4 Berry - Chen-Yu Tsai

From: Chen-Yu Tsai <wens@csie.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	 Icenowy Zheng <uwu@icenowy.me>,
	devicetree@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 0/2] arm64: dts: allwinner: Add BananaPi M4 Berry
Date: Mon, 18 Dec 2023 13:47:33 +0800	[thread overview]
Message-ID: <CAGb2v67hmuHTQmGCWuop1xag7PJRd5+aTDJb8pHAhTh3V-Cy7w@mail.gmail.com> (raw)
In-Reply-To: <20231217232405.302-1-andre.przywara@arm.com>

On Mon, Dec 18, 2023 at 7:24 AM Andre Przywara <andre.przywara@arm.com> wrote:
>
> The BananaPi M4 Berry is a development board with the Allwinner H618
> SoC. It comes with 2GB DRAM and 8GB eMMC flash, with the usual suspects
> like HDMI, SD card, GPIO headers. There are four USB ports connected
> via an on-board hub chip, and a Gigabit Ethernet socket. Also there is
> a USB WiFi chip soldered on the board.
> More details: https://linux-sunxi.org/Sinovoip_Banana_Pi_M4_Berry
>
> I don't have this board, so this is a "call for testing".
> One thing to consider:
> - The USB WiFi chip has a CHIP_EN pin, which can turn the chip off.
>   It is pulled up by a resistor, so works out of the box, but is also
>   connected to a GPIO (PC2), so the chip can be disabled or reset via
>   this pin. Since this is a USB device, we don't have a DT node to
>   announce this pin. Any ideas how this should be handled? At the moment
>   I ignore it, but it could also be modelled as a USB VBUS regulator for
>   USB port 1, to which it is connected.

There was a talk on this topic at Plumbers:

https://lpc.events/event/17/contributions/1507/

So I'd say a proper solution is being worked on.

ChenYu

> When testing this, please have a look at:
> - Does the eMMC work in HS200 mode? The vendor DT described that as a
>   3.3V controlled eMMC only, but clearly the schematic uses 1.8V, which
>   allows faster transfer modes. "hdparm -t" should suffice for a quick
>   test.
> - Do USB full-speed (aka USB v1.1) peripherals like keyboard or mouse
>   work on the USB ports? I disabled the OHCI node, since the hub should
>   not need this, but it would be good to double check.
> - Similarly the USB WiFi chip probably doesn't need USB 1.1 modes, so
>   please check this still works.
>
> Apart from the missing audio and video support (which are due to missing
> bindings for the H616/H618 SoC), most of the peripherals are supported.
>
> Patch 1/2 adds the board compatible string to the bindings, patch 2/2
> adds the actual .dts file.
>
> Please have a look!
>
> Thanks,
> Andre
>
> Andre Przywara (2):
>   dt-bindings: arm: sunxi: document BananaPi M4 Berry board name
>   arm64: dts: allwinner: h618: add BananaPi M4 Berry board
>
>  .../devicetree/bindings/arm/sunxi.yaml        |   5 +
>  arch/arm64/boot/dts/allwinner/Makefile        |   1 +
>  .../sun50i-h618-bananapi-m4-berry.dts         | 229 ++++++++++++++++++
>  3 files changed, 235 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h618-bananapi-m4-berry.dts
>
> --
> 2.35.8
>