From: Simon Glass <sjg@chromium.org>
To: Tom Rini <trini@konsulko.com>
Cc: Icenowy Zheng <icenowy@aosc.io>,
Andre Przywara <andre.przywara@arm.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Samuel Holland <samuel@sholland.org>,
U-Boot Mailing List <u-boot@lists.denx.de>,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v2 1/4] mkimage: add a flag to describe whether -A is specified
Date: Sun, 27 Jun 2021 17:50:20 -0600 [thread overview]
Message-ID: <CAPnjgZ0is-urE775mkE2YJ3fyq_5MfMVbqmduKNq64S-eeNzoA@mail.gmail.com> (raw)
In-Reply-To: <20210627234258.GX9516@bill-the-cat>
Hi Tom,
On Sun, 27 Jun 2021 at 17:43, Tom Rini <trini@konsulko.com> wrote:
>
> On Mon, Jun 28, 2021 at 06:17:27AM +0800, Icenowy Zheng wrote:
> > 在 2021-06-27星期日的 13:32 -0600,Simon Glass写道:
> > > Hi Icenowy,
> > >
> > > On Sat, 26 Jun 2021 at 17:57, Icenowy Zheng <icenowy@aosc.io> wrote:
> > > >
> > > > 在 2021-06-26星期六的 12:31 -0600,Simon Glass写道:
> > > > > Hi Icenowy,
> > > > >
> > > > > On Sat, 19 Jun 2021 at 03:19, Icenowy Zheng <icenowy@aosc.io>
> > > > > wrote:
> > > > > >
> > > > > > The sunxi_egon type used to take no -A argument (because we
> > > > > > assume
> > > > > > sunxi
> > > > > > targets are all ARM). However, as Allwinner D1 appears as the
> > > > > > first
> > > > > > RISC-V sunxi target, we need to support -A; in addition, as
> > > > > > external
> > > > > > projects rely on U-Boot mkimage to generate sunxi eGON.BT0
> > > > > > header,
> > > > > > we
> > > > > > need to keep compatibility with command line without -A.
> > > > > >
> > > > > > As the default value of arch in mkimage is not proper
> > > > > > (IH_ARCH_PPC
> > > > > > instead of IH_ARCH_INVALID), to keep more compatibility, add an
> > > > > > Aflag
> > > > > > field to image parameters to describe whether an architecture
> > > > > > is
> > > > > > explicitly specified.
> > > > > >
> > > > > > Reviewed-by: Tom Rini <trini@konsulko.com>
> > > > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > > > > > ---
> > > > > > Changes in v2:
> > > > > > - Added Tom Rini's Review tag.
> > > > >
> > > > > This is not actually a change so should not appear in the log.
> > > > >
> > > > > Also note 'patman status' can be used to automatically collect
> > > > > these.
> > > > >
> > > > > >
> > > > > > tools/imagetool.h | 1 +
> > > > > > tools/mkimage.c | 1 +
> > > > > > 2 files changed, 2 insertions(+)
> > > > > >
> > > > > > diff --git a/tools/imagetool.h b/tools/imagetool.h
> > > > > > index e229a34ffc..5dc28312c2 100644
> > > > > > --- a/tools/imagetool.h
> > > > > > +++ b/tools/imagetool.h
> > > > > > @@ -51,6 +51,7 @@ struct image_tool_params {
> > > > > > int pflag;
> > > > > > int vflag;
> > > > > > int xflag;
> > > > > > + int Aflag;
> > > > >
> > > > > aflag
> > > >
> > > > I think a problem is that -a is a different flag than -A.
> > > >
> > > > -a is addr, -A is architecture.
> > >
> > > Yes OK, but the code style doesn't allow capital letters, as I
> > > understand it.
> > >
> > > How about addr_flag ?
> >
> > maybe we just call -a aflag, and -A arch_flag?
>
> Frankly I think Aflag is the most readable option here. They're all
> literally ${FLAG_USE}flag variables, yes? CamelCase isn't great, but
> there's times where the most readable thing isn't always what we use
> everywhere else.
I mean, sort of, but 'a' and 'A' are not that descriptive so you could
make the case that they should be named for the full flag
meaning/purpose.
Anyway, I see it has your review tag, so I'll leave it to you.
Regards,
Simon
next prev parent reply other threads:[~2021-06-27 23:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-19 9:18 [PATCH v2 0/4] mkimage: sunxi_egon: add riscv support Icenowy Zheng
2021-06-19 9:18 ` [PATCH v2 1/4] mkimage: add a flag to describe whether -A is specified Icenowy Zheng
2021-06-26 18:31 ` Simon Glass
2021-06-26 23:57 ` Icenowy Zheng
2021-06-27 19:32 ` Simon Glass
2021-06-27 22:17 ` Icenowy Zheng
2021-06-27 23:42 ` Tom Rini
2021-06-27 23:50 ` Simon Glass [this message]
2021-06-27 23:48 ` Simon Glass
2021-06-19 9:20 ` [PATCH v2 2/4] mkimage: sunxi_egon: refactor for multi-architecture support Icenowy Zheng
2021-06-20 22:39 ` Andre Przywara
2021-06-19 9:20 ` [PATCH v2 3/4] mkimage: sunxi_egon: add support for riscv Icenowy Zheng
2021-06-20 22:40 ` Andre Przywara
2021-06-19 9:21 ` [PATCH v2 4/4] sunxi: specify architecture when generating SPL boot image Icenowy Zheng
2021-06-20 22:40 ` Andre Przywara
2021-08-22 1:15 ` [PATCH v2 0/4] mkimage: sunxi_egon: add riscv support Samuel Holland
2022-04-05 22:41 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnjgZ0is-urE775mkE2YJ3fyq_5MfMVbqmduKNq64S-eeNzoA@mail.gmail.com \
--to=sjg@chromium.org \
--cc=andre.przywara@arm.com \
--cc=icenowy@aosc.io \
--cc=jagan@amarulasolutions.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=samuel@sholland.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).