From: Icenowy Zheng <icenowy@aosc.io>
To: Simon Glass <sjg@chromium.org>
Cc: Andre Przywara <andre.przywara@arm.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Samuel Holland <samuel@sholland.org>,
Tom Rini <trini@konsulko.com>,
U-Boot Mailing List <u-boot@lists.denx.de>,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v2 1/4] mkimage: add a flag to describe whether -A is specified
Date: Sun, 27 Jun 2021 07:57:00 +0800 [thread overview]
Message-ID: <b2563810990da9c9ace9cc73bf70e49c4bf6e556.camel@aosc.io> (raw)
In-Reply-To: <CAPnjgZ3-iAng7Y9d+cjZY95vOeKfJStbVbQWYiUZURhptxZrmQ@mail.gmail.com>
在 2021-06-26星期六的 12:31 -0600,Simon Glass写道:
> Hi Icenowy,
>
> On Sat, 19 Jun 2021 at 03:19, Icenowy Zheng <icenowy@aosc.io> wrote:
> >
> > The sunxi_egon type used to take no -A argument (because we assume
> > sunxi
> > targets are all ARM). However, as Allwinner D1 appears as the first
> > RISC-V sunxi target, we need to support -A; in addition, as
> > external
> > projects rely on U-Boot mkimage to generate sunxi eGON.BT0 header,
> > we
> > need to keep compatibility with command line without -A.
> >
> > As the default value of arch in mkimage is not proper (IH_ARCH_PPC
> > instead of IH_ARCH_INVALID), to keep more compatibility, add an
> > Aflag
> > field to image parameters to describe whether an architecture is
> > explicitly specified.
> >
> > Reviewed-by: Tom Rini <trini@konsulko.com>
> > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > ---
> > Changes in v2:
> > - Added Tom Rini's Review tag.
>
> This is not actually a change so should not appear in the log.
>
> Also note 'patman status' can be used to automatically collect these.
>
> >
> > tools/imagetool.h | 1 +
> > tools/mkimage.c | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/tools/imagetool.h b/tools/imagetool.h
> > index e229a34ffc..5dc28312c2 100644
> > --- a/tools/imagetool.h
> > +++ b/tools/imagetool.h
> > @@ -51,6 +51,7 @@ struct image_tool_params {
> > int pflag;
> > int vflag;
> > int xflag;
> > + int Aflag;
>
> aflag
I think a problem is that -a is a different flag than -A.
-a is addr, -A is architecture.
>
> > int skipcpy;
> > int os;
> > int arch;
> > diff --git a/tools/mkimage.c b/tools/mkimage.c
> > index cc7b242faf..54d8e3835a 100644
> > --- a/tools/mkimage.c
> > +++ b/tools/mkimage.c
> > @@ -168,6 +168,7 @@ static void process_args(int argc, char **argv)
> > show_valid_options(IH_ARCH);
> > usage("Invalid architecture");
> > }
> > + params.Aflag = 1;
> > break;
> > case 'b':
> > if (add_content(IH_TYPE_FLATDT, optarg)) {
> > --
> > 2.30.2
>
> Regards,
> Simon
next prev parent reply other threads:[~2021-06-27 0:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-19 9:18 [PATCH v2 0/4] mkimage: sunxi_egon: add riscv support Icenowy Zheng
2021-06-19 9:18 ` [PATCH v2 1/4] mkimage: add a flag to describe whether -A is specified Icenowy Zheng
2021-06-26 18:31 ` Simon Glass
2021-06-26 23:57 ` Icenowy Zheng [this message]
2021-06-27 19:32 ` Simon Glass
2021-06-27 22:17 ` Icenowy Zheng
2021-06-27 23:42 ` Tom Rini
2021-06-27 23:50 ` Simon Glass
2021-06-27 23:48 ` Simon Glass
2021-06-19 9:20 ` [PATCH v2 2/4] mkimage: sunxi_egon: refactor for multi-architecture support Icenowy Zheng
2021-06-20 22:39 ` Andre Przywara
2021-06-19 9:20 ` [PATCH v2 3/4] mkimage: sunxi_egon: add support for riscv Icenowy Zheng
2021-06-20 22:40 ` Andre Przywara
2021-06-19 9:21 ` [PATCH v2 4/4] sunxi: specify architecture when generating SPL boot image Icenowy Zheng
2021-06-20 22:40 ` Andre Przywara
2021-08-22 1:15 ` [PATCH v2 0/4] mkimage: sunxi_egon: add riscv support Samuel Holland
2022-04-05 22:41 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2563810990da9c9ace9cc73bf70e49c4bf6e556.camel@aosc.io \
--to=icenowy@aosc.io \
--cc=andre.przywara@arm.com \
--cc=jagan@amarulasolutions.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=samuel@sholland.org \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).