* [PATCH linux-next] memory:tegra210-emc-core: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
@ 2021-08-25 6:37 CGEL
2021-08-25 9:45 ` Krzysztof Kozlowski
2021-09-15 7:37 ` Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: CGEL @ 2021-08-25 6:37 UTC (permalink / raw)
To: Krzysztof Kozlowski, Thierry Reding, Jonathan Hunter,
Dmitry Osipenko, Dan Carpenter, linux-kernel, linux-tegra
Cc: Jing Yangyang, Zeal Robot
From: Jing Yangyang <jing.yangyang@zte.com.cn>
Fix the following coccicheck warning:
./drivers/memory/tegra/tegra210-emc-core.c:1665:0-23:WARNING
tegra210_emc_debug_min_rate_fops should be defined
with DEFINE_DEBUGFS_ATTRIBUTE
./drivers/memory/tegra/tegra210-emc-core.c:1726:0-23:WARNING
tegra210_emc_debug_temperature_fops should be defined
with DEFINE_DEBUGFS_ATTRIBUTE
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jing Yangyang <jing.yangyang@zte.com.cn>
---
drivers/memory/tegra/tegra210-emc-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/memory/tegra/tegra210-emc-core.c b/drivers/memory/tegra/tegra210-emc-core.c
index 06c0f17..3b8284c 100644
--- a/drivers/memory/tegra/tegra210-emc-core.c
+++ b/drivers/memory/tegra/tegra210-emc-core.c
@@ -1692,7 +1692,7 @@ static int tegra210_emc_debug_max_rate_set(void *data, u64 rate)
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(tegra210_emc_debug_max_rate_fops,
+DEFINE_DEBUGFS_ATTRIBUTE(tegra210_emc_debug_max_rate_fops,
tegra210_emc_debug_max_rate_get,
tegra210_emc_debug_max_rate_set, "%llu\n");
@@ -1723,7 +1723,7 @@ static int tegra210_emc_debug_temperature_set(void *data, u64 temperature)
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(tegra210_emc_debug_temperature_fops,
+DEFINE_DEBUGFS_ATTRIBUTE(tegra210_emc_debug_temperature_fops,
tegra210_emc_debug_temperature_get,
tegra210_emc_debug_temperature_set, "%llu\n");
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH linux-next] memory:tegra210-emc-core: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
2021-08-25 6:37 [PATCH linux-next] memory:tegra210-emc-core: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE CGEL
@ 2021-08-25 9:45 ` Krzysztof Kozlowski
2021-08-25 10:01 ` Dan Carpenter
2021-09-15 7:37 ` Krzysztof Kozlowski
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2021-08-25 9:45 UTC (permalink / raw)
To: CGEL, Thierry Reding, Jonathan Hunter, Dmitry Osipenko,
Dan Carpenter, linux-kernel, linux-tegra
Cc: Jing Yangyang, Zeal Robot
On 25/08/2021 08:37, CGEL wrote:
> From: Jing Yangyang <jing.yangyang@zte.com.cn>
>
> Fix the following coccicheck warning:
> ./drivers/memory/tegra/tegra210-emc-core.c:1665:0-23:WARNING
> tegra210_emc_debug_min_rate_fops should be defined
> with DEFINE_DEBUGFS_ATTRIBUTE
> ./drivers/memory/tegra/tegra210-emc-core.c:1726:0-23:WARNING
> tegra210_emc_debug_temperature_fops should be defined
> with DEFINE_DEBUGFS_ATTRIBUTE
Thanks for the patch.
One error message is enough. They are the same.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
Where is the report? We work here in a public, so if there is a report I
assume we can reach it? In case the report does not exist, anyone can
run checkpatch, coccinelle, smatch and sparse, so how does this differs
from me running checkpatch?
> Signed-off-by: Jing Yangyang <jing.yangyang@zte.com.cn>
> ---
> drivers/memory/tegra/tegra210-emc-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/memory/tegra/tegra210-emc-core.c b/drivers/memory/tegra/tegra210-emc-core.c
> index 06c0f17..3b8284c 100644
> --- a/drivers/memory/tegra/tegra210-emc-core.c
> +++ b/drivers/memory/tegra/tegra210-emc-core.c
> @@ -1692,7 +1692,7 @@ static int tegra210_emc_debug_max_rate_set(void *data, u64 rate)
> return 0;
> }
>
> -DEFINE_SIMPLE_ATTRIBUTE(tegra210_emc_debug_max_rate_fops,
> +DEFINE_DEBUGFS_ATTRIBUTE(tegra210_emc_debug_max_rate_fops,
> tegra210_emc_debug_max_rate_get,
> tegra210_emc_debug_max_rate_set, "%llu\n");
>
> @@ -1723,7 +1723,7 @@ static int tegra210_emc_debug_temperature_set(void *data, u64 temperature)
> return 0;
> }
>
> -DEFINE_SIMPLE_ATTRIBUTE(tegra210_emc_debug_temperature_fops,
> +DEFINE_DEBUGFS_ATTRIBUTE(tegra210_emc_debug_temperature_fops,
> tegra210_emc_debug_temperature_get,
> tegra210_emc_debug_temperature_set, "%llu\n");
>
>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH linux-next] memory:tegra210-emc-core: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
2021-08-25 9:45 ` Krzysztof Kozlowski
@ 2021-08-25 10:01 ` Dan Carpenter
2021-08-25 10:23 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2021-08-25 10:01 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: CGEL, Thierry Reding, Jonathan Hunter, Dmitry Osipenko,
linux-kernel, linux-tegra, Jing Yangyang, Zeal Robot
On Wed, Aug 25, 2021 at 11:45:58AM +0200, Krzysztof Kozlowski wrote:
> On 25/08/2021 08:37, CGEL wrote:
> > From: Jing Yangyang <jing.yangyang@zte.com.cn>
> >
> > Fix the following coccicheck warning:
> > ./drivers/memory/tegra/tegra210-emc-core.c:1665:0-23:WARNING
> > tegra210_emc_debug_min_rate_fops should be defined
> > with DEFINE_DEBUGFS_ATTRIBUTE
> > ./drivers/memory/tegra/tegra210-emc-core.c:1726:0-23:WARNING
> > tegra210_emc_debug_temperature_fops should be defined
> > with DEFINE_DEBUGFS_ATTRIBUTE
>
> Thanks for the patch.
>
> One error message is enough. They are the same.
>
> >
> > Reported-by: Zeal Robot <zealci@zte.com.cn>
>
> Where is the report? We work here in a public, so if there is a report I
> assume we can reach it? In case the report does not exist, anyone can
> run checkpatch, coccinelle, smatch and sparse, so how does this differs
> from me running checkpatch?
Someone asked for these tags when it was Huawei sending patches from
the Hulk Robot so no everyone adds them and Hulk Robot is the #1 bug
reporter. Hulk Robot just crossed the 2000 tag mark recently.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH linux-next] memory:tegra210-emc-core: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
2021-08-25 10:01 ` Dan Carpenter
@ 2021-08-25 10:23 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2021-08-25 10:23 UTC (permalink / raw)
To: Dan Carpenter
Cc: CGEL, Thierry Reding, Jonathan Hunter, Dmitry Osipenko,
linux-kernel, linux-tegra, Jing Yangyang, Zeal Robot
On 25/08/2021 12:01, Dan Carpenter wrote:
> On Wed, Aug 25, 2021 at 11:45:58AM +0200, Krzysztof Kozlowski wrote:
>> On 25/08/2021 08:37, CGEL wrote:
>>> From: Jing Yangyang <jing.yangyang@zte.com.cn>
>>>
>>> Fix the following coccicheck warning:
>>> ./drivers/memory/tegra/tegra210-emc-core.c:1665:0-23:WARNING
>>> tegra210_emc_debug_min_rate_fops should be defined
>>> with DEFINE_DEBUGFS_ATTRIBUTE
>>> ./drivers/memory/tegra/tegra210-emc-core.c:1726:0-23:WARNING
>>> tegra210_emc_debug_temperature_fops should be defined
>>> with DEFINE_DEBUGFS_ATTRIBUTE
>>
>> Thanks for the patch.
>>
>> One error message is enough. They are the same.
>>
>>>
>>> Reported-by: Zeal Robot <zealci@zte.com.cn>
>>
>> Where is the report? We work here in a public, so if there is a report I
>> assume we can reach it? In case the report does not exist, anyone can
>> run checkpatch, coccinelle, smatch and sparse, so how does this differs
>> from me running checkpatch?
>
> Someone asked for these tags when it was Huawei sending patches from
> the Hulk Robot so no everyone adds them and Hulk Robot is the #1 bug
> reporter. Hulk Robot just crossed the 2000 tag mark recently.
Yes, I know, my questions where rather rhetorical. :) Hulk Robot reports
are ridiculous, in my opinion.
The tool (checkpatch) used to detect warning is public, so from
community perspective this does not differ from John Smith sending a fix
for a checkpatch issue.
However I do not expect tags like:
From: John Smith
...
Reported-by: John Smith
Signed-off-by: John Smith
How does it look? Neither I expect some unknown, hidden, secret reports
like:
Reported-by: foo bar
Signed-off-by: John Smith
Simply the credit of running the tool (e.g. checkpatch) is already in
the patch authorship. The Reported-by is for crediting additional work
related to the report.
No report, no credit. Otherwise the value of Reported-by cease to exist...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH linux-next] memory:tegra210-emc-core: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
2021-08-25 6:37 [PATCH linux-next] memory:tegra210-emc-core: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE CGEL
2021-08-25 9:45 ` Krzysztof Kozlowski
@ 2021-09-15 7:37 ` Krzysztof Kozlowski
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-15 7:37 UTC (permalink / raw)
To: CGEL, Thierry Reding, linux-tegra, linux-kernel, Dmitry Osipenko,
Jonathan Hunter, Dan Carpenter
Cc: Krzysztof Kozlowski, Jing Yangyang, Zeal Robot
On Tue, 24 Aug 2021 23:37:39 -0700, CGEL wrote:
> From: Jing Yangyang <jing.yangyang@zte.com.cn>
>
> Fix the following coccicheck warning:
> ./drivers/memory/tegra/tegra210-emc-core.c:1665:0-23:WARNING
> tegra210_emc_debug_min_rate_fops should be defined
> with DEFINE_DEBUGFS_ATTRIBUTE
> ./drivers/memory/tegra/tegra210-emc-core.c:1726:0-23:WARNING
> tegra210_emc_debug_temperature_fops should be defined
> with DEFINE_DEBUGFS_ATTRIBUTE
>
> [...]
Applied, thanks!
[1/1] memory:tegra210-emc-core: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
commit: 6fc5f1adf5a11422d748aa71e43e7c979208b8f2
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-15 7:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-25 6:37 [PATCH linux-next] memory:tegra210-emc-core: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE CGEL
2021-08-25 9:45 ` Krzysztof Kozlowski
2021-08-25 10:01 ` Dan Carpenter
2021-08-25 10:23 ` Krzysztof Kozlowski
2021-09-15 7:37 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).