* [PATCH] arm64: tegra: correct Tegra132 I2C alias
@ 2024-04-01 14:08 Krzysztof Kozlowski
2024-04-02 19:20 ` Jon Hunter
2024-04-26 15:33 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-01 14:08 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Jonathan Hunter, devicetree, linux-tegra, linux-kernel
Cc: Krzysztof Kozlowski, stable
There is no such device as "as3722@40", because its name is "pmic". Use
phandles for aliases to fix relying on full node path. This corrects
aliases for RTC devices and also fixes dtc W=1 warning:
tegra132-norrin.dts:12.3-36: Warning (alias_paths): /aliases:rtc0: aliases property is not a valid node (/i2c@7000d000/as3722@40)
Fixes: 0f279ebdf3ce ("arm64: tegra: Add NVIDIA Tegra132 Norrin support")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 4 ++--
arch/arm64/boot/dts/nvidia/tegra132.dtsi | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
index 14d58859bb55..683ac124523b 100644
--- a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
@@ -9,8 +9,8 @@ / {
compatible = "nvidia,norrin", "nvidia,tegra132", "nvidia,tegra124";
aliases {
- rtc0 = "/i2c@7000d000/as3722@40";
- rtc1 = "/rtc@7000e000";
+ rtc0 = &as3722;
+ rtc1 = &tegra_rtc;
serial0 = &uarta;
};
diff --git a/arch/arm64/boot/dts/nvidia/tegra132.dtsi b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
index 7e24a212c7e4..5bcccfef3f7f 100644
--- a/arch/arm64/boot/dts/nvidia/tegra132.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
@@ -572,7 +572,7 @@ spi@7000de00 {
status = "disabled";
};
- rtc@7000e000 {
+ tegra_rtc: rtc@7000e000 {
compatible = "nvidia,tegra124-rtc", "nvidia,tegra20-rtc";
reg = <0x0 0x7000e000 0x0 0x100>;
interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: tegra: correct Tegra132 I2C alias
2024-04-01 14:08 [PATCH] arm64: tegra: correct Tegra132 I2C alias Krzysztof Kozlowski
@ 2024-04-02 19:20 ` Jon Hunter
2024-04-26 15:33 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Jon Hunter @ 2024-04-02 19:20 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Thierry Reding, devicetree, linux-tegra,
linux-kernel
Cc: stable
On 01/04/2024 15:08, Krzysztof Kozlowski wrote:
> There is no such device as "as3722@40", because its name is "pmic". Use
> phandles for aliases to fix relying on full node path. This corrects
> aliases for RTC devices and also fixes dtc W=1 warning:
>
> tegra132-norrin.dts:12.3-36: Warning (alias_paths): /aliases:rtc0: aliases property is not a valid node (/i2c@7000d000/as3722@40)
>
> Fixes: 0f279ebdf3ce ("arm64: tegra: Add NVIDIA Tegra132 Norrin support")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 4 ++--
> arch/arm64/boot/dts/nvidia/tegra132.dtsi | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
> index 14d58859bb55..683ac124523b 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
> @@ -9,8 +9,8 @@ / {
> compatible = "nvidia,norrin", "nvidia,tegra132", "nvidia,tegra124";
>
> aliases {
> - rtc0 = "/i2c@7000d000/as3722@40";
> - rtc1 = "/rtc@7000e000";
> + rtc0 = &as3722;
> + rtc1 = &tegra_rtc;
> serial0 = &uarta;
> };
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra132.dtsi b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
> index 7e24a212c7e4..5bcccfef3f7f 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra132.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
> @@ -572,7 +572,7 @@ spi@7000de00 {
> status = "disabled";
> };
>
> - rtc@7000e000 {
> + tegra_rtc: rtc@7000e000 {
> compatible = "nvidia,tegra124-rtc", "nvidia,tegra20-rtc";
> reg = <0x0 0x7000e000 0x0 0x100>;
> interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Thanks!
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: tegra: correct Tegra132 I2C alias
2024-04-01 14:08 [PATCH] arm64: tegra: correct Tegra132 I2C alias Krzysztof Kozlowski
2024-04-02 19:20 ` Jon Hunter
@ 2024-04-26 15:33 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2024-04-26 15:33 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Jonathan Hunter, devicetree, linux-tegra, linux-kernel,
Krzysztof Kozlowski
Cc: stable
From: Thierry Reding <treding@nvidia.com>
On Mon, 01 Apr 2024 16:08:54 +0200, Krzysztof Kozlowski wrote:
> There is no such device as "as3722@40", because its name is "pmic". Use
> phandles for aliases to fix relying on full node path. This corrects
> aliases for RTC devices and also fixes dtc W=1 warning:
>
> tegra132-norrin.dts:12.3-36: Warning (alias_paths): /aliases:rtc0: aliases property is not a valid node (/i2c@7000d000/as3722@40)
>
>
> [...]
Applied, thanks!
[1/1] arm64: tegra: correct Tegra132 I2C alias
(no commit info)
Best regards,
--
Thierry Reding <treding@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-26 15:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-01 14:08 [PATCH] arm64: tegra: correct Tegra132 I2C alias Krzysztof Kozlowski
2024-04-02 19:20 ` Jon Hunter
2024-04-26 15:33 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).