[PATCH v2 0/8] Nexus 7 and A500 device-tree improvements

[PATCH v2 0/8] Nexus 7 and A500 device-tree improvements

[Dmitry Osipenko]

This series improves device-trees of Nexus 7 and A500 devices by
correcting old and adding new DT properties.

Changelog:

v2: - Added these two additional patches:

        ARM: tegra: nexus7: Set video decoder clock rate to 408MHz
        ARM: tegra: nexus7: Use panel-lvds as the only panel compatible

Dmitry Osipenko (8):
  ARM: tegra: acer-a500: Correct thermal zone names
  ARM: tegra: acer-a500: Add power-supply to lvds-encoder node
  ARM: tegra: nexus7: Correct thermal zone names
  ARM: tegra: nexus7: Improve CPU passive-cooling threshold
  ARM: tegra: nexus7: Add power-supply to lvds-encoder node
  ARM: tegra: nexus7: Rename gpio-hog nodes
  ARM: tegra: nexus7: Set video decoder clock rate to 408MHz
  ARM: tegra: nexus7: Use panel-lvds as the only panel compatible

 .../boot/dts/tegra20-acer-a500-picasso.dts    |  5 ++--
 .../tegra30-asus-nexus7-grouper-common.dtsi   | 30 +++++++++++++------
 ...egra30-asus-nexus7-grouper-maxim-pmic.dtsi |  2 +-
 .../boot/dts/tegra30-asus-nexus7-tilapia.dtsi |  2 +-
 4 files changed, 26 insertions(+), 13 deletions(-)

-- 
2.27.0

[PATCH v2 1/8] ARM: tegra: acer-a500: Correct thermal zone names

[Dmitry Osipenko]

Rename thermal zones in order fix dt_binding_check warning telling that
names do not match the expected pattern.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/arm/boot/dts/tegra20-acer-a500-picasso.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/tegra20-acer-a500-picasso.dts b/arch/arm/boot/dts/tegra20-acer-a500-picasso.dts
index 575898e8c785..8e3e79b734b0 100644
--- a/arch/arm/boot/dts/tegra20-acer-a500-picasso.dts
+++ b/arch/arm/boot/dts/tegra20-acer-a500-picasso.dts
@@ -1063,14 +1063,14 @@ sound {
 	};
 
 	thermal-zones {
-		nct1008-local {
+		skin-thermal {
 			polling-delay-passive = <1000>; /* milliseconds */
 			polling-delay = <0>; /* milliseconds */
 
 			thermal-sensors = <&nct1008 0>;
 		};
 
-		nct1008-remote {
+		cpu-thermal {
 			polling-delay-passive = <1000>; /* milliseconds */
 			polling-delay = <5000>; /* milliseconds */
 
-- 
2.27.0

[PATCH v2 2/8] ARM: tegra: acer-a500: Add power-supply to lvds-encoder node

[Dmitry Osipenko]

The lvds-encoder binding now supports power-supply property, let's specify
it in the device-tree for completeness.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/arm/boot/dts/tegra20-acer-a500-picasso.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/tegra20-acer-a500-picasso.dts b/arch/arm/boot/dts/tegra20-acer-a500-picasso.dts
index 8e3e79b734b0..09329cb4993a 100644
--- a/arch/arm/boot/dts/tegra20-acer-a500-picasso.dts
+++ b/arch/arm/boot/dts/tegra20-acer-a500-picasso.dts
@@ -950,6 +950,7 @@ lvds-encoder {
 		compatible = "ti,sn75lvds83", "lvds-encoder";
 
 		powerdown-gpios = <&gpio TEGRA_GPIO(B, 2) GPIO_ACTIVE_LOW>;
+		power-supply = <&vdd_3v3_sys>;
 
 		ports {
 			#address-cells = <1>;
-- 
2.27.0

[PATCH v2 3/8] ARM: tegra: nexus7: Correct thermal zone names

[Dmitry Osipenko]

Rename thermal zones in order fix dt_binding_check warning telling that
names do not match the expected pattern.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
index 2b405872ad2d..543c52cd8260 100644
--- a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
+++ b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
@@ -1267,14 +1267,14 @@ sound {
 	};
 
 	thermal-zones {
-		nct72-local {
+		skin-thermal {
 			polling-delay-passive = <1000>; /* milliseconds */
 			polling-delay = <0>; /* milliseconds */
 
 			thermal-sensors = <&nct72 0>;
 		};
 
-		nct72-remote {
+		cpu-thermal {
 			polling-delay-passive = <1000>; /* milliseconds */
 			polling-delay = <5000>; /* milliseconds */
 
-- 
2.27.0

[PATCH v2 4/8] ARM: tegra: nexus7: Improve CPU passive-cooling threshold

[Dmitry Osipenko]

The current CPU thermal limit is a bit inappropriate for Nexus 7 once
device is getting used on a daily bases. For example, currently it's may
be impossible to watch a hardware accelerated 720p video without hitting
a severe CPU throttling, which ruins user experience. This patch improves
the thermal throttling thresholds.

In my experience setting CPU thermal threshold to 57C provides the most
reasonable result, where device is a bit warm under constant load and
not getting overly hot, in the same time performance is okay. Let's bump
the passive-cooling threshold from 50C to 57C and also lower the thermal
hysteresis to 0.2C in order to make throttling more reactive.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
index 543c52cd8260..adc708bbfb62 100644
--- a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
+++ b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
@@ -1282,9 +1282,9 @@ cpu-thermal {
 
 			trips {
 				trip0: cpu-alert0 {
-					/* start throttling at 50C */
-					temperature = <50000>;
-					hysteresis = <3000>;
+					/* throttle at 57C until temperature drops to 56.8C */
+					temperature = <57000>;
+					hysteresis = <200>;
 					type = "passive";
 				};
 
-- 
2.27.0

[PATCH v2 5/8] ARM: tegra: nexus7: Add power-supply to lvds-encoder node

[Dmitry Osipenko]

The lvds-encoder binding now supports power-supply property, let's specify
it in the device-tree for completeness.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
index adc708bbfb62..c2b1229f0d83 100644
--- a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
+++ b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
@@ -1172,6 +1172,7 @@ lvds-encoder {
 		compatible = "ti,sn75lvds83", "lvds-encoder";
 
 		powerdown-gpios = <&gpio TEGRA_GPIO(N, 6) GPIO_ACTIVE_LOW>;
+		power-supply = <&vdd_3v3_sys>;
 
 		ports {
 			#address-cells = <1>;
-- 
2.27.0

[PATCH v2 6/8] ARM: tegra: nexus7: Rename gpio-hog nodes

[Dmitry Osipenko]

Devicetree schema now requires gpio-hog nodes to have a certain naming
pattern, like a -hog suffix. This patch fixes dtbs_check warnings about
the names.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi     | 4 ++--
 arch/arm/boot/dts/tegra30-asus-nexus7-grouper-maxim-pmic.dtsi | 2 +-
 arch/arm/boot/dts/tegra30-asus-nexus7-tilapia.dtsi            | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
index c2b1229f0d83..7fe584d69f5d 100644
--- a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
+++ b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
@@ -91,7 +91,7 @@ dc@54240000 {
 	};
 
 	gpio@6000d000 {
-		init-mode {
+		init-mode-hog {
 			gpio-hog;
 			gpios =	<TEGRA_GPIO(DD, 7) GPIO_ACTIVE_HIGH>,
 				<TEGRA_GPIO(CC, 6) GPIO_ACTIVE_HIGH>,
@@ -99,7 +99,7 @@ init-mode {
 			output-low;
 		};
 
-		init-low-power-mode {
+		init-low-power-mode-hog {
 			gpio-hog;
 			gpios = <TEGRA_GPIO(I, 6) GPIO_ACTIVE_HIGH>;
 			input;
diff --git a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-maxim-pmic.dtsi b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-maxim-pmic.dtsi
index b25b3fa90ac6..17b6682ffce8 100644
--- a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-maxim-pmic.dtsi
+++ b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-maxim-pmic.dtsi
@@ -29,7 +29,7 @@ gpio4 {
 				};
 			};
 
-			cpu-pwr-req {
+			cpu-pwr-req-hog {
 				gpio-hog;
 				gpios = <6 GPIO_ACTIVE_HIGH>;
 				input;
diff --git a/arch/arm/boot/dts/tegra30-asus-nexus7-tilapia.dtsi b/arch/arm/boot/dts/tegra30-asus-nexus7-tilapia.dtsi
index e3da89f1941a..a681ad51fddd 100644
--- a/arch/arm/boot/dts/tegra30-asus-nexus7-tilapia.dtsi
+++ b/arch/arm/boot/dts/tegra30-asus-nexus7-tilapia.dtsi
@@ -23,7 +23,7 @@ panel-timing {
 	};
 
 	gpio@6000d000 {
-		init-mode-3g {
+		init-mode-3g-hog {
 			gpio-hog;
 			gpios =	<TEGRA_GPIO(D, 2) GPIO_ACTIVE_HIGH>,
 				<TEGRA_GPIO(C, 6) GPIO_ACTIVE_HIGH>,
-- 
2.27.0

[PATCH v2 7/8] ARM: tegra: nexus7: Set video decoder clock rate to 408MHz

[Dmitry Osipenko]

The default 600MHz is technically unsupported on Nexus 7. Assign VDE clock
to 408MHz, which is supported by all hardware versions.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
index 7fe584d69f5d..fb5b33f1bcd8 100644
--- a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
+++ b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
@@ -107,6 +107,9 @@ init-low-power-mode-hog {
 	};
 
 	vde@6001a000 {
+		assigned-clocks = <&tegra_car TEGRA30_CLK_VDE>;
+		assigned-clock-parents = <&tegra_car TEGRA30_CLK_PLL_P>;
+		assigned-clock-rates = <408000000>;
 		core-supply = <&vdd_core>;
 	};
 
-- 
2.27.0

[PATCH v2 8/8] ARM: tegra: nexus7: Use panel-lvds as the only panel compatible

[Dmitry Osipenko]

Depending on a driver probe order, panel-simple driver may probe first,
which results in this error:

  panel-simple display-panel: Reject override mode: panel has a fixed mode

We don't want to use panel-simple anyways because customized timings are
preferred for Nexus 7, hence remove the panel-simple compatibles from the
panel node.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 .../boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
index fb5b33f1bcd8..df33f3db8a38 100644
--- a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
+++ b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
@@ -1103,8 +1103,16 @@ cpu@3 {
 	};
 
 	display-panel {
-		compatible = "hydis,hv070wx2-1e0", "chunghwa,claa070wp03xg",
-			     "panel-lvds";
+		/*
+		 * Nexus 7 supports two compatible panel models:
+		 *
+		 *  1. hydis,hv070wx2-1e0
+		 *  2. chunghwa,claa070wp03xg
+		 *
+		 * We want to use timing which is optimized for Nexus 7,
+		 * hence we need to customize the timing.
+		 */
+		compatible = "panel-lvds";
 
 		power-supply = <&vdd_pnl>;
 		backlight = <&backlight>;
-- 
2.27.0

Re: [PATCH v2 7/8] ARM: tegra: nexus7: Set video decoder clock rate to 408MHz

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

On Wed, Nov 04, 2020 at 05:12:50PM +0300, Dmitry Osipenko wrote:
> The default 600MHz is technically unsupported on Nexus 7. Assign VDE clock
> to 408MHz, which is supported by all hardware versions.
> 
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 3 +++
>  1 file changed, 3 insertions(+)

This doesn't seem to apply. Is there another patch that this depends on?

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2 0/8] Nexus 7 and A500 device-tree improvements

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]

On Wed, Nov 04, 2020 at 05:12:43PM +0300, Dmitry Osipenko wrote:
> This series improves device-trees of Nexus 7 and A500 devices by
> correcting old and adding new DT properties.
> 
> Changelog:
> 
> v2: - Added these two additional patches:
> 
>         ARM: tegra: nexus7: Set video decoder clock rate to 408MHz
>         ARM: tegra: nexus7: Use panel-lvds as the only panel compatible
> 
> Dmitry Osipenko (8):
>   ARM: tegra: acer-a500: Correct thermal zone names
>   ARM: tegra: acer-a500: Add power-supply to lvds-encoder node
>   ARM: tegra: nexus7: Correct thermal zone names
>   ARM: tegra: nexus7: Improve CPU passive-cooling threshold
>   ARM: tegra: nexus7: Add power-supply to lvds-encoder node
>   ARM: tegra: nexus7: Rename gpio-hog nodes
>   ARM: tegra: nexus7: Set video decoder clock rate to 408MHz
>   ARM: tegra: nexus7: Use panel-lvds as the only panel compatible
> 
>  .../boot/dts/tegra20-acer-a500-picasso.dts    |  5 ++--
>  .../tegra30-asus-nexus7-grouper-common.dtsi   | 30 +++++++++++++------
>  ...egra30-asus-nexus7-grouper-maxim-pmic.dtsi |  2 +-
>  .../boot/dts/tegra30-asus-nexus7-tilapia.dtsi |  2 +-
>  4 files changed, 26 insertions(+), 13 deletions(-)

Applied all of these except patch 7. Let me know if there is some other
patch that I need to pull in first.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2 7/8] ARM: tegra: nexus7: Set video decoder clock rate to 408MHz

[Dmitry Osipenko]

10.11.2020 20:58, Thierry Reding пишет:
> On Wed, Nov 04, 2020 at 05:12:50PM +0300, Dmitry Osipenko wrote:
>> The default 600MHz is technically unsupported on Nexus 7. Assign VDE clock
>> to 408MHz, which is supported by all hardware versions.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>>  arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 3 +++
>>  1 file changed, 3 insertions(+)
> 
> This doesn't seem to apply. Is there another patch that this depends on?

Indeed, this patch was done on top of the "core voltage scaling" series.
I'll rebase and send it separately, thanks.