* [PATCH] phy: tegra: Don't warn on probe deferral
@ 2020-11-11 10:37 Jon Hunter
2020-11-13 9:21 ` JC Kuo
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jon Hunter @ 2020-11-11 10:37 UTC (permalink / raw)
To: JC Kuo, Kishon Vijay Abraham I, Vinod Koul, Thierry Reding
Cc: linux-kernel, linux-tegra, Jon Hunter
Deferred probe is an expected return value for devm_regulator_bulk_get().
Given that the driver deals with it properly, there's no need to output a
warning that may potentially confuse users.
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
drivers/phy/tegra/xusb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index ad88d74c1884..2eafb813825b 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -1200,7 +1200,7 @@ static int tegra_xusb_padctl_probe(struct platform_device *pdev)
err = devm_regulator_bulk_get(&pdev->dev, padctl->soc->num_supplies,
padctl->supplies);
if (err < 0) {
- dev_err(&pdev->dev, "failed to get regulators: %d\n", err);
+ dev_err_probe(&pdev->dev, err, "failed to get regulators\n");
goto remove;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] phy: tegra: Don't warn on probe deferral
2020-11-11 10:37 [PATCH] phy: tegra: Don't warn on probe deferral Jon Hunter
@ 2020-11-13 9:21 ` JC Kuo
2020-11-13 16:12 ` Thierry Reding
2020-11-16 7:49 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: JC Kuo @ 2020-11-13 9:21 UTC (permalink / raw)
To: Jon Hunter, Kishon Vijay Abraham I, Vinod Koul, Thierry Reding
Cc: linux-kernel, linux-tegra
On 11/11/20 6:37 PM, Jon Hunter wrote:
> Deferred probe is an expected return value for devm_regulator_bulk_get().
> Given that the driver deals with it properly, there's no need to output a
> warning that may potentially confuse users.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/phy/tegra/xusb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index ad88d74c1884..2eafb813825b 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -1200,7 +1200,7 @@ static int tegra_xusb_padctl_probe(struct platform_device *pdev)
> err = devm_regulator_bulk_get(&pdev->dev, padctl->soc->num_supplies,
> padctl->supplies);
> if (err < 0) {
> - dev_err(&pdev->dev, "failed to get regulators: %d\n", err);
> + dev_err_probe(&pdev->dev, err, "failed to get regulators\n");
> goto remove;
> }
>
>
Acked-by: JC Kuo <jckuo@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] phy: tegra: Don't warn on probe deferral
2020-11-11 10:37 [PATCH] phy: tegra: Don't warn on probe deferral Jon Hunter
2020-11-13 9:21 ` JC Kuo
@ 2020-11-13 16:12 ` Thierry Reding
2020-11-16 7:49 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2020-11-13 16:12 UTC (permalink / raw)
To: Jon Hunter
Cc: JC Kuo, Kishon Vijay Abraham I, Vinod Koul, linux-kernel, linux-tegra
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
On Wed, Nov 11, 2020 at 10:37:08AM +0000, Jon Hunter wrote:
> Deferred probe is an expected return value for devm_regulator_bulk_get().
> Given that the driver deals with it properly, there's no need to output a
> warning that may potentially confuse users.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/phy/tegra/xusb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] phy: tegra: Don't warn on probe deferral
2020-11-11 10:37 [PATCH] phy: tegra: Don't warn on probe deferral Jon Hunter
2020-11-13 9:21 ` JC Kuo
2020-11-13 16:12 ` Thierry Reding
@ 2020-11-16 7:49 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2020-11-16 7:49 UTC (permalink / raw)
To: Jon Hunter
Cc: JC Kuo, Kishon Vijay Abraham I, Thierry Reding, linux-kernel,
linux-tegra
On 11-11-20, 10:37, Jon Hunter wrote:
> Deferred probe is an expected return value for devm_regulator_bulk_get().
> Given that the driver deals with it properly, there's no need to output a
> warning that may potentially confuse users.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-16 7:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-11 10:37 [PATCH] phy: tegra: Don't warn on probe deferral Jon Hunter
2020-11-13 9:21 ` JC Kuo
2020-11-13 16:12 ` Thierry Reding
2020-11-16 7:49 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).