Re: [PATCH v3 2/4] dmaengine: tegra: Add tegra gpcdma driver

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 7591 bytes --]

Hi Akhil,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on vkoul-dmaengine/next arm64/for-next/core v5.14-rc7 next-20210827]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Akhil-R/dt-bindings-dmaengine-Add-doc-for-tegra-gpcdma/20210827-150504
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm-buildonly-randconfig-r005-20210827 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 1076082a0d97bd5c16a25ee7cf3dbb6ee4b5a9fe)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/0cc2ab4a5b7f236155b7b7740b26589f0dac8e7c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Akhil-R/dt-bindings-dmaengine-Add-doc-for-tegra-gpcdma/20210827-150504
        git checkout 0cc2ab4a5b7f236155b7b7740b26589f0dac8e7c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

>> drivers/dma/tegra-gpc-dma.c:543:9: error: implicit declaration of function 'FIELD_PREP' [-Werror,-Wimplicit-function-declaration]
           csr |= TEGRA_GPCDMA_CSR_REQ_SEL_UNUSED;
                  ^
   drivers/dma/tegra-gpc-dma.c:62:6: note: expanded from macro 'TEGRA_GPCDMA_CSR_REQ_SEL_UNUSED'
                                           FIELD_PREP(TEGRA_GPCDMA_CSR_REQ_SEL_MASK, 4)
                                           ^
   drivers/dma/tegra-gpc-dma.c:671:10: error: implicit declaration of function 'FIELD_PREP' [-Werror,-Wimplicit-function-declaration]
                   return TEGRA_GPCDMA_MMIOSEQ_BUS_WIDTH_8;
                          ^
   drivers/dma/tegra-gpc-dma.c:114:6: note: expanded from macro 'TEGRA_GPCDMA_MMIOSEQ_BUS_WIDTH_8'
                                           FIELD_PREP(TEGRA_GPCDMA_MMIOSEQ_BUS_WIDTH, 0)
                                           ^
   drivers/dma/tegra-gpc-dma.c:688:9: error: implicit declaration of function 'FIELD_PREP' [-Werror,-Wimplicit-function-declaration]
                   ret = TEGRA_GPCDMA_MMIOSEQ_BURST_1;
                         ^
   drivers/dma/tegra-gpc-dma.c:122:6: note: expanded from macro 'TEGRA_GPCDMA_MMIOSEQ_BURST_1'
                                           FIELD_PREP(TEGRA_GPCDMA_MMIOSEQ_BURST, 0)
                                           ^
   drivers/dma/tegra-gpc-dma.c:726:9: error: implicit declaration of function 'FIELD_PREP' [-Werror,-Wimplicit-function-declaration]
                   ret = TEGRA_GPCDMA_MMIOSEQ_BURST_1;
                         ^
   drivers/dma/tegra-gpc-dma.c:122:6: note: expanded from macro 'TEGRA_GPCDMA_MMIOSEQ_BURST_1'
                                           FIELD_PREP(TEGRA_GPCDMA_MMIOSEQ_BURST, 0)
                                           ^
   drivers/dma/tegra-gpc-dma.c:759:10: error: implicit declaration of function 'FIELD_PREP' [-Werror,-Wimplicit-function-declaration]
                   *csr = TEGRA_GPCDMA_CSR_DMA_MEM2IO_FC;
                          ^
   drivers/dma/tegra-gpc-dma.c:54:6: note: expanded from macro 'TEGRA_GPCDMA_CSR_DMA_MEM2IO_FC'
                                           FIELD_PREP(TEGRA_GPCDMA_CSR_DMA, 3)
                                           ^
   drivers/dma/tegra-gpc-dma.c:789:8: error: implicit declaration of function 'FIELD_PREP' [-Werror,-Wimplicit-function-declaration]
           csr = TEGRA_GPCDMA_CSR_DMA_FIXED_PAT;
                 ^
   drivers/dma/tegra-gpc-dma.c:58:6: note: expanded from macro 'TEGRA_GPCDMA_CSR_DMA_FIXED_PAT'
                                           FIELD_PREP(TEGRA_GPCDMA_CSR_DMA, 6)
                                           ^
>> drivers/dma/tegra-gpc-dma.c:834:53: warning: shift count >= width of type [-Wshift-count-overflow]
                           FIELD_PREP(TEGRA_GPCDMA_HIGH_ADDR_DST_PTR, (dest >> 32));
                                                                            ^  ~~
   drivers/dma/tegra-gpc-dma.c:859:8: error: implicit declaration of function 'FIELD_PREP' [-Werror,-Wimplicit-function-declaration]
           csr = TEGRA_GPCDMA_CSR_DMA_MEM2MEM;
                 ^
   drivers/dma/tegra-gpc-dma.c:56:6: note: expanded from macro 'TEGRA_GPCDMA_CSR_DMA_MEM2MEM'
                                           FIELD_PREP(TEGRA_GPCDMA_CSR_DMA, 4)
                                           ^
   drivers/dma/tegra-gpc-dma.c:905:51: warning: shift count >= width of type [-Wshift-count-overflow]
                   FIELD_PREP(TEGRA_GPCDMA_HIGH_ADDR_SRC_PTR, (src >> 32));
                                                                   ^  ~~
   drivers/dma/tegra-gpc-dma.c:907:52: warning: shift count >= width of type [-Wshift-count-overflow]
                   FIELD_PREP(TEGRA_GPCDMA_HIGH_ADDR_DST_PTR, (dest >> 32));
                                                                    ^  ~~
   drivers/dma/tegra-gpc-dma.c:951:9: error: implicit declaration of function 'FIELD_PREP' [-Werror,-Wimplicit-function-declaration]
           csr |= FIELD_PREP(TEGRA_GPCDMA_CSR_REQ_SEL_MASK, tdc->slave_id);
                  ^
   drivers/dma/tegra-gpc-dma.c:1012:53: warning: shift count >= width of type [-Wshift-count-overflow]
                                   FIELD_PREP(TEGRA_GPCDMA_HIGH_ADDR_SRC_PTR, (mem >> 32));
                                                                                   ^  ~~
   drivers/dma/tegra-gpc-dma.c:1017:53: warning: shift count >= width of type [-Wshift-count-overflow]
                                   FIELD_PREP(TEGRA_GPCDMA_HIGH_ADDR_DST_PTR, (mem >> 32));
                                                                                   ^  ~~
   drivers/dma/tegra-gpc-dma.c:1128:13: error: implicit declaration of function 'FIELD_PREP' [-Werror,-Wimplicit-function-declaration]
           reg_val |= FIELD_PREP(TEGRA_GPCDMA_MCSEQ_STREAM_ID0_MASK, stream_id);
                      ^
>> drivers/dma/tegra-gpc-dma.c:1322:21: warning: attribute declaration must precede definition [-Wignored-attributes]
   static const struct __maybe_unused dev_pm_ops tegra_dma_dev_pm_ops = {
                       ^
   include/linux/compiler_attributes.h:287:56: note: expanded from macro '__maybe_unused'
   #define __maybe_unused                  __attribute__((__unused__))
                                                          ^
   include/linux/pm.h:277:8: note: previous definition is here
   struct dev_pm_ops {
          ^
   6 warnings and 9 errors generated.


vim +/FIELD_PREP +543 drivers/dma/tegra-gpc-dma.c

   537	
   538	static void tegra_dma_reset_client(struct tegra_dma_channel *tdc)
   539	{
   540		u32 csr = tdc_read(tdc, TEGRA_GPCDMA_CHAN_CSR);
   541	
   542		csr &= ~(TEGRA_GPCDMA_CSR_REQ_SEL_MASK);
 > 543		csr |= TEGRA_GPCDMA_CSR_REQ_SEL_UNUSED;
   544		tdc_write(tdc, TEGRA_GPCDMA_CHAN_CSR, csr);
   545	}
   546	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36409 bytes --]