From: Dmitry Osipenko <digetx@gmail.com>
To: Rajesh Gumasta <rgumasta@nvidia.com>,
ldewangan@nvidia.com, jonathanh@nvidia.com, vkoul@kernel.org,
dan.j.williams@intel.com, thierry.reding@gmail.com,
p.zabel@pengutronix.de, dmaengine@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kyarlagadda@nvidia.com, Pavan Kunapuli <pkunapuli@nvidia.com>
Subject: Re: [Patch v2 2/4] dmaengine: tegra: Add Tegra GPC DMA driver
Date: Thu, 6 Aug 2020 18:02:34 +0300 [thread overview]
Message-ID: <67b9821a-1820-5089-445b-0d1b4f4ee996@gmail.com> (raw)
In-Reply-To: <1596699006-9934-3-git-send-email-rgumasta@nvidia.com>
06.08.2020 10:30, Rajesh Gumasta пишет:
> +static int tegra_dma_program_sid(struct tegra_dma_channel *tdc,
> + int chan, int stream_id)
> +{
> + unsigned int reg_val = tdc_read(tdc, TEGRA_GPCDMA_CHAN_MCSEQ);
> +
> + reg_val &= ~(TEGRA_GPCDMA_MCSEQ_STREAM_ID_MASK <<
> + TEGRA_GPCDMA_MCSEQ_STREAM_ID0_SHIFT);
> + reg_val &= ~(TEGRA_GPCDMA_MCSEQ_STREAM_ID_MASK <<
> + TEGRA_GPCDMA_MCSEQ_STREAM_ID1_SHIFT);
> +
> + reg_val |= (stream_id << TEGRA_GPCDMA_MCSEQ_STREAM_ID0_SHIFT);
> + reg_val |= (stream_id << TEGRA_GPCDMA_MCSEQ_STREAM_ID1_SHIFT);
Have you seen my comment to v1 about FIELD_GET/FIELD_PREP?
If you disagree with something, then you should answer with a rationale
and not silently ignore review comments.
next prev parent reply other threads:[~2020-08-06 16:56 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 7:30 [Patch v2 0/4] Add Nvidia Tegra GPC-DMA driver Rajesh Gumasta
2020-08-06 7:30 ` [Patch v2 1/4] dt-bindings: dma: Add DT binding document Rajesh Gumasta
2020-08-06 7:30 ` [Patch v2 2/4] dmaengine: tegra: Add Tegra GPC DMA driver Rajesh Gumasta
2020-08-06 13:46 ` Dmitry Osipenko
2020-08-06 13:56 ` Rajesh Gumasta
2020-08-06 14:22 ` Dmitry Osipenko
2020-08-06 14:49 ` Dmitry Osipenko
2020-08-06 15:02 ` Dmitry Osipenko [this message]
2020-08-07 16:03 ` Jon Hunter
2020-08-07 16:23 ` Jon Hunter
2020-08-06 7:30 ` [Patch v2 3/4] arm64: configs: enable tegra gpc dma Rajesh Gumasta
2020-08-06 7:30 ` [Patch v2 4/4] arm64: tegra: Add GPCDMA node in dt Rajesh Gumasta
2020-08-07 16:26 ` Jon Hunter
2021-01-14 10:11 ` [Patch v2 0/4] Add Nvidia Tegra GPC-DMA driver Jon Hunter
2021-01-15 5:56 ` Vinod Koul
2021-01-15 13:21 ` Jon Hunter
2021-01-15 13:42 ` Rajesh Gumasta
2021-08-27 6:04 ` [PATCH v3 " Akhil R
2021-08-27 6:04 ` [PATCH v3 1/4] dt-bindings: dmaengine: Add doc for tegra gpcdma Akhil R
2021-09-02 10:42 ` Jon Hunter
2021-08-27 6:04 ` [PATCH v3 2/4] dmaengine: tegra: Add tegra gpcdma driver Akhil R
2021-08-27 17:23 ` kernel test robot
2021-08-28 11:29 ` kernel test robot
2021-09-01 20:56 ` Jon Hunter
2021-09-02 10:57 ` Jon Hunter
2021-09-02 10:17 ` Jon Hunter
2021-08-27 6:04 ` [PATCH v3 3/4] arm64: defconfig: tegra: Enable GPCDMA Akhil R
2021-09-02 11:35 ` Jon Hunter
2021-08-27 6:04 ` [PATCH v3 4/4] arm64: tegra: Add GPCDMA node for tegra186 and tegra194 Akhil R
2021-09-02 10:36 ` Jon Hunter
2021-09-08 14:32 ` [PATCH v4 0/4] Add Nvidia Tegra GPC-DMA driver Akhil R
2021-09-08 14:32 ` [PATCH v4 1/4] dt-bindings: dmaengine: Add doc for tegra gpcdma Akhil R
2021-09-08 16:44 ` Jon Hunter
2021-09-15 8:08 ` Akhil R
2021-09-08 14:32 ` [PATCH v4 2/4] dmaengine: tegra: Add tegra gpcdma driver Akhil R
2021-09-08 14:32 ` [PATCH v4 3/4] arm64: defconfig: tegra: Enable GPCDMA Akhil R
2021-09-08 14:32 ` [PATCH v4 4/4] arm64: tegra: Add GPCDMA node for tegra186 and tegra194 Akhil R
2021-09-08 16:45 ` Jon Hunter
2021-09-08 16:44 ` [PATCH v4 0/4] Add Nvidia Tegra GPC-DMA driver Jon Hunter
2021-09-13 4:08 ` Akhil R
2021-09-16 12:18 ` [PATCH v5 " Akhil R
2021-09-16 12:18 ` [PATCH v5 1/4] dt-bindings: dmaengine: Add doc for tegra gpcdma Akhil R
2021-09-16 14:30 ` Jon Hunter
2021-09-16 12:18 ` [PATCH v5 2/4] dmaengine: tegra: Add tegra gpcdma driver Akhil R
2021-09-16 12:18 ` [PATCH v5 3/4] arm64: defconfig: tegra: Enable GPCDMA Akhil R
2021-09-16 12:18 ` [PATCH v5 4/4] arm64: tegra: Add GPCDMA node for tegra186 and tegra194 Akhil R
2021-09-16 14:33 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67b9821a-1820-5089-445b-0d1b4f4ee996@gmail.com \
--to=digetx@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kyarlagadda@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pkunapuli@nvidia.com \
--cc=rgumasta@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).