* [PATCH v2] dt-bindings: usb: tegra-xusb: Convert to json-schema
@ 2022-11-03 14:42 Thierry Reding
2022-11-07 19:52 ` Rob Herring
2022-11-25 12:41 ` Conor Dooley
0 siblings, 2 replies; 7+ messages in thread
From: Thierry Reding @ 2022-11-03 14:42 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Greg Kroah-Hartman, Jon Hunter, Wayne Chang, devicetree,
linux-usb, linux-tegra
From: Thierry Reding <treding@nvidia.com>
Convert the Tegra XUSB controller bindings from the free-form text
format to json-schema.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
Wayne, going forward it might make sense for you to pick this up into
your Tegra234 series and add the Tegra234 bindings on top of this.
Changes in v2:
- use minItems/maxItems/items instead of contains/anyOf for phy-names
- add missing compatible string to USB device example
- drop unneeded phys property description
- drop unneeded USB bus properties
- add reference to usb-xhci.yaml
.../bindings/usb/nvidia,tegra124-xusb.txt | 132 -----------
.../bindings/usb/nvidia,tegra124-xusb.yaml | 202 +++++++++++++++++
.../bindings/usb/nvidia,tegra186-xusb.yaml | 181 +++++++++++++++
.../bindings/usb/nvidia,tegra194-xusb.yaml | 187 ++++++++++++++++
.../bindings/usb/nvidia,tegra210-xusb.yaml | 207 ++++++++++++++++++
5 files changed, 777 insertions(+), 132 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
create mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.yaml
create mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.yaml
create mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra194-xusb.yaml
create mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra210-xusb.yaml
diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
deleted file mode 100644
index 5bfcc0b4d6b9..000000000000
--- a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
+++ /dev/null
@@ -1,132 +0,0 @@
-NVIDIA Tegra xHCI controller
-============================
-
-The Tegra xHCI controller supports both USB2 and USB3 interfaces exposed by
-the Tegra XUSB pad controller.
-
-Required properties:
---------------------
-- compatible: Must be:
- - Tegra124: "nvidia,tegra124-xusb"
- - Tegra132: "nvidia,tegra132-xusb", "nvidia,tegra124-xusb"
- - Tegra210: "nvidia,tegra210-xusb"
- - Tegra186: "nvidia,tegra186-xusb"
-- reg: Must contain the base and length of the xHCI host registers, XUSB FPCI
- registers and XUSB IPFS registers.
-- reg-names: Must contain the following entries:
- - "hcd"
- - "fpci"
- - "ipfs"
-- interrupts: Must contain the xHCI host interrupt and the mailbox interrupt.
-- clocks: Must contain an entry for each entry in clock-names.
- See ../clock/clock-bindings.txt for details.
-- clock-names: Must include the following entries:
- - xusb_host
- - xusb_host_src
- - xusb_falcon_src
- - xusb_ss
- - xusb_ss_src
- - xusb_ss_div2
- - xusb_hs_src
- - xusb_fs_src
- - pll_u_480m
- - clk_m
- - pll_e
-- resets: Must contain an entry for each entry in reset-names.
- See ../reset/reset.txt for details.
-- reset-names: Must include the following entries:
- - xusb_host
- - xusb_ss
- - xusb_src
- Note that xusb_src is the shared reset for xusb_{ss,hs,fs,falcon,host}_src.
-- nvidia,xusb-padctl: phandle to the XUSB pad controller that is used to
- configure the USB pads used by the XHCI controller
-
-For Tegra124 and Tegra132:
-- avddio-pex-supply: PCIe/USB3 analog logic power supply. Must supply 1.05 V.
-- dvddio-pex-supply: PCIe/USB3 digital logic power supply. Must supply 1.05 V.
-- avdd-usb-supply: USB controller power supply. Must supply 3.3 V.
-- avdd-pll-utmip-supply: UTMI PLL power supply. Must supply 1.8 V.
-- avdd-pll-erefe-supply: PLLE reference PLL power supply. Must supply 1.05 V.
-- avdd-usb-ss-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V.
-- hvdd-usb-ss-supply: High-voltage PCIe/USB3 power supply. Must supply 3.3 V.
-- hvdd-usb-ss-pll-e-supply: High-voltage PLLE power supply. Must supply 3.3 V.
-
-For Tegra210:
-- dvddio-pex-supply: PCIe/USB3 analog logic power supply. Must supply 1.05 V.
-- hvddio-pex-supply: High-voltage PCIe/USB3 power supply. Must supply 1.8 V.
-- avdd-usb-supply: USB controller power supply. Must supply 3.3 V.
-- avdd-pll-utmip-supply: UTMI PLL power supply. Must supply 1.8 V.
-- avdd-pll-uerefe-supply: PLLE reference PLL power supply. Must supply 1.05 V.
-- dvdd-pex-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V.
-- hvdd-pex-pll-e-supply: High-voltage PLLE power supply. Must supply 1.8 V.
-
-For Tegra210 and Tegra186:
-- power-domains: A list of PM domain specifiers that reference each power-domain
- used by the xHCI controller. This list must comprise of a specifier for the
- XUSBA and XUSBC power-domains. See ../power/power_domain.txt and
- ../arm/tegra/nvidia,tegra20-pmc.txt for details.
-- power-domain-names: A list of names that represent each of the specifiers in
- the 'power-domains' property. Must include 'xusb_ss' and 'xusb_host' which
- represent the power-domains XUSBA and XUSBC, respectively. See
- ../power/power_domain.txt for details.
-
-Optional properties:
---------------------
-- phys: Must contain an entry for each entry in phy-names.
- See ../phy/phy-bindings.txt for details.
-- phy-names: Should include an entry for each PHY used by the controller. The
- following PHYs are available:
- - Tegra124: usb2-0, usb2-1, usb2-2, hsic-0, hsic-1, usb3-0, usb3-1
- - Tegra132: usb2-0, usb2-1, usb2-2, hsic-0, hsic-1, usb3-0, usb3-1
- - Tegra210: usb2-0, usb2-1, usb2-2, usb2-3, hsic-0, usb3-0, usb3-1, usb3-2,
- usb3-3
- - Tegra186: usb2-0, usb2-1, usb2-2, hsic-0, usb3-0, usb3-1, usb3-2
-
-Example:
---------
-
- usb@0,70090000 {
- compatible = "nvidia,tegra124-xusb";
- reg = <0x0 0x70090000 0x0 0x8000>,
- <0x0 0x70098000 0x0 0x1000>,
- <0x0 0x70099000 0x0 0x1000>;
- reg-names = "hcd", "fpci", "ipfs";
-
- interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
-
- clocks = <&tegra_car TEGRA124_CLK_XUSB_HOST>,
- <&tegra_car TEGRA124_CLK_XUSB_HOST_SRC>,
- <&tegra_car TEGRA124_CLK_XUSB_FALCON_SRC>,
- <&tegra_car TEGRA124_CLK_XUSB_SS>,
- <&tegra_car TEGRA124_CLK_XUSB_SS_DIV2>,
- <&tegra_car TEGRA124_CLK_XUSB_SS_SRC>,
- <&tegra_car TEGRA124_CLK_XUSB_HS_SRC>,
- <&tegra_car TEGRA124_CLK_XUSB_FS_SRC>,
- <&tegra_car TEGRA124_CLK_PLL_U_480M>,
- <&tegra_car TEGRA124_CLK_CLK_M>,
- <&tegra_car TEGRA124_CLK_PLL_E>;
- clock-names = "xusb_host", "xusb_host_src", "xusb_falcon_src",
- "xusb_ss", "xusb_ss_div2", "xusb_ss_src",
- "xusb_hs_src", "xusb_fs_src", "pll_u_480m",
- "clk_m", "pll_e";
- resets = <&tegra_car 89>, <&tegra_car 156>, <&tegra_car 143>;
- reset-names = "xusb_host", "xusb_ss", "xusb_src";
-
- nvidia,xusb-padctl = <&padctl>;
-
- phys = <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-1}>, /* mini-PCIe USB */
- <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-2}>, /* USB A */
- <&{/padctl@0,7009f000/pads/pcie/lanes/pcie-0}>; /* USB A */
- phy-names = "usb2-1", "usb2-2", "usb3-0";
-
- avddio-pex-supply = <&vdd_1v05_run>;
- dvddio-pex-supply = <&vdd_1v05_run>;
- avdd-usb-supply = <&vdd_3v3_lp0>;
- avdd-pll-utmip-supply = <&vddio_1v8>;
- avdd-pll-erefe-supply = <&avdd_1v05_run>;
- avdd-usb-ss-pll-supply = <&vdd_1v05_run>;
- hvdd-usb-ss-supply = <&vdd_3v3_lp0>;
- hvdd-usb-ss-pll-e-supply = <&vdd_3v3_lp0>;
- };
diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.yaml
new file mode 100644
index 000000000000..4a6616bf9bab
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.yaml
@@ -0,0 +1,202 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/nvidia,tegra124-xusb.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NVIDIA Tegra124 xHCI controller
+
+maintainers:
+ - Thierry Reding <thierry.reding@gmail.com>
+ - Jon Hunter <jonathanh@nvidia.com>
+
+description: The Tegra xHCI controller supports both USB2 and USB3 interfaces
+ exposed by the Tegra XUSB pad controller.
+
+properties:
+ # required
+ compatible:
+ oneOf:
+ - description: NVIDIA Tegra124
+ const: nvidia,tegra124-xusb
+
+ - description: NVIDIA Tegra132
+ items:
+ - const: nvidia,tegra132-xusb
+ - const: nvidia,tegra124-xusb
+
+ reg:
+ items:
+ - description: base and length of the xHCI host registers
+ - description: base and length of the XUSB FPCI registers
+ - description: base and length of the XUSB IPFS registers
+
+ reg-names:
+ items:
+ - const: hcd
+ - const: fpci
+ - const: ipfs
+
+ interrupts:
+ items:
+ - description: xHCI host interrupt
+ - description: mailbox interrupt
+
+ clocks:
+ items:
+ - description: XUSB host clock
+ - description: XUSB host source clock
+ - description: XUSB Falcon source clock
+ - description: XUSB SuperSpeed clock
+ - description: XUSB SuperSpeed clock divider
+ - description: XUSB SuperSpeed source clock
+ - description: XUSB HighSpeed clock source
+ - description: XUSB FullSpeed clock source
+ - description: USB PLL
+ - description: reference clock
+ - description: I/O PLL
+
+ clock-names:
+ items:
+ - const: xusb_host
+ - const: xusb_host_src
+ - const: xusb_falcon_src
+ - const: xusb_ss
+ - const: xusb_ss_div2
+ - const: xusb_ss_src
+ - const: xusb_hs_src
+ - const: xusb_fs_src
+ - const: pll_u_480m
+ - const: clk_m
+ - const: pll_e
+
+ resets:
+ items:
+ - description: reset for the XUSB host controller
+ - description: reset for the SuperSpeed logic
+ - description: shared reset for xusb_{ss,hs,fs,falcon,host}_src.
+
+ reset-names:
+ items:
+ - const: xusb_host
+ - const: xusb_ss
+ - const: xusb_src
+
+ nvidia,xusb-padctl:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: phandle to the XUSB pad controller that is used to configure
+ the USB pads used by the XHCI controller
+
+ # optional
+ phys:
+ minItems: 1
+ maxItems: 7
+
+ phy-names:
+ minItems: 1
+ maxItems: 7
+ items:
+ enum:
+ - usb2-0
+ - usb2-1
+ - usb2-2
+ - hsic-0
+ - hsic-1
+ - usb3-0
+ - usb3-1
+
+ avddio-pex-supply:
+ description: PCIe/USB3 analog logic power supply. Must supply 1.05 V.
+
+ dvddio-pex-supply:
+ description: PCIe/USB3 digital logic power supply. Must supply 1.05 V.
+
+ avdd-usb-supply:
+ description: USB controller power supply. Must supply 3.3 V.
+
+ avdd-pll-utmip-supply:
+ description: UTMI PLL power supply. Must supply 1.8 V.
+
+ avdd-pll-erefe-supply:
+ description: PLLE reference PLL power supply. Must supply 1.05 V.
+
+ avdd-usb-ss-pll-supply:
+ description: PCIe/USB3 PLL power supply. Must supply 1.05 V.
+
+ hvdd-usb-ss-supply:
+ description: High-voltage PCIe/USB3 power supply. Must supply 3.3 V.
+
+ hvdd-usb-ss-pll-e-supply:
+ description: High-voltage PLLE power supply. Must supply 3.3 V.
+
+allOf:
+ - $ref: usb-xhci.yaml
+
+unevaluatedProperties: false
+
+required:
+ - compatible
+ - reg
+ - reg-names
+ - interrupts
+ - clocks
+ - clock-names
+ - resets
+ - reset-names
+ - nvidia,xusb-padctl
+ - phys
+ - phy-names
+ - avddio-pex-supply
+ - dvddio-pex-supply
+ - avdd-usb-supply
+ - hvdd-usb-ss-supply
+
+examples:
+ - |
+ #include <dt-bindings/clock/tegra124-car.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ usb@70090000 {
+ compatible = "nvidia,tegra124-xusb";
+ reg = <0x70090000 0x8000>,
+ <0x70098000 0x1000>,
+ <0x70099000 0x1000>;
+ reg-names = "hcd", "fpci", "ipfs";
+
+ interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
+
+ clocks = <&tegra_car TEGRA124_CLK_XUSB_HOST>,
+ <&tegra_car TEGRA124_CLK_XUSB_HOST_SRC>,
+ <&tegra_car TEGRA124_CLK_XUSB_FALCON_SRC>,
+ <&tegra_car TEGRA124_CLK_XUSB_SS>,
+ <&tegra_car TEGRA124_CLK_XUSB_SS_DIV2>,
+ <&tegra_car TEGRA124_CLK_XUSB_SS_SRC>,
+ <&tegra_car TEGRA124_CLK_XUSB_HS_SRC>,
+ <&tegra_car TEGRA124_CLK_XUSB_FS_SRC>,
+ <&tegra_car TEGRA124_CLK_PLL_U_480M>,
+ <&tegra_car TEGRA124_CLK_CLK_M>,
+ <&tegra_car TEGRA124_CLK_PLL_E>;
+ clock-names = "xusb_host", "xusb_host_src", "xusb_falcon_src",
+ "xusb_ss", "xusb_ss_div2", "xusb_ss_src",
+ "xusb_hs_src", "xusb_fs_src", "pll_u_480m",
+ "clk_m", "pll_e";
+ resets = <&tegra_car 89>, <&tegra_car 156>, <&tegra_car 143>;
+ reset-names = "xusb_host", "xusb_ss", "xusb_src";
+
+ nvidia,xusb-padctl = <&padctl>;
+
+ phys = <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-1}>, /* mini-PCIe USB */
+ <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-2}>, /* USB A */
+ <&{/padctl@0,7009f000/pads/pcie/lanes/pcie-0}>; /* USB A */
+ phy-names = "usb2-1", "usb2-2", "usb3-0";
+
+ avddio-pex-supply = <&vdd_1v05_run>;
+ dvddio-pex-supply = <&vdd_1v05_run>;
+ avdd-usb-supply = <&vdd_3v3_lp0>;
+ avdd-pll-utmip-supply = <&vddio_1v8>;
+ avdd-pll-erefe-supply = <&avdd_1v05_run>;
+ avdd-usb-ss-pll-supply = <&vdd_1v05_run>;
+ hvdd-usb-ss-supply = <&vdd_3v3_lp0>;
+ hvdd-usb-ss-pll-e-supply = <&vdd_3v3_lp0>;
+ };
diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.yaml
new file mode 100644
index 000000000000..7126d137133a
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.yaml
@@ -0,0 +1,181 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/nvidia,tegra186-xusb.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NVIDIA Tegra186 xHCI controller
+
+maintainers:
+ - Thierry Reding <thierry.reding@gmail.com>
+ - Jon Hunter <jonathanh@nvidia.com>
+
+description: The Tegra xHCI controller supports both USB2 and USB3 interfaces
+ exposed by the Tegra XUSB pad controller.
+
+properties:
+ compatible:
+ const: nvidia,tegra186-xusb
+
+ reg:
+ items:
+ - description: base and length of the xHCI host registers
+ - description: base and length of the XUSB FPCI registers
+
+ reg-names:
+ items:
+ - const: hcd
+ - const: fpci
+
+ interrupts:
+ items:
+ - description: xHCI host interrupt
+ - description: mailbox interrupt
+
+ clocks:
+ items:
+ - description: XUSB host clock
+ - description: XUSB Falcon source clock
+ - description: XUSB SuperSpeed clock
+ - description: XUSB SuperSpeed source clock
+ - description: XUSB HighSpeed clock source
+ - description: XUSB FullSpeed clock source
+ - description: USB PLL
+ - description: reference clock
+ - description: I/O PLL
+
+ clock-names:
+ items:
+ - const: xusb_host
+ - const: xusb_falcon_src
+ - const: xusb_ss
+ - const: xusb_ss_src
+ - const: xusb_hs_src
+ - const: xusb_fs_src
+ - const: pll_u_480m
+ - const: clk_m
+ - const: pll_e
+
+ interconnects:
+ items:
+ - description: read client
+ - description: write client
+
+ interconnect-names:
+ items:
+ - const: dma-mem # read
+ - const: write
+
+ iommus:
+ maxItems: 1
+
+ nvidia,xusb-padctl:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: phandle to the XUSB pad controller that is used to configure
+ the USB pads used by the XHCI controller
+
+ phys:
+ minItems: 1
+ maxItems: 7
+
+ phy-names:
+ minItems: 1
+ maxItems: 7
+ items:
+ enum:
+ - usb2-0
+ - usb2-1
+ - usb2-2
+ - hsic-0
+ - usb3-0
+ - usb3-1
+ - usb3-2
+
+ power-domains:
+ description: A list of PM domain specifiers that reference each power-
+ domain used by the xHCI controller. This list must comprise of a
+ specifier for the XUSBA and XUSBC power-domains.
+
+ See ../power/power_domain.txt and ../arm/tegra/nvidia,tegra20-pmc.txt
+ for details.
+ items:
+ - description: XUSBC power domain
+ - description: XUSBA power domain
+
+ power-domain-names:
+ description: A list of names that represent each of the specifiers in the
+ 'power-domains' property. See ../power/power_domain.txt for details.
+ items:
+ - const: xusb_host
+ - const: xusb_ss
+
+ dvddio-pex-supply:
+ description: PCIe/USB3 analog logic power supply. Must supply 1.05 V.
+
+ hvddio-pex-supply:
+ description: High-voltage PCIe/USB3 power supply. Must supply 1.8 V.
+
+ avdd-usb-supply:
+ description: USB controller power supply. Must supply 3.3 V.
+
+ avdd-pll-utmip-supply:
+ description: UTMI PLL power supply. Must supply 1.8 V.
+
+ avdd-pll-uerefe-supply:
+ description: PLLE reference PLL power supply. Must supply 1.05 V.
+
+ dvdd-usb-ss-pll-supply:
+ description: PCIe/USB3 PLL power supply. Must supply 1.05 V.
+
+ hvdd-usb-ss-pll-e-supply:
+ description: High-voltage PLLE power supply. Must supply 1.8 V.
+
+allOf:
+ - $ref: usb-xhci.yaml
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/tegra186-clock.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/memory/tegra186-mc.h>
+ #include <dt-bindings/power/tegra186-powergate.h>
+ #include <dt-bindings/reset/tegra186-reset.h>
+
+ usb@3530000 {
+ compatible = "nvidia,tegra186-xusb";
+ reg = <0x03530000 0x8000>,
+ <0x03538000 0x1000>;
+ reg-names = "hcd", "fpci";
+ interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&bpmp TEGRA186_CLK_XUSB_HOST>,
+ <&bpmp TEGRA186_CLK_XUSB_FALCON>,
+ <&bpmp TEGRA186_CLK_XUSB_SS>,
+ <&bpmp TEGRA186_CLK_XUSB_CORE_SS>,
+ <&bpmp TEGRA186_CLK_CLK_M>,
+ <&bpmp TEGRA186_CLK_XUSB_FS>,
+ <&bpmp TEGRA186_CLK_PLLU>,
+ <&bpmp TEGRA186_CLK_CLK_M>,
+ <&bpmp TEGRA186_CLK_PLLE>;
+ clock-names = "xusb_host", "xusb_falcon_src", "xusb_ss",
+ "xusb_ss_src", "xusb_hs_src", "xusb_fs_src",
+ "pll_u_480m", "clk_m", "pll_e";
+ power-domains = <&bpmp TEGRA186_POWER_DOMAIN_XUSBC>,
+ <&bpmp TEGRA186_POWER_DOMAIN_XUSBA>;
+ power-domain-names = "xusb_host", "xusb_ss";
+ interconnects = <&mc TEGRA186_MEMORY_CLIENT_XUSB_HOSTR &emc>,
+ <&mc TEGRA186_MEMORY_CLIENT_XUSB_HOSTW &emc>;
+ interconnect-names = "dma-mem", "write";
+ iommus = <&smmu TEGRA186_SID_XUSB_HOST>;
+ nvidia,xusb-padctl = <&padctl>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ phys = <&{/padctl@3520000/pads/usb2/lanes/usb2-0}>,
+ <&{/padctl@3520000/pads/usb2/lanes/usb2-1}>,
+ <&{/padctl@3520000/pads/usb3/lanes/usb3-0}>;
+ phy-names = "usb2-0", "usb2-1", "usb3-0";
+ };
diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra194-xusb.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra194-xusb.yaml
new file mode 100644
index 000000000000..7697a0dbae15
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/nvidia,tegra194-xusb.yaml
@@ -0,0 +1,187 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/nvidia,tegra194-xusb.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NVIDIA Tegra194 xHCI controller
+
+maintainers:
+ - Thierry Reding <thierry.reding@gmail.com>
+ - Jon Hunter <jonathanh@nvidia.com>
+
+description: The Tegra xHCI controller supports both USB2 and USB3 interfaces
+ exposed by the Tegra XUSB pad controller.
+
+properties:
+ compatible:
+ const: nvidia,tegra194-xusb
+
+ reg:
+ items:
+ - description: base and length of the xHCI host registers
+ - description: base and length of the XUSB FPCI registers
+
+ reg-names:
+ items:
+ - const: hcd
+ - const: fpci
+
+ interrupts:
+ items:
+ - description: xHCI host interrupt
+ - description: mailbox interrupt
+
+ clocks:
+ items:
+ - description: XUSB host clock
+ - description: XUSB Falcon source clock
+ - description: XUSB SuperSpeed clock
+ - description: XUSB SuperSpeed source clock
+ - description: XUSB HighSpeed clock source
+ - description: XUSB FullSpeed clock source
+ - description: USB PLL
+ - description: reference clock
+ - description: I/O PLL
+
+ clock-names:
+ items:
+ - const: xusb_host
+ - const: xusb_falcon_src
+ - const: xusb_ss
+ - const: xusb_ss_src
+ - const: xusb_hs_src
+ - const: xusb_fs_src
+ - const: pll_u_480m
+ - const: clk_m
+ - const: pll_e
+
+ interconnects:
+ items:
+ - description: read client
+ - description: write client
+
+ interconnect-names:
+ items:
+ - const: dma-mem # read
+ - const: write
+
+ iommus:
+ maxItems: 1
+
+ nvidia,xusb-padctl:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: phandle to the XUSB pad controller that is used to configure
+ the USB pads used by the XHCI controller
+
+ phys:
+ minItems: 1
+ maxItems: 8
+
+ phy-names:
+ minItems: 1
+ maxItems: 8
+ items:
+ enum:
+ - usb2-0
+ - usb2-1
+ - usb2-2
+ - usb2-3
+ - usb3-0
+ - usb3-1
+ - usb3-2
+ - usb3-3
+
+ power-domains:
+ description: A list of PM domain specifiers that reference each power-
+ domain used by the xHCI controller. This list must comprise of a
+ specifier for the XUSBA and XUSBC power-domains.
+
+ See ../power/power_domain.txt and ../arm/tegra/nvidia,tegra20-pmc.txt
+ for details.
+ items:
+ - description: XUSBC power domain
+ - description: XUSBA power domain
+
+ power-domain-names:
+ description: A list of names that represent each of the specifiers in the
+ 'power-domains' property. See ../power/power_domain.txt for details.
+ items:
+ - const: xusb_host
+ - const: xusb_ss
+
+ dvddio-pex-supply:
+ description: PCIe/USB3 analog logic power supply. Must supply 1.05 V.
+
+ hvddio-pex-supply:
+ description: High-voltage PCIe/USB3 power supply. Must supply 1.8 V.
+
+ avdd-usb-supply:
+ description: USB controller power supply. Must supply 3.3 V.
+
+ avdd-pll-utmip-supply:
+ description: UTMI PLL power supply. Must supply 1.8 V.
+
+ avdd-pll-uerefe-supply:
+ description: PLLE reference PLL power supply. Must supply 1.05 V.
+
+ dvdd-usb-ss-pll-supply:
+ description: PCIe/USB3 PLL power supply. Must supply 1.05 V.
+
+ hvdd-usb-ss-pll-e-supply:
+ description: High-voltage PLLE power supply. Must supply 1.8 V.
+
+allOf:
+ - $ref: usb-xhci.yaml
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/tegra194-clock.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/memory/tegra194-mc.h>
+ #include <dt-bindings/power/tegra194-powergate.h>
+ #include <dt-bindings/reset/tegra194-reset.h>
+
+ usb@3610000 {
+ compatible = "nvidia,tegra194-xusb";
+ reg = <0x03610000 0x40000>,
+ <0x03600000 0x10000>;
+ reg-names = "hcd", "fpci";
+
+ interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
+
+ clocks = <&bpmp TEGRA194_CLK_XUSB_CORE_HOST>,
+ <&bpmp TEGRA194_CLK_XUSB_FALCON>,
+ <&bpmp TEGRA194_CLK_XUSB_CORE_SS>,
+ <&bpmp TEGRA194_CLK_XUSB_SS>,
+ <&bpmp TEGRA194_CLK_CLK_M>,
+ <&bpmp TEGRA194_CLK_XUSB_FS>,
+ <&bpmp TEGRA194_CLK_UTMIPLL>,
+ <&bpmp TEGRA194_CLK_CLK_M>,
+ <&bpmp TEGRA194_CLK_PLLE>;
+ clock-names = "xusb_host", "xusb_falcon_src",
+ "xusb_ss", "xusb_ss_src", "xusb_hs_src",
+ "xusb_fs_src", "pll_u_480m", "clk_m",
+ "pll_e";
+ interconnects = <&mc TEGRA194_MEMORY_CLIENT_XUSB_HOSTR &emc>,
+ <&mc TEGRA194_MEMORY_CLIENT_XUSB_HOSTW &emc>;
+ interconnect-names = "dma-mem", "write";
+ iommus = <&smmu TEGRA194_SID_XUSB_HOST>;
+
+ power-domains = <&bpmp TEGRA194_POWER_DOMAIN_XUSBC>,
+ <&bpmp TEGRA194_POWER_DOMAIN_XUSBA>;
+ power-domain-names = "xusb_host", "xusb_ss";
+
+ nvidia,xusb-padctl = <&xusb_padctl>;
+
+ phys = <&{/bus@0/padctl@3520000/pads/usb2/lanes/usb2-0}>,
+ <&{/bus@0/padctl@3520000/pads/usb2/lanes/usb2-1}>,
+ <&{/bus@0/padctl@3520000/pads/usb2/lanes/usb2-3}>,
+ <&{/bus@0/padctl@3520000/pads/usb3/lanes/usb3-0}>,
+ <&{/bus@0/padctl@3520000/pads/usb3/lanes/usb3-2}>,
+ <&{/bus@0/padctl@3520000/pads/usb3/lanes/usb3-3}>;
+ phy-names = "usb2-0", "usb2-1", "usb2-3", "usb3-0", "usb3-2", "usb3-3";
+ };
diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra210-xusb.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra210-xusb.yaml
new file mode 100644
index 000000000000..5c8bef1f482b
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/nvidia,tegra210-xusb.yaml
@@ -0,0 +1,207 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/nvidia,tegra210-xusb.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NVIDIA Tegra210 xHCI controller
+
+maintainers:
+ - Thierry Reding <thierry.reding@gmail.com>
+ - Jon Hunter <jonathanh@nvidia.com>
+
+description: The Tegra xHCI controller supports both USB2 and USB3 interfaces
+ exposed by the Tegra XUSB pad controller.
+
+properties:
+ compatible:
+ const: nvidia,tegra210-xusb
+
+ reg:
+ items:
+ - description: base and length of the xHCI host registers
+ - description: base and length of the XUSB FPCI registers
+ - description: base and length of the XUSB IPFS registers
+
+ reg-names:
+ items:
+ - const: hcd
+ - const: fpci
+ - const: ipfs
+
+ interrupts:
+ items:
+ - description: xHCI host interrupt
+ - description: mailbox interrupt
+
+ clocks:
+ items:
+ - description: XUSB host clock
+ - description: XUSB host source clock
+ - description: XUSB Falcon source clock
+ - description: XUSB SuperSpeed clock
+ - description: XUSB SuperSpeed clock divider
+ - description: XUSB SuperSpeed source clock
+ - description: XUSB HighSpeed clock source
+ - description: XUSB FullSpeed clock source
+ - description: USB PLL
+ - description: reference clock
+ - description: I/O PLL
+
+ clock-names:
+ items:
+ - const: xusb_host
+ - const: xusb_host_src
+ - const: xusb_falcon_src
+ - const: xusb_ss
+ - const: xusb_ss_div2
+ - const: xusb_ss_src
+ - const: xusb_hs_src
+ - const: xusb_fs_src
+ - const: pll_u_480m
+ - const: clk_m
+ - const: pll_e
+
+ resets:
+ items:
+ - description: reset for the XUSB host controller
+ - description: reset for the SuperSpeed logic
+ - description: shared reset for xusb_{ss,hs,fs,falcon,host}_src.
+
+ reset-names:
+ items:
+ - const: xusb_host
+ - const: xusb_ss
+ - const: xusb_src
+
+ nvidia,xusb-padctl:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: phandle to the XUSB pad controller that is used to configure
+ the USB pads used by the XHCI controller
+
+ phys:
+ minItems: 1
+ maxItems: 9
+
+ phy-names:
+ minItems: 1
+ maxItems: 9
+ items:
+ enum:
+ - usb2-0
+ - usb2-1
+ - usb2-2
+ - usb2-3
+ - hsic-0
+ - usb3-0
+ - usb3-1
+ - usb3-2
+ - usb3-3
+
+ power-domains:
+ description: A list of PM domain specifiers that reference each power-
+ domain used by the xHCI controller. This list must comprise of a
+ specifier for the XUSBA and XUSBC power-domains.
+
+ See ../power/power_domain.txt and ../arm/tegra/nvidia,tegra20-pmc.txt
+ for details.
+ items:
+ - description: XUSBC power domain
+ - description: XUSBA power domain
+
+ power-domain-names:
+ description: A list of names that represent each of the specifiers in the
+ 'power-domains' property. See ../power/power_domain.txt for details.
+ items:
+ - const: xusb_host
+ - const: xusb_ss
+
+ dvddio-pex-supply:
+ description: PCIe/USB3 analog logic power supply. Must supply 1.05 V.
+
+ hvddio-pex-supply:
+ description: High-voltage PCIe/USB3 power supply. Must supply 1.8 V.
+
+ avdd-usb-supply:
+ description: USB controller power supply. Must supply 3.3 V.
+
+ avdd-pll-utmip-supply:
+ description: UTMI PLL power supply. Must supply 1.8 V.
+
+ avdd-pll-uerefe-supply:
+ description: PLLE reference PLL power supply. Must supply 1.05 V.
+
+ dvdd-usb-ss-pll-supply:
+ description: PCIe/USB3 PLL power supply. Must supply 1.05 V.
+
+ hvdd-usb-ss-pll-e-supply:
+ description: High-voltage PLLE power supply. Must supply 1.8 V.
+
+allOf:
+ - $ref: usb-xhci.yaml
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/tegra210-car.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ usb@70090000 {
+ compatible = "nvidia,tegra210-xusb";
+ reg = <0x70090000 0x8000>,
+ <0x70098000 0x1000>,
+ <0x70099000 0x1000>;
+ reg-names = "hcd", "fpci", "ipfs";
+
+ interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
+
+ clocks = <&tegra_car TEGRA210_CLK_XUSB_HOST>,
+ <&tegra_car TEGRA210_CLK_XUSB_HOST_SRC>,
+ <&tegra_car TEGRA210_CLK_XUSB_FALCON_SRC>,
+ <&tegra_car TEGRA210_CLK_XUSB_SS>,
+ <&tegra_car TEGRA210_CLK_XUSB_SS_DIV2>,
+ <&tegra_car TEGRA210_CLK_XUSB_SS_SRC>,
+ <&tegra_car TEGRA210_CLK_XUSB_HS_SRC>,
+ <&tegra_car TEGRA210_CLK_XUSB_FS_SRC>,
+ <&tegra_car TEGRA210_CLK_PLL_U_480M>,
+ <&tegra_car TEGRA210_CLK_CLK_M>,
+ <&tegra_car TEGRA210_CLK_PLL_E>;
+ clock-names = "xusb_host", "xusb_host_src",
+ "xusb_falcon_src", "xusb_ss",
+ "xusb_ss_div2", "xusb_ss_src",
+ "xusb_hs_src", "xusb_fs_src",
+ "pll_u_480m", "clk_m", "pll_e";
+ resets = <&tegra_car 89>, <&tegra_car 156>,
+ <&tegra_car 143>;
+ reset-names = "xusb_host", "xusb_ss", "xusb_src";
+ power-domains = <&pd_xusbhost>, <&pd_xusbss>;
+ power-domain-names = "xusb_host", "xusb_ss";
+
+ nvidia,xusb-padctl = <&padctl>;
+
+ phys = <&{/padctl@7009f000/pads/usb2/lanes/usb2-0}>,
+ <&{/padctl@7009f000/pads/usb2/lanes/usb2-1}>,
+ <&{/padctl@7009f000/pads/usb2/lanes/usb2-2}>,
+ <&{/padctl@7009f000/pads/usb2/lanes/usb2-3}>,
+ <&{/padctl@7009f000/pads/pcie/lanes/pcie-6}>,
+ <&{/padctl@7009f000/pads/pcie/lanes/pcie-5}>;
+ phy-names = "usb2-0", "usb2-1", "usb2-2", "usb2-3", "usb3-0",
+ "usb3-1";
+ dvddio-pex-supply = <&vdd_pex_1v05>;
+ hvddio-pex-supply = <&vdd_1v8>;
+ avdd-usb-supply = <&vdd_3v3_sys>;
+ avdd-pll-utmip-supply = <&vdd_1v8>;
+ avdd-pll-uerefe-supply = <&vdd_pex_1v05>;
+ dvdd-usb-ss-pll-supply = <&vdd_pex_1v05>;
+ hvdd-usb-ss-pll-e-supply = <&vdd_1v8>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethernet@1 {
+ compatible = "usb955,9ff";
+ reg = <1>;
+ };
+ };
--
2.38.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dt-bindings: usb: tegra-xusb: Convert to json-schema
2022-11-03 14:42 [PATCH v2] dt-bindings: usb: tegra-xusb: Convert to json-schema Thierry Reding
@ 2022-11-07 19:52 ` Rob Herring
2022-11-18 12:25 ` Thierry Reding
2022-11-25 12:41 ` Conor Dooley
1 sibling, 1 reply; 7+ messages in thread
From: Rob Herring @ 2022-11-07 19:52 UTC (permalink / raw)
To: Thierry Reding
Cc: Krzysztof Kozlowski, Greg Kroah-Hartman, Jon Hunter, Wayne Chang,
devicetree, linux-usb, linux-tegra
On Thu, Nov 03, 2022 at 03:42:00PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Convert the Tegra XUSB controller bindings from the free-form text
> format to json-schema.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Wayne, going forward it might make sense for you to pick this up into
> your Tegra234 series and add the Tegra234 bindings on top of this.
>
> Changes in v2:
> - use minItems/maxItems/items instead of contains/anyOf for phy-names
> - add missing compatible string to USB device example
> - drop unneeded phys property description
> - drop unneeded USB bus properties
> - add reference to usb-xhci.yaml
>
> .../bindings/usb/nvidia,tegra124-xusb.txt | 132 -----------
> .../bindings/usb/nvidia,tegra124-xusb.yaml | 202 +++++++++++++++++
> .../bindings/usb/nvidia,tegra186-xusb.yaml | 181 +++++++++++++++
> .../bindings/usb/nvidia,tegra194-xusb.yaml | 187 ++++++++++++++++
> .../bindings/usb/nvidia,tegra210-xusb.yaml | 207 ++++++++++++++++++
> 5 files changed, 777 insertions(+), 132 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
> create mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.yaml
> create mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.yaml
> create mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra194-xusb.yaml
> create mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra210-xusb.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
> deleted file mode 100644
> index 5bfcc0b4d6b9..000000000000
> --- a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
> +++ /dev/null
> @@ -1,132 +0,0 @@
> -NVIDIA Tegra xHCI controller
> -============================
> -
> -The Tegra xHCI controller supports both USB2 and USB3 interfaces exposed by
> -the Tegra XUSB pad controller.
> -
> -Required properties:
> ---------------------
> -- compatible: Must be:
> - - Tegra124: "nvidia,tegra124-xusb"
> - - Tegra132: "nvidia,tegra132-xusb", "nvidia,tegra124-xusb"
> - - Tegra210: "nvidia,tegra210-xusb"
> - - Tegra186: "nvidia,tegra186-xusb"
> -- reg: Must contain the base and length of the xHCI host registers, XUSB FPCI
> - registers and XUSB IPFS registers.
> -- reg-names: Must contain the following entries:
> - - "hcd"
> - - "fpci"
> - - "ipfs"
> -- interrupts: Must contain the xHCI host interrupt and the mailbox interrupt.
> -- clocks: Must contain an entry for each entry in clock-names.
> - See ../clock/clock-bindings.txt for details.
> -- clock-names: Must include the following entries:
> - - xusb_host
> - - xusb_host_src
> - - xusb_falcon_src
> - - xusb_ss
> - - xusb_ss_src
> - - xusb_ss_div2
> - - xusb_hs_src
> - - xusb_fs_src
> - - pll_u_480m
> - - clk_m
> - - pll_e
> -- resets: Must contain an entry for each entry in reset-names.
> - See ../reset/reset.txt for details.
> -- reset-names: Must include the following entries:
> - - xusb_host
> - - xusb_ss
> - - xusb_src
> - Note that xusb_src is the shared reset for xusb_{ss,hs,fs,falcon,host}_src.
> -- nvidia,xusb-padctl: phandle to the XUSB pad controller that is used to
> - configure the USB pads used by the XHCI controller
> -
> -For Tegra124 and Tegra132:
> -- avddio-pex-supply: PCIe/USB3 analog logic power supply. Must supply 1.05 V.
> -- dvddio-pex-supply: PCIe/USB3 digital logic power supply. Must supply 1.05 V.
> -- avdd-usb-supply: USB controller power supply. Must supply 3.3 V.
> -- avdd-pll-utmip-supply: UTMI PLL power supply. Must supply 1.8 V.
> -- avdd-pll-erefe-supply: PLLE reference PLL power supply. Must supply 1.05 V.
> -- avdd-usb-ss-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V.
> -- hvdd-usb-ss-supply: High-voltage PCIe/USB3 power supply. Must supply 3.3 V.
> -- hvdd-usb-ss-pll-e-supply: High-voltage PLLE power supply. Must supply 3.3 V.
> -
> -For Tegra210:
> -- dvddio-pex-supply: PCIe/USB3 analog logic power supply. Must supply 1.05 V.
> -- hvddio-pex-supply: High-voltage PCIe/USB3 power supply. Must supply 1.8 V.
> -- avdd-usb-supply: USB controller power supply. Must supply 3.3 V.
> -- avdd-pll-utmip-supply: UTMI PLL power supply. Must supply 1.8 V.
> -- avdd-pll-uerefe-supply: PLLE reference PLL power supply. Must supply 1.05 V.
> -- dvdd-pex-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V.
> -- hvdd-pex-pll-e-supply: High-voltage PLLE power supply. Must supply 1.8 V.
> -
> -For Tegra210 and Tegra186:
> -- power-domains: A list of PM domain specifiers that reference each power-domain
> - used by the xHCI controller. This list must comprise of a specifier for the
> - XUSBA and XUSBC power-domains. See ../power/power_domain.txt and
> - ../arm/tegra/nvidia,tegra20-pmc.txt for details.
> -- power-domain-names: A list of names that represent each of the specifiers in
> - the 'power-domains' property. Must include 'xusb_ss' and 'xusb_host' which
> - represent the power-domains XUSBA and XUSBC, respectively. See
> - ../power/power_domain.txt for details.
> -
> -Optional properties:
> ---------------------
> -- phys: Must contain an entry for each entry in phy-names.
> - See ../phy/phy-bindings.txt for details.
> -- phy-names: Should include an entry for each PHY used by the controller. The
> - following PHYs are available:
> - - Tegra124: usb2-0, usb2-1, usb2-2, hsic-0, hsic-1, usb3-0, usb3-1
> - - Tegra132: usb2-0, usb2-1, usb2-2, hsic-0, hsic-1, usb3-0, usb3-1
> - - Tegra210: usb2-0, usb2-1, usb2-2, usb2-3, hsic-0, usb3-0, usb3-1, usb3-2,
> - usb3-3
> - - Tegra186: usb2-0, usb2-1, usb2-2, hsic-0, usb3-0, usb3-1, usb3-2
> -
> -Example:
> ---------
> -
> - usb@0,70090000 {
> - compatible = "nvidia,tegra124-xusb";
> - reg = <0x0 0x70090000 0x0 0x8000>,
> - <0x0 0x70098000 0x0 0x1000>,
> - <0x0 0x70099000 0x0 0x1000>;
> - reg-names = "hcd", "fpci", "ipfs";
> -
> - interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
> -
> - clocks = <&tegra_car TEGRA124_CLK_XUSB_HOST>,
> - <&tegra_car TEGRA124_CLK_XUSB_HOST_SRC>,
> - <&tegra_car TEGRA124_CLK_XUSB_FALCON_SRC>,
> - <&tegra_car TEGRA124_CLK_XUSB_SS>,
> - <&tegra_car TEGRA124_CLK_XUSB_SS_DIV2>,
> - <&tegra_car TEGRA124_CLK_XUSB_SS_SRC>,
> - <&tegra_car TEGRA124_CLK_XUSB_HS_SRC>,
> - <&tegra_car TEGRA124_CLK_XUSB_FS_SRC>,
> - <&tegra_car TEGRA124_CLK_PLL_U_480M>,
> - <&tegra_car TEGRA124_CLK_CLK_M>,
> - <&tegra_car TEGRA124_CLK_PLL_E>;
> - clock-names = "xusb_host", "xusb_host_src", "xusb_falcon_src",
> - "xusb_ss", "xusb_ss_div2", "xusb_ss_src",
> - "xusb_hs_src", "xusb_fs_src", "pll_u_480m",
> - "clk_m", "pll_e";
> - resets = <&tegra_car 89>, <&tegra_car 156>, <&tegra_car 143>;
> - reset-names = "xusb_host", "xusb_ss", "xusb_src";
> -
> - nvidia,xusb-padctl = <&padctl>;
> -
> - phys = <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-1}>, /* mini-PCIe USB */
> - <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-2}>, /* USB A */
> - <&{/padctl@0,7009f000/pads/pcie/lanes/pcie-0}>; /* USB A */
> - phy-names = "usb2-1", "usb2-2", "usb3-0";
> -
> - avddio-pex-supply = <&vdd_1v05_run>;
> - dvddio-pex-supply = <&vdd_1v05_run>;
> - avdd-usb-supply = <&vdd_3v3_lp0>;
> - avdd-pll-utmip-supply = <&vddio_1v8>;
> - avdd-pll-erefe-supply = <&avdd_1v05_run>;
> - avdd-usb-ss-pll-supply = <&vdd_1v05_run>;
> - hvdd-usb-ss-supply = <&vdd_3v3_lp0>;
> - hvdd-usb-ss-pll-e-supply = <&vdd_3v3_lp0>;
> - };
> diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.yaml
> new file mode 100644
> index 000000000000..4a6616bf9bab
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.yaml
> @@ -0,0 +1,202 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/nvidia,tegra124-xusb.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NVIDIA Tegra124 xHCI controller
> +
> +maintainers:
> + - Thierry Reding <thierry.reding@gmail.com>
> + - Jon Hunter <jonathanh@nvidia.com>
> +
> +description: The Tegra xHCI controller supports both USB2 and USB3 interfaces
> + exposed by the Tegra XUSB pad controller.
> +
> +properties:
> + # required
> + compatible:
> + oneOf:
> + - description: NVIDIA Tegra124
> + const: nvidia,tegra124-xusb
> +
> + - description: NVIDIA Tegra132
> + items:
> + - const: nvidia,tegra132-xusb
> + - const: nvidia,tegra124-xusb
> +
> + reg:
> + items:
> + - description: base and length of the xHCI host registers
> + - description: base and length of the XUSB FPCI registers
> + - description: base and length of the XUSB IPFS registers
> +
> + reg-names:
> + items:
> + - const: hcd
> + - const: fpci
> + - const: ipfs
> +
> + interrupts:
> + items:
> + - description: xHCI host interrupt
> + - description: mailbox interrupt
> +
> + clocks:
> + items:
> + - description: XUSB host clock
> + - description: XUSB host source clock
> + - description: XUSB Falcon source clock
> + - description: XUSB SuperSpeed clock
> + - description: XUSB SuperSpeed clock divider
> + - description: XUSB SuperSpeed source clock
> + - description: XUSB HighSpeed clock source
> + - description: XUSB FullSpeed clock source
> + - description: USB PLL
> + - description: reference clock
> + - description: I/O PLL
> +
> + clock-names:
> + items:
> + - const: xusb_host
> + - const: xusb_host_src
> + - const: xusb_falcon_src
> + - const: xusb_ss
> + - const: xusb_ss_div2
> + - const: xusb_ss_src
> + - const: xusb_hs_src
> + - const: xusb_fs_src
> + - const: pll_u_480m
> + - const: clk_m
> + - const: pll_e
> +
> + resets:
> + items:
> + - description: reset for the XUSB host controller
> + - description: reset for the SuperSpeed logic
> + - description: shared reset for xusb_{ss,hs,fs,falcon,host}_src.
> +
> + reset-names:
> + items:
> + - const: xusb_host
> + - const: xusb_ss
> + - const: xusb_src
> +
> + nvidia,xusb-padctl:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: phandle to the XUSB pad controller that is used to configure
> + the USB pads used by the XHCI controller
> +
> + # optional
> + phys:
> + minItems: 1
> + maxItems: 7
> +
> + phy-names:
> + minItems: 1
> + maxItems: 7
> + items:
> + enum:
> + - usb2-0
> + - usb2-1
> + - usb2-2
> + - hsic-0
> + - hsic-1
> + - usb3-0
> + - usb3-1
> +
> + avddio-pex-supply:
> + description: PCIe/USB3 analog logic power supply. Must supply 1.05 V.
> +
> + dvddio-pex-supply:
> + description: PCIe/USB3 digital logic power supply. Must supply 1.05 V.
> +
> + avdd-usb-supply:
> + description: USB controller power supply. Must supply 3.3 V.
> +
> + avdd-pll-utmip-supply:
> + description: UTMI PLL power supply. Must supply 1.8 V.
> +
> + avdd-pll-erefe-supply:
> + description: PLLE reference PLL power supply. Must supply 1.05 V.
> +
> + avdd-usb-ss-pll-supply:
> + description: PCIe/USB3 PLL power supply. Must supply 1.05 V.
> +
> + hvdd-usb-ss-supply:
> + description: High-voltage PCIe/USB3 power supply. Must supply 3.3 V.
> +
> + hvdd-usb-ss-pll-e-supply:
> + description: High-voltage PLLE power supply. Must supply 3.3 V.
> +
> +allOf:
> + - $ref: usb-xhci.yaml
> +
> +unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - reg-names
> + - interrupts
> + - clocks
> + - clock-names
> + - resets
> + - reset-names
> + - nvidia,xusb-padctl
> + - phys
> + - phy-names
> + - avddio-pex-supply
> + - dvddio-pex-supply
> + - avdd-usb-supply
> + - hvdd-usb-ss-supply
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/tegra124-car.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + usb@70090000 {
> + compatible = "nvidia,tegra124-xusb";
> + reg = <0x70090000 0x8000>,
> + <0x70098000 0x1000>,
> + <0x70099000 0x1000>;
> + reg-names = "hcd", "fpci", "ipfs";
> +
> + interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
> +
> + clocks = <&tegra_car TEGRA124_CLK_XUSB_HOST>,
> + <&tegra_car TEGRA124_CLK_XUSB_HOST_SRC>,
> + <&tegra_car TEGRA124_CLK_XUSB_FALCON_SRC>,
> + <&tegra_car TEGRA124_CLK_XUSB_SS>,
> + <&tegra_car TEGRA124_CLK_XUSB_SS_DIV2>,
> + <&tegra_car TEGRA124_CLK_XUSB_SS_SRC>,
> + <&tegra_car TEGRA124_CLK_XUSB_HS_SRC>,
> + <&tegra_car TEGRA124_CLK_XUSB_FS_SRC>,
> + <&tegra_car TEGRA124_CLK_PLL_U_480M>,
> + <&tegra_car TEGRA124_CLK_CLK_M>,
> + <&tegra_car TEGRA124_CLK_PLL_E>;
> + clock-names = "xusb_host", "xusb_host_src", "xusb_falcon_src",
> + "xusb_ss", "xusb_ss_div2", "xusb_ss_src",
> + "xusb_hs_src", "xusb_fs_src", "pll_u_480m",
> + "clk_m", "pll_e";
> + resets = <&tegra_car 89>, <&tegra_car 156>, <&tegra_car 143>;
> + reset-names = "xusb_host", "xusb_ss", "xusb_src";
> +
> + nvidia,xusb-padctl = <&padctl>;
> +
> + phys = <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-1}>, /* mini-PCIe USB */
> + <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-2}>, /* USB A */
> + <&{/padctl@0,7009f000/pads/pcie/lanes/pcie-0}>; /* USB A */
> + phy-names = "usb2-1", "usb2-2", "usb3-0";
> +
> + avddio-pex-supply = <&vdd_1v05_run>;
> + dvddio-pex-supply = <&vdd_1v05_run>;
> + avdd-usb-supply = <&vdd_3v3_lp0>;
> + avdd-pll-utmip-supply = <&vddio_1v8>;
> + avdd-pll-erefe-supply = <&avdd_1v05_run>;
> + avdd-usb-ss-pll-supply = <&vdd_1v05_run>;
> + hvdd-usb-ss-supply = <&vdd_3v3_lp0>;
> + hvdd-usb-ss-pll-e-supply = <&vdd_3v3_lp0>;
> + };
> diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.yaml
> new file mode 100644
> index 000000000000..7126d137133a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.yaml
> @@ -0,0 +1,181 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/nvidia,tegra186-xusb.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NVIDIA Tegra186 xHCI controller
> +
> +maintainers:
> + - Thierry Reding <thierry.reding@gmail.com>
> + - Jon Hunter <jonathanh@nvidia.com>
> +
> +description: The Tegra xHCI controller supports both USB2 and USB3 interfaces
> + exposed by the Tegra XUSB pad controller.
> +
> +properties:
> + compatible:
> + const: nvidia,tegra186-xusb
> +
> + reg:
> + items:
> + - description: base and length of the xHCI host registers
> + - description: base and length of the XUSB FPCI registers
> +
> + reg-names:
> + items:
> + - const: hcd
> + - const: fpci
> +
> + interrupts:
> + items:
> + - description: xHCI host interrupt
> + - description: mailbox interrupt
> +
> + clocks:
> + items:
> + - description: XUSB host clock
> + - description: XUSB Falcon source clock
> + - description: XUSB SuperSpeed clock
> + - description: XUSB SuperSpeed source clock
> + - description: XUSB HighSpeed clock source
> + - description: XUSB FullSpeed clock source
> + - description: USB PLL
> + - description: reference clock
> + - description: I/O PLL
> +
> + clock-names:
> + items:
> + - const: xusb_host
> + - const: xusb_falcon_src
> + - const: xusb_ss
> + - const: xusb_ss_src
> + - const: xusb_hs_src
> + - const: xusb_fs_src
> + - const: pll_u_480m
> + - const: clk_m
> + - const: pll_e
> +
> + interconnects:
> + items:
> + - description: read client
> + - description: write client
> +
> + interconnect-names:
> + items:
> + - const: dma-mem # read
> + - const: write
> +
> + iommus:
> + maxItems: 1
> +
> + nvidia,xusb-padctl:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: phandle to the XUSB pad controller that is used to configure
> + the USB pads used by the XHCI controller
> +
> + phys:
> + minItems: 1
> + maxItems: 7
> +
> + phy-names:
> + minItems: 1
> + maxItems: 7
> + items:
> + enum:
> + - usb2-0
> + - usb2-1
> + - usb2-2
> + - hsic-0
> + - usb3-0
> + - usb3-1
> + - usb3-2
> +
> + power-domains:
> + description: A list of PM domain specifiers that reference each power-
> + domain used by the xHCI controller. This list must comprise of a
> + specifier for the XUSBA and XUSBC power-domains.
> +
> + See ../power/power_domain.txt and ../arm/tegra/nvidia,tegra20-pmc.txt
> + for details.
Drop description.
> + items:
> + - description: XUSBC power domain
> + - description: XUSBA power domain
> +
> + power-domain-names:
> + description: A list of names that represent each of the specifiers in the
> + 'power-domains' property. See ../power/power_domain.txt for details.
ditto
And the same elsewhere.
> + items:
> + - const: xusb_host
> + - const: xusb_ss
host/XUSBC and ss/XUSBA don't really correlate. It's all supposed to be
named relative to the device rather than top-level/source/provider.
You're stuck with the host/ss names, so maybe improve the descriptions.
With those fixes,
Reviewed-by: Rob Herring <robh@kernel.org>
Rob
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dt-bindings: usb: tegra-xusb: Convert to json-schema
2022-11-07 19:52 ` Rob Herring
@ 2022-11-18 12:25 ` Thierry Reding
0 siblings, 0 replies; 7+ messages in thread
From: Thierry Reding @ 2022-11-18 12:25 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Greg Kroah-Hartman, Jon Hunter, Wayne Chang,
devicetree, linux-usb, linux-tegra
[-- Attachment #1: Type: text/plain, Size: 19962 bytes --]
On Mon, Nov 07, 2022 at 01:52:21PM -0600, Rob Herring wrote:
> On Thu, Nov 03, 2022 at 03:42:00PM +0100, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Convert the Tegra XUSB controller bindings from the free-form text
> > format to json-schema.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> > Wayne, going forward it might make sense for you to pick this up into
> > your Tegra234 series and add the Tegra234 bindings on top of this.
> >
> > Changes in v2:
> > - use minItems/maxItems/items instead of contains/anyOf for phy-names
> > - add missing compatible string to USB device example
> > - drop unneeded phys property description
> > - drop unneeded USB bus properties
> > - add reference to usb-xhci.yaml
> >
> > .../bindings/usb/nvidia,tegra124-xusb.txt | 132 -----------
> > .../bindings/usb/nvidia,tegra124-xusb.yaml | 202 +++++++++++++++++
> > .../bindings/usb/nvidia,tegra186-xusb.yaml | 181 +++++++++++++++
> > .../bindings/usb/nvidia,tegra194-xusb.yaml | 187 ++++++++++++++++
> > .../bindings/usb/nvidia,tegra210-xusb.yaml | 207 ++++++++++++++++++
> > 5 files changed, 777 insertions(+), 132 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
> > create mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.yaml
> > create mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.yaml
> > create mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra194-xusb.yaml
> > create mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra210-xusb.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
> > deleted file mode 100644
> > index 5bfcc0b4d6b9..000000000000
> > --- a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
> > +++ /dev/null
> > @@ -1,132 +0,0 @@
> > -NVIDIA Tegra xHCI controller
> > -============================
> > -
> > -The Tegra xHCI controller supports both USB2 and USB3 interfaces exposed by
> > -the Tegra XUSB pad controller.
> > -
> > -Required properties:
> > ---------------------
> > -- compatible: Must be:
> > - - Tegra124: "nvidia,tegra124-xusb"
> > - - Tegra132: "nvidia,tegra132-xusb", "nvidia,tegra124-xusb"
> > - - Tegra210: "nvidia,tegra210-xusb"
> > - - Tegra186: "nvidia,tegra186-xusb"
> > -- reg: Must contain the base and length of the xHCI host registers, XUSB FPCI
> > - registers and XUSB IPFS registers.
> > -- reg-names: Must contain the following entries:
> > - - "hcd"
> > - - "fpci"
> > - - "ipfs"
> > -- interrupts: Must contain the xHCI host interrupt and the mailbox interrupt.
> > -- clocks: Must contain an entry for each entry in clock-names.
> > - See ../clock/clock-bindings.txt for details.
> > -- clock-names: Must include the following entries:
> > - - xusb_host
> > - - xusb_host_src
> > - - xusb_falcon_src
> > - - xusb_ss
> > - - xusb_ss_src
> > - - xusb_ss_div2
> > - - xusb_hs_src
> > - - xusb_fs_src
> > - - pll_u_480m
> > - - clk_m
> > - - pll_e
> > -- resets: Must contain an entry for each entry in reset-names.
> > - See ../reset/reset.txt for details.
> > -- reset-names: Must include the following entries:
> > - - xusb_host
> > - - xusb_ss
> > - - xusb_src
> > - Note that xusb_src is the shared reset for xusb_{ss,hs,fs,falcon,host}_src.
> > -- nvidia,xusb-padctl: phandle to the XUSB pad controller that is used to
> > - configure the USB pads used by the XHCI controller
> > -
> > -For Tegra124 and Tegra132:
> > -- avddio-pex-supply: PCIe/USB3 analog logic power supply. Must supply 1.05 V.
> > -- dvddio-pex-supply: PCIe/USB3 digital logic power supply. Must supply 1.05 V.
> > -- avdd-usb-supply: USB controller power supply. Must supply 3.3 V.
> > -- avdd-pll-utmip-supply: UTMI PLL power supply. Must supply 1.8 V.
> > -- avdd-pll-erefe-supply: PLLE reference PLL power supply. Must supply 1.05 V.
> > -- avdd-usb-ss-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V.
> > -- hvdd-usb-ss-supply: High-voltage PCIe/USB3 power supply. Must supply 3.3 V.
> > -- hvdd-usb-ss-pll-e-supply: High-voltage PLLE power supply. Must supply 3.3 V.
> > -
> > -For Tegra210:
> > -- dvddio-pex-supply: PCIe/USB3 analog logic power supply. Must supply 1.05 V.
> > -- hvddio-pex-supply: High-voltage PCIe/USB3 power supply. Must supply 1.8 V.
> > -- avdd-usb-supply: USB controller power supply. Must supply 3.3 V.
> > -- avdd-pll-utmip-supply: UTMI PLL power supply. Must supply 1.8 V.
> > -- avdd-pll-uerefe-supply: PLLE reference PLL power supply. Must supply 1.05 V.
> > -- dvdd-pex-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V.
> > -- hvdd-pex-pll-e-supply: High-voltage PLLE power supply. Must supply 1.8 V.
> > -
> > -For Tegra210 and Tegra186:
> > -- power-domains: A list of PM domain specifiers that reference each power-domain
> > - used by the xHCI controller. This list must comprise of a specifier for the
> > - XUSBA and XUSBC power-domains. See ../power/power_domain.txt and
> > - ../arm/tegra/nvidia,tegra20-pmc.txt for details.
> > -- power-domain-names: A list of names that represent each of the specifiers in
> > - the 'power-domains' property. Must include 'xusb_ss' and 'xusb_host' which
> > - represent the power-domains XUSBA and XUSBC, respectively. See
> > - ../power/power_domain.txt for details.
> > -
> > -Optional properties:
> > ---------------------
> > -- phys: Must contain an entry for each entry in phy-names.
> > - See ../phy/phy-bindings.txt for details.
> > -- phy-names: Should include an entry for each PHY used by the controller. The
> > - following PHYs are available:
> > - - Tegra124: usb2-0, usb2-1, usb2-2, hsic-0, hsic-1, usb3-0, usb3-1
> > - - Tegra132: usb2-0, usb2-1, usb2-2, hsic-0, hsic-1, usb3-0, usb3-1
> > - - Tegra210: usb2-0, usb2-1, usb2-2, usb2-3, hsic-0, usb3-0, usb3-1, usb3-2,
> > - usb3-3
> > - - Tegra186: usb2-0, usb2-1, usb2-2, hsic-0, usb3-0, usb3-1, usb3-2
> > -
> > -Example:
> > ---------
> > -
> > - usb@0,70090000 {
> > - compatible = "nvidia,tegra124-xusb";
> > - reg = <0x0 0x70090000 0x0 0x8000>,
> > - <0x0 0x70098000 0x0 0x1000>,
> > - <0x0 0x70099000 0x0 0x1000>;
> > - reg-names = "hcd", "fpci", "ipfs";
> > -
> > - interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
> > - <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
> > -
> > - clocks = <&tegra_car TEGRA124_CLK_XUSB_HOST>,
> > - <&tegra_car TEGRA124_CLK_XUSB_HOST_SRC>,
> > - <&tegra_car TEGRA124_CLK_XUSB_FALCON_SRC>,
> > - <&tegra_car TEGRA124_CLK_XUSB_SS>,
> > - <&tegra_car TEGRA124_CLK_XUSB_SS_DIV2>,
> > - <&tegra_car TEGRA124_CLK_XUSB_SS_SRC>,
> > - <&tegra_car TEGRA124_CLK_XUSB_HS_SRC>,
> > - <&tegra_car TEGRA124_CLK_XUSB_FS_SRC>,
> > - <&tegra_car TEGRA124_CLK_PLL_U_480M>,
> > - <&tegra_car TEGRA124_CLK_CLK_M>,
> > - <&tegra_car TEGRA124_CLK_PLL_E>;
> > - clock-names = "xusb_host", "xusb_host_src", "xusb_falcon_src",
> > - "xusb_ss", "xusb_ss_div2", "xusb_ss_src",
> > - "xusb_hs_src", "xusb_fs_src", "pll_u_480m",
> > - "clk_m", "pll_e";
> > - resets = <&tegra_car 89>, <&tegra_car 156>, <&tegra_car 143>;
> > - reset-names = "xusb_host", "xusb_ss", "xusb_src";
> > -
> > - nvidia,xusb-padctl = <&padctl>;
> > -
> > - phys = <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-1}>, /* mini-PCIe USB */
> > - <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-2}>, /* USB A */
> > - <&{/padctl@0,7009f000/pads/pcie/lanes/pcie-0}>; /* USB A */
> > - phy-names = "usb2-1", "usb2-2", "usb3-0";
> > -
> > - avddio-pex-supply = <&vdd_1v05_run>;
> > - dvddio-pex-supply = <&vdd_1v05_run>;
> > - avdd-usb-supply = <&vdd_3v3_lp0>;
> > - avdd-pll-utmip-supply = <&vddio_1v8>;
> > - avdd-pll-erefe-supply = <&avdd_1v05_run>;
> > - avdd-usb-ss-pll-supply = <&vdd_1v05_run>;
> > - hvdd-usb-ss-supply = <&vdd_3v3_lp0>;
> > - hvdd-usb-ss-pll-e-supply = <&vdd_3v3_lp0>;
> > - };
> > diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.yaml
> > new file mode 100644
> > index 000000000000..4a6616bf9bab
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.yaml
> > @@ -0,0 +1,202 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/usb/nvidia,tegra124-xusb.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: NVIDIA Tegra124 xHCI controller
> > +
> > +maintainers:
> > + - Thierry Reding <thierry.reding@gmail.com>
> > + - Jon Hunter <jonathanh@nvidia.com>
> > +
> > +description: The Tegra xHCI controller supports both USB2 and USB3 interfaces
> > + exposed by the Tegra XUSB pad controller.
> > +
> > +properties:
> > + # required
> > + compatible:
> > + oneOf:
> > + - description: NVIDIA Tegra124
> > + const: nvidia,tegra124-xusb
> > +
> > + - description: NVIDIA Tegra132
> > + items:
> > + - const: nvidia,tegra132-xusb
> > + - const: nvidia,tegra124-xusb
> > +
> > + reg:
> > + items:
> > + - description: base and length of the xHCI host registers
> > + - description: base and length of the XUSB FPCI registers
> > + - description: base and length of the XUSB IPFS registers
> > +
> > + reg-names:
> > + items:
> > + - const: hcd
> > + - const: fpci
> > + - const: ipfs
> > +
> > + interrupts:
> > + items:
> > + - description: xHCI host interrupt
> > + - description: mailbox interrupt
> > +
> > + clocks:
> > + items:
> > + - description: XUSB host clock
> > + - description: XUSB host source clock
> > + - description: XUSB Falcon source clock
> > + - description: XUSB SuperSpeed clock
> > + - description: XUSB SuperSpeed clock divider
> > + - description: XUSB SuperSpeed source clock
> > + - description: XUSB HighSpeed clock source
> > + - description: XUSB FullSpeed clock source
> > + - description: USB PLL
> > + - description: reference clock
> > + - description: I/O PLL
> > +
> > + clock-names:
> > + items:
> > + - const: xusb_host
> > + - const: xusb_host_src
> > + - const: xusb_falcon_src
> > + - const: xusb_ss
> > + - const: xusb_ss_div2
> > + - const: xusb_ss_src
> > + - const: xusb_hs_src
> > + - const: xusb_fs_src
> > + - const: pll_u_480m
> > + - const: clk_m
> > + - const: pll_e
> > +
> > + resets:
> > + items:
> > + - description: reset for the XUSB host controller
> > + - description: reset for the SuperSpeed logic
> > + - description: shared reset for xusb_{ss,hs,fs,falcon,host}_src.
> > +
> > + reset-names:
> > + items:
> > + - const: xusb_host
> > + - const: xusb_ss
> > + - const: xusb_src
> > +
> > + nvidia,xusb-padctl:
> > + $ref: /schemas/types.yaml#/definitions/phandle
> > + description: phandle to the XUSB pad controller that is used to configure
> > + the USB pads used by the XHCI controller
> > +
> > + # optional
> > + phys:
> > + minItems: 1
> > + maxItems: 7
> > +
> > + phy-names:
> > + minItems: 1
> > + maxItems: 7
> > + items:
> > + enum:
> > + - usb2-0
> > + - usb2-1
> > + - usb2-2
> > + - hsic-0
> > + - hsic-1
> > + - usb3-0
> > + - usb3-1
> > +
> > + avddio-pex-supply:
> > + description: PCIe/USB3 analog logic power supply. Must supply 1.05 V.
> > +
> > + dvddio-pex-supply:
> > + description: PCIe/USB3 digital logic power supply. Must supply 1.05 V.
> > +
> > + avdd-usb-supply:
> > + description: USB controller power supply. Must supply 3.3 V.
> > +
> > + avdd-pll-utmip-supply:
> > + description: UTMI PLL power supply. Must supply 1.8 V.
> > +
> > + avdd-pll-erefe-supply:
> > + description: PLLE reference PLL power supply. Must supply 1.05 V.
> > +
> > + avdd-usb-ss-pll-supply:
> > + description: PCIe/USB3 PLL power supply. Must supply 1.05 V.
> > +
> > + hvdd-usb-ss-supply:
> > + description: High-voltage PCIe/USB3 power supply. Must supply 3.3 V.
> > +
> > + hvdd-usb-ss-pll-e-supply:
> > + description: High-voltage PLLE power supply. Must supply 3.3 V.
> > +
> > +allOf:
> > + - $ref: usb-xhci.yaml
> > +
> > +unevaluatedProperties: false
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - reg-names
> > + - interrupts
> > + - clocks
> > + - clock-names
> > + - resets
> > + - reset-names
> > + - nvidia,xusb-padctl
> > + - phys
> > + - phy-names
> > + - avddio-pex-supply
> > + - dvddio-pex-supply
> > + - avdd-usb-supply
> > + - hvdd-usb-ss-supply
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/clock/tegra124-car.h>
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > + usb@70090000 {
> > + compatible = "nvidia,tegra124-xusb";
> > + reg = <0x70090000 0x8000>,
> > + <0x70098000 0x1000>,
> > + <0x70099000 0x1000>;
> > + reg-names = "hcd", "fpci", "ipfs";
> > +
> > + interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
> > +
> > + clocks = <&tegra_car TEGRA124_CLK_XUSB_HOST>,
> > + <&tegra_car TEGRA124_CLK_XUSB_HOST_SRC>,
> > + <&tegra_car TEGRA124_CLK_XUSB_FALCON_SRC>,
> > + <&tegra_car TEGRA124_CLK_XUSB_SS>,
> > + <&tegra_car TEGRA124_CLK_XUSB_SS_DIV2>,
> > + <&tegra_car TEGRA124_CLK_XUSB_SS_SRC>,
> > + <&tegra_car TEGRA124_CLK_XUSB_HS_SRC>,
> > + <&tegra_car TEGRA124_CLK_XUSB_FS_SRC>,
> > + <&tegra_car TEGRA124_CLK_PLL_U_480M>,
> > + <&tegra_car TEGRA124_CLK_CLK_M>,
> > + <&tegra_car TEGRA124_CLK_PLL_E>;
> > + clock-names = "xusb_host", "xusb_host_src", "xusb_falcon_src",
> > + "xusb_ss", "xusb_ss_div2", "xusb_ss_src",
> > + "xusb_hs_src", "xusb_fs_src", "pll_u_480m",
> > + "clk_m", "pll_e";
> > + resets = <&tegra_car 89>, <&tegra_car 156>, <&tegra_car 143>;
> > + reset-names = "xusb_host", "xusb_ss", "xusb_src";
> > +
> > + nvidia,xusb-padctl = <&padctl>;
> > +
> > + phys = <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-1}>, /* mini-PCIe USB */
> > + <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-2}>, /* USB A */
> > + <&{/padctl@0,7009f000/pads/pcie/lanes/pcie-0}>; /* USB A */
> > + phy-names = "usb2-1", "usb2-2", "usb3-0";
> > +
> > + avddio-pex-supply = <&vdd_1v05_run>;
> > + dvddio-pex-supply = <&vdd_1v05_run>;
> > + avdd-usb-supply = <&vdd_3v3_lp0>;
> > + avdd-pll-utmip-supply = <&vddio_1v8>;
> > + avdd-pll-erefe-supply = <&avdd_1v05_run>;
> > + avdd-usb-ss-pll-supply = <&vdd_1v05_run>;
> > + hvdd-usb-ss-supply = <&vdd_3v3_lp0>;
> > + hvdd-usb-ss-pll-e-supply = <&vdd_3v3_lp0>;
> > + };
> > diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.yaml
> > new file mode 100644
> > index 000000000000..7126d137133a
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.yaml
> > @@ -0,0 +1,181 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/usb/nvidia,tegra186-xusb.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: NVIDIA Tegra186 xHCI controller
> > +
> > +maintainers:
> > + - Thierry Reding <thierry.reding@gmail.com>
> > + - Jon Hunter <jonathanh@nvidia.com>
> > +
> > +description: The Tegra xHCI controller supports both USB2 and USB3 interfaces
> > + exposed by the Tegra XUSB pad controller.
> > +
> > +properties:
> > + compatible:
> > + const: nvidia,tegra186-xusb
> > +
> > + reg:
> > + items:
> > + - description: base and length of the xHCI host registers
> > + - description: base and length of the XUSB FPCI registers
> > +
> > + reg-names:
> > + items:
> > + - const: hcd
> > + - const: fpci
> > +
> > + interrupts:
> > + items:
> > + - description: xHCI host interrupt
> > + - description: mailbox interrupt
> > +
> > + clocks:
> > + items:
> > + - description: XUSB host clock
> > + - description: XUSB Falcon source clock
> > + - description: XUSB SuperSpeed clock
> > + - description: XUSB SuperSpeed source clock
> > + - description: XUSB HighSpeed clock source
> > + - description: XUSB FullSpeed clock source
> > + - description: USB PLL
> > + - description: reference clock
> > + - description: I/O PLL
> > +
> > + clock-names:
> > + items:
> > + - const: xusb_host
> > + - const: xusb_falcon_src
> > + - const: xusb_ss
> > + - const: xusb_ss_src
> > + - const: xusb_hs_src
> > + - const: xusb_fs_src
> > + - const: pll_u_480m
> > + - const: clk_m
> > + - const: pll_e
> > +
> > + interconnects:
> > + items:
> > + - description: read client
> > + - description: write client
> > +
> > + interconnect-names:
> > + items:
> > + - const: dma-mem # read
> > + - const: write
> > +
> > + iommus:
> > + maxItems: 1
> > +
> > + nvidia,xusb-padctl:
> > + $ref: /schemas/types.yaml#/definitions/phandle
> > + description: phandle to the XUSB pad controller that is used to configure
> > + the USB pads used by the XHCI controller
> > +
> > + phys:
> > + minItems: 1
> > + maxItems: 7
> > +
> > + phy-names:
> > + minItems: 1
> > + maxItems: 7
> > + items:
> > + enum:
> > + - usb2-0
> > + - usb2-1
> > + - usb2-2
> > + - hsic-0
> > + - usb3-0
> > + - usb3-1
> > + - usb3-2
> > +
> > + power-domains:
> > + description: A list of PM domain specifiers that reference each power-
> > + domain used by the xHCI controller. This list must comprise of a
> > + specifier for the XUSBA and XUSBC power-domains.
> > +
> > + See ../power/power_domain.txt and ../arm/tegra/nvidia,tegra20-pmc.txt
> > + for details.
>
> Drop description.
>
> > + items:
> > + - description: XUSBC power domain
> > + - description: XUSBA power domain
> > +
> > + power-domain-names:
> > + description: A list of names that represent each of the specifiers in the
> > + 'power-domains' property. See ../power/power_domain.txt for details.
>
> ditto
>
> And the same elsewhere.
All of these descriptions are now dropped.
>
> > + items:
> > + - const: xusb_host
> > + - const: xusb_ss
>
> host/XUSBC and ss/XUSBA don't really correlate. It's all supposed to be
> named relative to the device rather than top-level/source/provider.
> You're stuck with the host/ss names, so maybe improve the descriptions.
>
> With those fixes,
>
> Reviewed-by: Rob Herring <robh@kernel.org>
I've updated the descriptions to clarify that XUSBC is for host and USB
2.0 while XUSBA is for SuperSpeed.
I've picked this up into the Tegra tree with the above modifications.
Thanks,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dt-bindings: usb: tegra-xusb: Convert to json-schema
2022-11-03 14:42 [PATCH v2] dt-bindings: usb: tegra-xusb: Convert to json-schema Thierry Reding
2022-11-07 19:52 ` Rob Herring
@ 2022-11-25 12:41 ` Conor Dooley
2022-11-25 12:59 ` Conor Dooley
1 sibling, 1 reply; 7+ messages in thread
From: Conor Dooley @ 2022-11-25 12:41 UTC (permalink / raw)
To: Thierry Reding
Cc: Rob Herring, Krzysztof Kozlowski, Greg Kroah-Hartman, Jon Hunter,
Wayne Chang, devicetree, linux-usb, linux-tegra
Hi Thierry,
On Thu, Nov 03, 2022 at 03:42:00PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Convert the Tegra XUSB controller bindings from the free-form text
> format to json-schema.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> + phys = <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-1}>, /* mini-PCIe USB */
> + <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-2}>, /* USB A */
> + <&{/padctl@0,7009f000/pads/pcie/lanes/pcie-0}>; /* USB A */
This seems to be breaking dt_binding_check in today's linux-next:
FATAL ERROR: Can't generate fixup for reference to path &{/padctl@0,7009f000/pads/usb2/lanes/usb2-1}
Am I missing something? My dt-schema is today's main.
Thanks,
Conor.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dt-bindings: usb: tegra-xusb: Convert to json-schema
2022-11-25 12:41 ` Conor Dooley
@ 2022-11-25 12:59 ` Conor Dooley
2022-11-25 14:01 ` Conor Dooley
2022-11-27 16:38 ` Rob Herring
0 siblings, 2 replies; 7+ messages in thread
From: Conor Dooley @ 2022-11-25 12:59 UTC (permalink / raw)
To: Thierry Reding
Cc: Rob Herring, Krzysztof Kozlowski, Greg Kroah-Hartman, Jon Hunter,
Wayne Chang, devicetree, linux-usb, linux-tegra
On Fri, Nov 25, 2022 at 12:41:46PM +0000, Conor Dooley wrote:
> Hi Thierry,
>
> On Thu, Nov 03, 2022 at 03:42:00PM +0100, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Convert the Tegra XUSB controller bindings from the free-form text
> > format to json-schema.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
>
> > + phys = <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-1}>, /* mini-PCIe USB */
> > + <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-2}>, /* USB A */
> > + <&{/padctl@0,7009f000/pads/pcie/lanes/pcie-0}>; /* USB A */
>
> This seems to be breaking dt_binding_check in today's linux-next:
> FATAL ERROR: Can't generate fixup for reference to path &{/padctl@0,7009f000/pads/usb2/lanes/usb2-1}
>
> Am I missing something? My dt-schema is today's main.
Apologies for the noise, it appears to have broken several days ago and
is not caused by this patch.
I'll go bisect :)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dt-bindings: usb: tegra-xusb: Convert to json-schema
2022-11-25 12:59 ` Conor Dooley
@ 2022-11-25 14:01 ` Conor Dooley
2022-11-27 16:38 ` Rob Herring
1 sibling, 0 replies; 7+ messages in thread
From: Conor Dooley @ 2022-11-25 14:01 UTC (permalink / raw)
To: Thierry Reding, Rob Herring
Cc: Rob Herring, Krzysztof Kozlowski, Greg Kroah-Hartman, Jon Hunter,
Wayne Chang, devicetree, linux-usb, linux-tegra
On Fri, Nov 25, 2022 at 12:59:18PM +0000, Conor Dooley wrote:
> On Fri, Nov 25, 2022 at 12:41:46PM +0000, Conor Dooley wrote:
> > Hi Thierry,
> >
> > On Thu, Nov 03, 2022 at 03:42:00PM +0100, Thierry Reding wrote:
> > > From: Thierry Reding <treding@nvidia.com>
> > >
> > > Convert the Tegra XUSB controller bindings from the free-form text
> > > format to json-schema.
> > >
> > > Signed-off-by: Thierry Reding <treding@nvidia.com>
> >
> > > + phys = <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-1}>, /* mini-PCIe USB */
> > > + <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-2}>, /* USB A */
> > > + <&{/padctl@0,7009f000/pads/pcie/lanes/pcie-0}>; /* USB A */
> >
> > This seems to be breaking dt_binding_check in today's linux-next:
> > FATAL ERROR: Can't generate fixup for reference to path &{/padctl@0,7009f000/pads/usb2/lanes/usb2-1}
> >
> > Am I missing something? My dt-schema is today's main.
>
> Apologies for the noise, it appears to have broken several days ago and
> is not caused by this patch.
>
> I'll go bisect :)
ea3723a541c198c84e81a0e975dba6c18764393e is the first bad commit
> > commit ea3723a541c198c84e81a0e975dba6c18764393e
> > Author: Rob Herring <robh@kernel.org>
> > Date: Tue Nov 1 12:54:44 2022 -0500
> >
> > scripts/dtc: Update to upstream version v1.6.1-63-g55778a03df61
> >
> > It's been a while since the last sync and Lee needs commit 73590342fc85
> > ("libfdt: prevent integer overflow in fdt_next_tag").
> >
> > This adds the following commits from upstream:
> >
> > 55778a03df61 libfdt: tests: add get_next_tag_invalid_prop_len
> > 73590342fc85 libfdt: prevent integer overflow in fdt_next_tag
> > 035fb90d5375 libfdt: add fdt_get_property_by_offset_w helper
> > 98a07006c48d Makefile: fix infinite recursion by dropping non-existent `%.output`
> > a036cc7b0c10 Makefile: limit make re-execution to avoid infinite spin
> > c6e92108bcd9 libdtc: remove duplicate judgments
> > e37c25677dc9 Don't generate erroneous fixups from reference to path
I have not bisected the dtc, but this one seems like it could be the
culprit? Just going off the $subject, not looked at the content at
all...
> > 50454658f2b5 libfdt: Don't mask fdt_get_name() returned error
> > e64a204196c9 manual.txt: Follow README.md and remove Jon
> > f508c83fe6f0 Update README in MANIFEST.in and setup.py to README.md
> > c2ccf8a77dd2 Add description of Signed-off-by lines
> > 90b9d9de42ca Split out information for contributors to CONTRIBUTING.md
> > 0ee1d479b23a Remove Jon Loeliger from maintainers list
> > b33a73c62c1c Convert README to README.md
> > 7ad60734b1c1 Allow static building with meson
> > fd9b8c96c780 Allow static building with make
> > fda71da26e7f libfdt: Handle failed get_name() on BEGIN_NODE
> > c7c7f17a83d5 Fix test script to run also on dash shell
> > 01f23ffe1679 Add missing relref_merge test to meson test list
> > ed310803ea89 pylibfdt: add FdtRo.get_path()
> > c001fc01a43e pylibfdt: fix swig build in install
> > 26c54f840d23 tests: add test cases for label-relative path references
> > ec7986e682cf dtc: introduce label relative path references
> > 651410e54cb9 util: introduce xstrndup helper
> > 4048aed12b81 setup.py: fix out of tree build
> > ff5afb96d0c0 Handle integer overflow in check_property_phandle_args()
> > ca7294434309 README: Explain how to add a new API function
> > c0c2e115f82e Fix a UB when fdt_get_string return null
> > cd5f69cbc0d4 tests: setprop_inplace: use xstrdup instead of unchecked strdup
> > a04f69025003 pylibfdt: add Property.as_*int*_array()
> > 83102717d7c4 pylibfdt: add Property.as_stringlist()
> > d152126bb029 Fix Python crash on getprop deallocation
> > 17739b7ef510 Support 'r' format for printing raw bytes with fdtget
> > 45f3d1a095dd libfdt: overlay: make overlay_get_target() public
> > c19a4bafa514 libfdt: fix an incorrect integer promotion
> > 1cc41b1c969f pylibfdt: Add packaging metadata
> > db72398cd437 README: Update pylibfdt install instructions
> > 383e148b70a4 pylibfdt: fix with Python 3.10
> > 23b56cb7e189 pylibfdt: Move setup.py to the top level
> > 69a760747d8d pylibfdt: Split setup.py author name and email
> > 0b106a77dbdc pylibfdt: Use setuptools_scm for the version
> > c691776ddb26 pylibfdt: Use setuptools instead of distutils
> > 5216f3f1bbb7 libfdt: Add static lib to meson build
> > 4eda2590f481 CI: Cirrus: bump used FreeBSD from 12.1 to 13.0
> >
> > Link: https://lore.kernel.org/r/20221101181427.1808703-1-robh@kernel.org/
> > Signed-off-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dt-bindings: usb: tegra-xusb: Convert to json-schema
2022-11-25 12:59 ` Conor Dooley
2022-11-25 14:01 ` Conor Dooley
@ 2022-11-27 16:38 ` Rob Herring
1 sibling, 0 replies; 7+ messages in thread
From: Rob Herring @ 2022-11-27 16:38 UTC (permalink / raw)
To: Conor Dooley
Cc: Thierry Reding, Krzysztof Kozlowski, Greg Kroah-Hartman,
Jon Hunter, Wayne Chang, devicetree, linux-usb, linux-tegra
On Fri, Nov 25, 2022 at 6:59 AM Conor Dooley <conor.dooley@microchip.com> wrote:
>
> On Fri, Nov 25, 2022 at 12:41:46PM +0000, Conor Dooley wrote:
> > Hi Thierry,
> >
> > On Thu, Nov 03, 2022 at 03:42:00PM +0100, Thierry Reding wrote:
> > > From: Thierry Reding <treding@nvidia.com>
> > >
> > > Convert the Tegra XUSB controller bindings from the free-form text
> > > format to json-schema.
> > >
> > > Signed-off-by: Thierry Reding <treding@nvidia.com>
> >
> > > + phys = <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-1}>, /* mini-PCIe USB */
> > > + <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-2}>, /* USB A */
> > > + <&{/padctl@0,7009f000/pads/pcie/lanes/pcie-0}>; /* USB A */
> >
> > This seems to be breaking dt_binding_check in today's linux-next:
> > FATAL ERROR: Can't generate fixup for reference to path &{/padctl@0,7009f000/pads/usb2/lanes/usb2-1}
> >
> > Am I missing something? My dt-schema is today's main.
>
> Apologies for the noise, it appears to have broken several days ago and
> is not caused by this patch.
>
> I'll go bisect :)
Yes, the above unresolvable paths need to be fixed (to labels). The
examples are built as overlays so that unresolved labels are allowed,
but dtc now checks for unresolved paths.
Rob
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-11-27 16:38 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-03 14:42 [PATCH v2] dt-bindings: usb: tegra-xusb: Convert to json-schema Thierry Reding
2022-11-07 19:52 ` Rob Herring
2022-11-18 12:25 ` Thierry Reding
2022-11-25 12:41 ` Conor Dooley
2022-11-25 12:59 ` Conor Dooley
2022-11-25 14:01 ` Conor Dooley
2022-11-27 16:38 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).