From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Krzysztof Wilczyński" <kw@linux.com>,
"Miaoqian Lin" <linmq006@gmail.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-pci@vger.kernel.org,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jisheng Zhang" <jszhang@kernel.org>,
"Toan Le" <toan@os.amperecomputing.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Rob Herring" <robh@kernel.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
linux-rockchip@lists.infradead.org,
"Joyce Ooi" <joyce.ooi@intel.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Jianjun Wang" <jianjun.wang@mediatek.com>,
"Sergio Paracuellos" <sergio.paracuellos@gmail.com>,
"Rahul Tanwar" <rtanwar@maxlinear.com>,
"Jim Quinlan" <jim2101024@gmail.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
linux-arm-msm@vger.kernel.org,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Nicolas Saenz Julienne" <nsaenz@kernel.org>,
linux-tegra@vger.kernel.org, kernel@pengutronix.de,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Ray Jui" <rjui@broadcom.com>,
"Ryder Lee" <ryder.lee@mediatek.com>,
linux-mediatek@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Vidya Sagar" <vidyas@nvidia.com>,
"Serge Semin" <Sergey.Semin@baikalelectronics.ru>,
"Tom Joseph" <tjoseph@cadence.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Shawn Guo" <shawn.guo@linaro.org>,
"Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH 00/15] PCI: Convert to platform remove callback returning void
Date: Tue, 6 Jun 2023 18:02:34 +0200 [thread overview]
Message-ID: <20230606160234.elcvyqlz2j3mggih@pengutronix.de> (raw)
In-Reply-To: <ZHphHkNLO4tEJIm/@bhelgaas>
[-- Attachment #1: Type: text/plain, Size: 2641 bytes --]
Hello,
[dropped Tom Joseph and Joyce Ooi from Cc:, my last mail in this thread
resulted in a bounce for their addresses.]
On Fri, Jun 02, 2023 at 04:37:34PM -0500, Bjorn Helgaas wrote:
> On Tue, May 30, 2023 at 04:07:42PM +0200, Uwe Kleine-König wrote:
> > Hello Bjorn,
> >
> > On Tue, Mar 21, 2023 at 08:31:53PM +0100, Uwe Kleine-König wrote:
> > > this series adapts the platform drivers below drivers/pci to use the
> > > .remove_new() callback. Compared to the traditional .remove() callback
> > > .remove_new() returns no value. This is a good thing because the driver core
> > > doesn't (and cannot) cope for errors during remove. The only effect of a
> > > non-zero return value in .remove() is that the driver core emits a warning. The
> > > device is removed anyhow and an early return from .remove() usually yields a
> > > resource leak.
> > >
> > > By changing the remove callback to return void driver authors cannot
> > > reasonably assume any more that there is some kind of cleanup later.
> > >
> > > All drivers were easy to convert as they all returned zero in their
> > > remove callback. Only for iproc the conversion wasn't trivial, the other
> > > were converted using coccinelle.
> > >
> > > There are no interdependencies between these patches. So even if there
> > > are some concerns for individual patches, I ask you to apply the
> > > remaining set. Then I only have to care for the review feedback of the
> > > refused patches. (Having said that I don't expect any serious objection,
> > > just things like squashing or separating patches, or maybe I picked a
> > > wrong subject prefix.)
> >
> > These patches wait for application for quite some time now. They apply
> > just fine to v6.4-rc1 and next/master. Would be great to get them in
> > during the next merge window and ideally give them some time in next
> > before.
>
> Thanks, these seem fine to me, and Lorenzo normally takes care of
> drivers/pci/controller/. Lorenzo, if it's easier to have me apply
> them, that's fine, too, just let me know.
>
> The only tweaks I would make would be:
>
> PCI: j721e: Convert to platform remove callback returning void
> PCI: dwc: Convert to platform remove callback returning void
If it's easier for you (or Lorenzo) I can resend with these tweaks.
Otherwise if these are adapted when applying them, that's fine for me,
too. Just tell me if I should do anything here.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-06-06 16:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 19:31 [PATCH 00/15] PCI: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-21 19:31 ` [PATCH 06/15] PCI: dwc/*: " Uwe Kleine-König
2023-03-22 18:06 ` Serge Semin
2023-03-21 19:32 ` [PATCH 14/15] PCI: tegra: " Uwe Kleine-König
2023-05-30 14:07 ` [PATCH 00/15] PCI: " Uwe Kleine-König
2023-06-02 21:37 ` Bjorn Helgaas
2023-06-06 16:02 ` Uwe Kleine-König [this message]
2023-06-24 14:23 ` Krzysztof Wilczyński
2023-06-11 13:24 ` Pali Rohár
2023-06-12 16:19 ` Bjorn Helgaas
2023-06-12 18:17 ` Pali Rohár
2023-06-24 14:19 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606160234.elcvyqlz2j3mggih@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=f.fainelli@gmail.com \
--cc=heiko@sntech.de \
--cc=helgaas@kernel.org \
--cc=jianjun.wang@mediatek.com \
--cc=jim2101024@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=joyce.ooi@intel.com \
--cc=jszhang@kernel.org \
--cc=kernel@pengutronix.de \
--cc=kw@linux.com \
--cc=linmq006@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nsaenz@kernel.org \
--cc=pali@kernel.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=rtanwar@maxlinear.com \
--cc=ryder.lee@mediatek.com \
--cc=sbranden@broadcom.com \
--cc=sergio.paracuellos@gmail.com \
--cc=shawn.guo@linaro.org \
--cc=shawn.lin@rock-chips.com \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tjoseph@cadence.com \
--cc=toan@os.amperecomputing.com \
--cc=vidyas@nvidia.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).