From: Paul Cercueil <paul@crapouillou.net>
To: Maxime Ripard <maxime@cerno.tech>
Cc: "Stephen Boyd" <sboyd@kernel.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Chen-Yu Tsai" <wens@csie.org>, "Daniel Vetter" <daniel@ffwll.ch>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Shawn Guo" <shawnguo@kernel.org>,
"Fabio Estevam" <festevam@gmail.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Dinh Nguyen" <dinguyen@kernel.org>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Andreas Färber" <afaerber@suse.de>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Abel Vesa" <abelvesa@kernel.org>,
"Charles Keepax" <ckeepax@opensource.cirrus.com>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Peter De Schrijver" <pdeschrijver@nvidia.com>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Prashant Gaikwad" <pgaikwad@nvidia.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Samuel Holland" <samuel@sholland.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Richard Fitzgerald" <rf@opensource.cirrus.com>,
"Vinod Koul" <vkoul@kernel.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Sekhar Nori" <nsekhar@ti.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Takashi Iwai" <tiwai@suse.com>,
"David Airlie" <airlied@gmail.com>,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"David Lechner" <david@lechnology.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Mark Brown" <broonie@kernel.org>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
linux-stm32@st-md-mailman.stormreply.com,
alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org, linux-mips@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
linux-actions@lists.infradead.org, linux-clk@vger.kernel.org,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
patches@opensource.cirrus.com, linux-tegra@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate
Date: Sat, 05 Nov 2022 10:33:54 +0000 [thread overview]
Message-ID: <IOEVKR.TWFKJND2FJ473@crapouillou.net> (raw)
In-Reply-To: <20221104145946.orsyrhiqvypisl5j@houat>
Hi Maxime,
Le ven. 4 nov. 2022 à 15:59:46 +0100, Maxime Ripard
<maxime@cerno.tech> a écrit :
> Hi Paul,
>
> On Fri, Nov 04, 2022 at 02:31:20PM +0000, Paul Cercueil wrote:
>> Le ven. 4 nov. 2022 à 14:18:13 +0100, Maxime Ripard
>> <maxime@cerno.tech> a
>> écrit :
>> > The Ingenic CGU clocks implements a mux with a set_parent hook,
>> but
>> > doesn't provide a determine_rate implementation.
>> >
>> > This is a bit odd, since set_parent() is there to, as its name
>> implies,
>> > change the parent of a clock. However, the most likely candidate
>> to
>> > trigger that parent change is a call to clk_set_rate(), with
>> > determine_rate() figuring out which parent is the best suited for
>> a
>> > given rate.
>> >
>> > The other trigger would be a call to clk_set_parent(), but it's
>> far less
>> > used, and it doesn't look like there's any obvious user for that
>> clock.
>> >
>> > So, the set_parent hook is effectively unused, possibly because
>> of an
>> > oversight. However, it could also be an explicit decision by the
>> > original author to avoid any reparenting but through an explicit
>> call to
>> > clk_set_parent().
>> >
>> > The driver does implement round_rate() though, which means that
>> we can
>> > change the rate of the clock, but we will never get to change the
>> > parent.
>> >
>> > However, It's hard to tell whether it's been done on purpose or
>> not.
>> >
>> > Since we'll start mandating a determine_rate() implementation,
>> let's
>> > convert the round_rate() implementation to a determine_rate(),
>> which
>> > will also make the current behavior explicit. And if it was an
>> > oversight, the clock behaviour can be adjusted later on.
>>
>> So it's partly on purpose, partly because I didn't know about
>> .determine_rate.
>>
>> There's nothing odd about having a lonely .set_parent callback; in
>> my case
>> the clocks are parented from the device tree.
>>
>> Having the clocks driver trigger a parent change when requesting a
>> rate
>> change sounds very dangerous, IMHO. My MMC controller can be
>> parented to the
>> external 48 MHz oscillator, and if the card requests 50 MHz, it
>> could switch
>> to one of the PLLs. That works as long as the PLLs don't change
>> rate, but if
>> one is configured as driving the CPU clock, it becomes messy.
>> The thing is, the clocks driver has no way to know whether or not
>> it is
>> "safe" to use a designated parent.
>>
>> For that reason, in practice, I never actually want to have a clock
>> re-parented - it's almost always a bad idea vs. sticking to the
>> parent clock
>> configured in the DTS.
>
> Yeah, and this is totally fine. But we need to be explicit about it.
> The
> determine_rate implementation I did in all the patches is an exact
> equivalent to the round_rate one if there was one. We will never ask
> to
> change the parent.
>
> Given what you just said, I would suggest to set the
> CLK_SET_RATE_NO_REPARENT flag as well.
But that would introduce policy into the driver... The fact that I
don't want the MMC parented to the PLLs, doesn't mean that it's an
invalid configuration per se.
Cheers,
-Paul
>>
>> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>> > ---
>> > drivers/clk/ingenic/cgu.c | 15 ++++++++-------
>> > 1 file changed, 8 insertions(+), 7 deletions(-)
>> >
>> > diff --git a/drivers/clk/ingenic/cgu.c b/drivers/clk/ingenic/cgu.c
>> > index 1f7ba30f5a1b..0c9c8344ad11 100644
>> > --- a/drivers/clk/ingenic/cgu.c
>> > +++ b/drivers/clk/ingenic/cgu.c
>> > @@ -491,22 +491,23 @@ ingenic_clk_calc_div(struct clk_hw *hw,
>> > return div;
>> > }
>> >
>> > -static long
>> > -ingenic_clk_round_rate(struct clk_hw *hw, unsigned long req_rate,
>> > - unsigned long *parent_rate)
>> > +static int ingenic_clk_determine_rate(struct clk_hw *hw,
>> > + struct clk_rate_request *req)
>> > {
>> > struct ingenic_clk *ingenic_clk = to_ingenic_clk(hw);
>> > const struct ingenic_cgu_clk_info *clk_info =
>> > to_clk_info(ingenic_clk);
>> > unsigned int div = 1;
>> >
>> > if (clk_info->type & CGU_CLK_DIV)
>> > - div = ingenic_clk_calc_div(hw, clk_info, *parent_rate,
>> req_rate);
>> > + div = ingenic_clk_calc_div(hw, clk_info, req->best_parent_rate,
>> > + req->rate);
>>
>> Sorry but I'm not sure that this works.
>>
>> You replace the "parent_rate" with the "best_parent_rate", and that
>> means
>> you only check the requested rate vs. the parent with the highest
>> frequency,
>> and not vs. the actual parent that will be used.
>
> best_parent_rate is initialized to the current parent rate, not the
> parent with the highest frequency:
> https://elixir.bootlin.com/linux/v6.1-rc3/source/drivers/clk/clk.c#L1471
>
> Maxime
next prev parent reply other threads:[~2022-11-05 10:34 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221018-clk-range-checks-fixes-v2-0-f6736dec138e@cerno.tech>
[not found] ` <20221018-clk-range-checks-fixes-v2-56-f6736dec138e@cerno.tech>
2022-11-04 14:31 ` [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate Paul Cercueil
2022-11-04 14:59 ` Maxime Ripard
2022-11-04 17:35 ` Aidan MacDonald
2022-11-07 8:54 ` Maxime Ripard
2022-11-07 20:57 ` Aidan MacDonald
2022-11-09 11:00 ` Maxime Ripard
[not found] ` <06a293adc75990ed3e297b076fc38d8a.sboyd@kernel.org>
2023-03-23 15:35 ` Aidan MacDonald
2023-03-24 11:19 ` Maxime Ripard
2023-03-24 20:58 ` Aidan MacDonald
2023-03-27 19:24 ` Maxime Ripard
2023-04-05 12:57 ` Paul Cercueil
2023-04-05 14:50 ` Maxime Ripard
2023-04-05 15:29 ` Paul Cercueil
2022-11-05 10:33 ` Paul Cercueil [this message]
2022-11-09 10:53 ` Maxime Ripard
2022-11-09 11:36 ` Paul Cercueil
[not found] ` <20221018-clk-range-checks-fixes-v2-43-f6736dec138e@cerno.tech>
2022-11-04 15:44 ` [PATCH v2 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook Mark Brown
2022-11-04 15:51 ` Maxime Ripard
2022-11-04 15:59 ` Mark Brown
2022-11-07 8:43 ` Maxime Ripard
2022-11-07 12:06 ` Mark Brown
2022-11-07 15:26 ` Maxime Ripard
2022-11-07 16:02 ` Mark Brown
[not found] ` <5819b1362f35ce306e1b6d566bfd44e5.sboyd@kernel.org>
2023-03-29 19:50 ` Maxime Ripard
[not found] ` <20221018-clk-range-checks-fixes-v2-21-f6736dec138e@cerno.tech>
2022-11-04 16:45 ` [PATCH v2 21/65] clk: davinci: da8xx-cfgchip: " David Lechner
2022-11-07 12:06 ` Maxime Ripard
2022-11-07 14:52 ` David Lechner
[not found] ` <20221018-clk-range-checks-fixes-v2-22-f6736dec138e@cerno.tech>
2022-11-04 16:46 ` [PATCH v2 22/65] " David Lechner
[not found] ` <20221018-clk-range-checks-fixes-v2-54-f6736dec138e@cerno.tech>
2022-11-04 16:49 ` [PATCH v2 54/65] clk: da8xx: clk48: Switch to determine_rate David Lechner
2022-11-07 14:52 ` Maxime Ripard
[not found] ` <20221018-clk-range-checks-fixes-v2-28-f6736dec138e@cerno.tech>
2022-11-07 7:51 ` [PATCH v2 28/65] clk: renesas: r9a06g032: Add a determine_rate hook Geert Uytterhoeven
[not found] ` <20221018-clk-range-checks-fixes-v2-65-f6736dec138e@cerno.tech>
2022-11-07 10:56 ` [PATCH v2 65/65] clk: Warn if we register a mux without determine_rate Charles Keepax
[not found] ` <20221018-clk-range-checks-fixes-v2-20-f6736dec138e@cerno.tech>
2022-11-07 10:58 ` [PATCH v2 20/65] clk: wm831x: clkout: Add a determine_rate hook Charles Keepax
[not found] ` <20221018-clk-range-checks-fixes-v2-34-f6736dec138e@cerno.tech>
2022-11-08 13:25 ` [PATCH v2 34/65] clk: ux500: prcmu: " Linus Walleij
2022-11-09 11:05 ` Maxime Ripard
[not found] ` <20221018-clk-range-checks-fixes-v2-35-f6736dec138e@cerno.tech>
2022-11-08 13:27 ` [PATCH v2 35/65] clk: ux500: sysctrl: " Linus Walleij
2022-11-10 11:28 ` Ulf Hansson
2022-11-10 11:39 ` Linus Walleij
2022-11-10 13:05 ` Ulf Hansson
2022-11-11 9:20 ` Linus Walleij
2022-11-14 9:05 ` Lee Jones
[not found] ` <20221018-clk-range-checks-fixes-v2-58-f6736dec138e@cerno.tech>
2022-11-09 2:43 ` [PATCH v2 58/65] clk: sprd: composite: Switch to determine_rate Chunyan Zhang
[not found] ` <20221018-clk-range-checks-fixes-v2-13-f6736dec138e@cerno.tech>
2022-11-13 22:35 ` [PATCH v2 13/65] clk: lmk04832: clkout: Add a determine_rate hook Liam Beguin
[not found] ` <f804380a14c346fdbbf3286bcb40b3c2.sboyd@kernel.org>
2023-03-22 10:01 ` [PATCH v2 00/65] clk: Make determine_rate mandatory for muxes Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=IOEVKR.TWFKJND2FJ473@crapouillou.net \
--to=paul@crapouillou.net \
--cc=a.zummo@towertech.it \
--cc=abelvesa@kernel.org \
--cc=afaerber@suse.de \
--cc=airlied@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=claudiu.beznea@microchip.com \
--cc=daniel@ffwll.ch \
--cc=david@lechnology.com \
--cc=dinguyen@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=jcmvbkbc@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=kishon@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=mani@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=maxime@cerno.tech \
--cc=mcoquelin.stm32@gmail.com \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=nsekhar@ti.com \
--cc=orsonzhai@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=pdeschrijver@nvidia.com \
--cc=perex@perex.cz \
--cc=pgaikwad@nvidia.com \
--cc=rf@opensource.cirrus.com \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=ulf.hansson@linaro.org \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).