From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Revanth Kumar Uppala <ruppala@nvidia.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, netdev@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 3/4] net: phy: aquantia: Poll for TX ready at PHY system side
Date: Wed, 28 Jun 2023 14:33:47 +0100 [thread overview]
Message-ID: <ZJw2u6BIShe2ZGsw@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230628124326.55732-3-ruppala@nvidia.com>
On Wed, Jun 28, 2023 at 06:13:25PM +0530, Revanth Kumar Uppala wrote:
> + /* Lane bring-up failures are seen during interface up, as interface
> + * speed settings are configured while the PHY is still initializing.
> + * To resolve this, poll until PHY system side interface gets ready
> + * and the interface speed settings are configured.
> + */
> + ret = phy_read_mmd_poll_timeout(phydev, MDIO_MMD_PHYXS, MDIO_PHYXS_VEND_IF_STATUS,
> + val, (val & MDIO_PHYXS_VEND_IF_STATUS_TX_READY),
> + 20000, 2000000, false);
What does this actually mean when the condition succeeds? Does it mean
that the system interface is now fully configured (but may or may not
have link)?
If that's correct, then that's fine. If it doesn't succeed because
the system interface doesn't have link, then that would be very bad,
because _this_ function needs to return so the MAC side can then be
configured to gain link with the PHY with the appropriate link
parameters.
The comment doesn't make it clear which it is.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-06-28 13:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 12:43 [PATCH 1/4] net: phy: aquantia: Enable Tx/Rx pause frame support in aquantia PHY Revanth Kumar Uppala
2023-06-28 12:43 ` [PATCH 2/4] net: phy: aquantia: Enable MAC Controlled EEE Revanth Kumar Uppala
2023-06-28 13:54 ` Andrew Lunn
2023-07-24 11:29 ` Revanth Kumar Uppala
2023-07-24 11:52 ` Russell King (Oracle)
2023-06-28 12:43 ` [PATCH 3/4] net: phy: aquantia: Poll for TX ready at PHY system side Revanth Kumar Uppala
2023-06-28 13:33 ` Russell King (Oracle) [this message]
2023-07-24 11:29 ` Revanth Kumar Uppala
2023-07-24 11:57 ` Russell King (Oracle)
2023-06-28 12:43 ` [PATCH 4/4] net: phy: aqr113c: Enable Wake-on-LAN (WOL) Revanth Kumar Uppala
2023-06-28 13:43 ` Russell King (Oracle)
2023-07-24 11:29 ` Revanth Kumar Uppala
2023-07-24 12:29 ` Russell King (Oracle)
2023-06-28 14:17 ` Andrew Lunn
2023-07-24 11:30 ` Revanth Kumar Uppala
2023-06-28 18:57 ` kernel test robot
2023-06-28 13:30 ` [PATCH 1/4] net: phy: aquantia: Enable Tx/Rx pause frame support in aquantia PHY Russell King (Oracle)
2023-06-28 13:46 ` Andrew Lunn
2023-07-24 11:29 ` Revanth Kumar Uppala
2023-07-24 11:47 ` Russell King (Oracle)
2023-06-28 13:46 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJw2u6BIShe2ZGsw@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=hkallweit1@gmail.com \
--cc=linux-tegra@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ruppala@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).