Linux-Toolchains Archive at lore.kernel.org
 help / color / Atom feed
* Re: [tip: x86/pasid] x86/asm: Carve out a generic movdir64b() helper for general usage
       [not found]     ` <20201007211327.GN5607@zn.tnic>
@ 2020-10-08  6:49       ` Peter Zijlstra
  0 siblings, 0 replies; only message in thread
From: Peter Zijlstra @ 2020-10-08  6:49 UTC (permalink / raw)
  To: Borislav Petkov
  Cc: linux-kernel, linux-tip-commits, Michael Matz, Dave Jiang,
	Borislav Petkov, Tony Luck, x86, hjl.tools, linux-toolchains

On Wed, Oct 07, 2020 at 11:13:27PM +0200, Borislav Petkov wrote:
> On Wed, Oct 07, 2020 at 07:08:35PM +0200, Peter Zijlstra wrote:
> > (%rdx), %rax, surely?
> 
> Right, later. Already tagged the branch so that Vinod can base stuff ontop.
> 
> > Also, that's a horrible convention, but I suppose (%rdx), (%rax) was
> > out?
> 
> See the end of this mail:
> 
> https://lkml.kernel.org/r/alpine.LSU.2.20.2009241356020.20802@wotan.suse.de

That, 100x that. Why wasn't it fixed then? How about we fix binutils to
accept the sane mnemonic as well?

> > Can we pretty please get a binutils version that knows about this
> > instruction, such that we know when we can get rid of the silly .byte
> > encoded mess?
> 
> It looks like support for this insn got introduced in this binutils commit:
> 
> c0a30a9f0ab4 ("Enable Intel MOVDIRI, MOVDIR64B instructions")
> 
> So I guess from 2.31 onwards:

Then we'll just keep the byte code around until we reach the min
binutils that's sane, but at least we can fix the comment to not be
insane.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20201005151126.657029-2-dave.jiang@intel.com>
     [not found] ` <160208728972.7002.18130814269550766361.tip-bot2@tip-bot2>
     [not found]   ` <20201007170835.GM2628@hirez.programming.kicks-ass.net>
     [not found]     ` <20201007211327.GN5607@zn.tnic>
2020-10-08  6:49       ` [tip: x86/pasid] x86/asm: Carve out a generic movdir64b() helper for general usage Peter Zijlstra

Linux-Toolchains Archive at lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-toolchains/0 linux-toolchains/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-toolchains linux-toolchains/ https://lore.kernel.org/linux-toolchains \
		linux-toolchains@vger.kernel.org
	public-inbox-index linux-toolchains

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-toolchains


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git