From: Thorsten Glaser <tg@debian.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: x86@kernel.org, rostedt@goodmis.org, hpa@zytor.com,
torvalds@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-toolchains@vger.kernel.org, jpoimboe@redhat.com,
alexei.starovoitov@gmail.com, mhiramat@kernel.org
Subject: Re: [PATCH 1/2] x86: Remove dynamic NOP selection
Date: Sat, 20 Jan 2024 06:58:56 +0000 (UTC) [thread overview]
Message-ID: <Pine.BSM.4.64L.2401200654480.19429@herc.mirbsd.org> (raw)
In-Reply-To: <20210312115749.065275711@infradead.org>
Peter Zijlstra dixit:
>-/* generic versions from gas
[…]
>- 3: leal 0x00(%esi),%esi
>- 4: leal 0x00(,%esi,1),%esi
>- 6: leal 0x00000000(%esi),%esi
>- 7: leal 0x00000000(,%esi,1),%esi
vs.
>+ * Generic 32bit nops from GAS:
[…]
>+ * 3: leal 0x0(%esi),%esi
>+ * 4: leal 0x0(%esi,%eiz,1),%esi
>+ * 5: leal %ds:0x0(%esi,%eiz,1),%esi
>+ * 6: leal 0x0(%esi),%esi
>+ * 7: leal 0x0(%esi,%eiz,1),%esi
>+ * 8: leal %ds:0x0(%esi,%eiz,1),%esi
I think there’s some mistake introduced. The BYTES_* are
identical for e.g. #7, but %eiz must be wrong, it’s not
a register. Indeed, gas (on Debian bullseye) does not
assemble that either.
(Awful AT&T syntax aside…)
bye,
//mirabilos
--
„Cool, /usr/share/doc/mksh/examples/uhr.gz ist ja ein Grund,
mksh auf jedem System zu installieren.“
-- XTaran auf der OpenRheinRuhr, ganz begeistert
(EN: “[…]uhr.gz is a reason to install mksh on every system.”)
next prev parent reply other threads:[~2024-01-20 7:21 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 11:32 [PATCH 0/2] x86: Remove ideal_nops[] Peter Zijlstra
2021-03-12 11:32 ` [PATCH 1/2] x86: Remove dynamic NOP selection Peter Zijlstra
2021-03-12 12:09 ` Peter Zijlstra
2021-03-12 20:36 ` Linus Torvalds
2024-01-20 6:58 ` Thorsten Glaser [this message]
2024-01-20 8:22 ` H. Peter Anvin
2024-01-20 16:53 ` Thorsten Glaser
2024-01-21 23:21 ` H. Peter Anvin
2024-01-21 23:58 ` Thorsten Glaser
2024-01-22 0:15 ` H. Peter Anvin
2024-01-22 0:56 ` Steven Rostedt
2024-01-22 1:17 ` Thorsten Glaser
2024-01-22 2:04 ` H. Peter Anvin
2024-01-22 2:15 ` H. Peter Anvin
2024-01-22 2:22 ` Steven Rostedt
2024-01-22 2:31 ` H. Peter Anvin
2024-01-20 17:00 ` Linus Torvalds
2024-01-20 17:19 ` Thorsten Glaser
2024-01-20 18:21 ` disassemblers (was Re: [PATCH 1/2] x86: Remove dynamic NOP selection) Thorsten Glaser
2024-01-21 22:36 ` [PATCH 1/2] x86: Remove dynamic NOP selection David Laight
2024-01-21 23:10 ` H. Peter Anvin
2021-03-12 11:32 ` [PATCH 2/2] objtool,x86: Use asm/nops.h Peter Zijlstra
2021-03-12 14:29 ` [PATCH 0/2] x86: Remove ideal_nops[] Sedat Dilek
2021-03-12 14:47 ` Borislav Petkov
2021-03-12 17:26 ` Steven Rostedt
2021-03-12 17:35 ` Sedat Dilek
2021-03-12 17:46 ` Borislav Petkov
2021-03-12 17:47 ` Steven Rostedt
2021-03-12 18:13 ` Sedat Dilek
2021-03-12 19:03 ` Sedat Dilek
2021-03-12 20:59 ` Borislav Petkov
[not found] ` <CA+icZUWSCS6vAQOXoG6nsW+Dbnogivzf+rmegCTMjz5hjE5cKQ@mail.gmail.com>
2021-03-13 8:49 ` Borislav Petkov
2021-03-13 11:23 ` Borislav Petkov
2021-03-13 12:10 ` Sedat Dilek
2021-03-13 12:15 ` Borislav Petkov
2021-03-13 12:38 ` Sedat Dilek
2021-03-13 12:49 ` Borislav Petkov
2021-03-13 12:58 ` Sedat Dilek
2021-03-13 13:29 ` Borislav Petkov
2021-03-13 13:47 ` Sedat Dilek
2021-03-15 17:04 ` Sedat Dilek
2021-03-15 17:15 ` Borislav Petkov
2021-03-15 17:19 ` Sedat Dilek
2021-03-15 17:23 ` Borislav Petkov
2021-03-15 18:10 ` Peter Zijlstra
2021-03-15 18:23 ` Sedat Dilek
2021-03-15 22:14 ` Peter Zijlstra
2021-03-16 5:56 ` Sedat Dilek
2021-03-27 12:08 ` Sedat Dilek
2021-03-27 20:02 ` Linus Torvalds
2021-03-30 12:31 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.BSM.4.64L.2401200654480.19429@herc.mirbsd.org \
--to=tg@debian.org \
--cc=alexei.starovoitov@gmail.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linuxfoundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).