From: David Laight <David.Laight@ACULAB.COM>
To: 'Linus Torvalds' <torvalds@linuxfoundation.org>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: Thorsten Glaser <tg@debian.org>,
Peter Zijlstra <peterz@infradead.org>,
"x86@kernel.org" <x86@kernel.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-toolchains@vger.kernel.org"
<linux-toolchains@vger.kernel.org>,
"jpoimboe@redhat.com" <jpoimboe@redhat.com>,
"alexei.starovoitov@gmail.com" <alexei.starovoitov@gmail.com>,
"mhiramat@kernel.org" <mhiramat@kernel.org>
Subject: RE: [PATCH 1/2] x86: Remove dynamic NOP selection
Date: Sun, 21 Jan 2024 22:36:32 +0000 [thread overview]
Message-ID: <c911eadd249d4e4cbc8c247ed677b56a@AcuMS.aculab.com> (raw)
In-Reply-To: <CAHk-=whtFk2DoO8WhtmsbU9nGXUd8sKShV1Dk71krFLBjPUSeg@mail.gmail.com>
From: Linus Torvalds
> Sent: 20 January 2024 17:00
...
> And if I add "-r" to get relocation info, I get
>
> call <delayed_put_task_struct+0x1a>
> R_X86_64_PLT32 rethook_flush_task-0x4
>
> which shows the raw relocation data, but with truly mind-bogglingly
> horrendous syntax.
>
> Is there some sane tool that just does the sane thing and shows this as
>
> call rethook_flush_task
>
> which is what the thing actually means?
While you are re-writing a disassembler, remember to print the
contents of string when you get a reference into .rodata.str :-)
How many times have you had to dig out a printf format string in
order to locate the source associated with some object code?
It is so much easier if the disassembler does it for you.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2024-01-21 22:36 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 11:32 [PATCH 0/2] x86: Remove ideal_nops[] Peter Zijlstra
2021-03-12 11:32 ` [PATCH 1/2] x86: Remove dynamic NOP selection Peter Zijlstra
2021-03-12 12:09 ` Peter Zijlstra
2021-03-12 20:36 ` Linus Torvalds
2024-01-20 6:58 ` Thorsten Glaser
2024-01-20 8:22 ` H. Peter Anvin
2024-01-20 16:53 ` Thorsten Glaser
2024-01-21 23:21 ` H. Peter Anvin
2024-01-21 23:58 ` Thorsten Glaser
2024-01-22 0:15 ` H. Peter Anvin
2024-01-22 0:56 ` Steven Rostedt
2024-01-22 1:17 ` Thorsten Glaser
2024-01-22 2:04 ` H. Peter Anvin
2024-01-22 2:15 ` H. Peter Anvin
2024-01-22 2:22 ` Steven Rostedt
2024-01-22 2:31 ` H. Peter Anvin
2024-01-20 17:00 ` Linus Torvalds
2024-01-20 17:19 ` Thorsten Glaser
2024-01-20 18:21 ` disassemblers (was Re: [PATCH 1/2] x86: Remove dynamic NOP selection) Thorsten Glaser
2024-01-21 22:36 ` David Laight [this message]
2024-01-21 23:10 ` [PATCH 1/2] x86: Remove dynamic NOP selection H. Peter Anvin
2021-03-12 11:32 ` [PATCH 2/2] objtool,x86: Use asm/nops.h Peter Zijlstra
2021-03-12 14:29 ` [PATCH 0/2] x86: Remove ideal_nops[] Sedat Dilek
2021-03-12 14:47 ` Borislav Petkov
2021-03-12 17:26 ` Steven Rostedt
2021-03-12 17:35 ` Sedat Dilek
2021-03-12 17:46 ` Borislav Petkov
2021-03-12 17:47 ` Steven Rostedt
2021-03-12 18:13 ` Sedat Dilek
2021-03-12 19:03 ` Sedat Dilek
2021-03-12 20:59 ` Borislav Petkov
[not found] ` <CA+icZUWSCS6vAQOXoG6nsW+Dbnogivzf+rmegCTMjz5hjE5cKQ@mail.gmail.com>
2021-03-13 8:49 ` Borislav Petkov
2021-03-13 11:23 ` Borislav Petkov
2021-03-13 12:10 ` Sedat Dilek
2021-03-13 12:15 ` Borislav Petkov
2021-03-13 12:38 ` Sedat Dilek
2021-03-13 12:49 ` Borislav Petkov
2021-03-13 12:58 ` Sedat Dilek
2021-03-13 13:29 ` Borislav Petkov
2021-03-13 13:47 ` Sedat Dilek
2021-03-15 17:04 ` Sedat Dilek
2021-03-15 17:15 ` Borislav Petkov
2021-03-15 17:19 ` Sedat Dilek
2021-03-15 17:23 ` Borislav Petkov
2021-03-15 18:10 ` Peter Zijlstra
2021-03-15 18:23 ` Sedat Dilek
2021-03-15 22:14 ` Peter Zijlstra
2021-03-16 5:56 ` Sedat Dilek
2021-03-27 12:08 ` Sedat Dilek
2021-03-27 20:02 ` Linus Torvalds
2021-03-30 12:31 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c911eadd249d4e4cbc8c247ed677b56a@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=alexei.starovoitov@gmail.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tg@debian.org \
--cc=torvalds@linuxfoundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).