From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: Michal Sojka <michal.sojka@cvut.cz>,
Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2] kernel-shark: Do not hardcode /usr prefix for polkit policies
Date: Fri, 12 Mar 2021 08:46:21 +0200 [thread overview]
Message-ID: <1aaeb84b-2820-0818-4ab6-fcfd7b5fa52c@gmail.com> (raw)
In-Reply-To: <87k0qd7evn.fsf@steelpick.2x.cz>
Hi Michal,
On 11.03.21 г. 19:57, Michal Sojka wrote:
> Hi Yordan,
>
> On Thu, Mar 11 2021, Yordan Karadzhov (VMware) wrote:
>> In your case the installation fails to install the policy file used by
>> Polkit. Note that this doesn't mean that the kernelshark installation
>> itself fails.
>
> Yes, I know, but when something fails, users are confused ;-)
You are right here. We have to think how to make this message look more
like a warning.
>
>> As far as I know the policy file can only go to a special locations so
>> that Polkit can find it. Otherwise it will have no effect (I may be
>> wrong on this).
>
> You're right. I looked at polkit sources and it really seems that only
> one location is supported. It is determined at configuration time so on
> some systems it may be different from /usr/share/... I'm talking
> specifically about NixOS, but it already has the patch I sent.
>
> So I leave it up to you whether to apply the patch or not. I think that
> supporting seamless installation into $HOME is useful if one wants to
> quickly use a newer version not available in their distribution.
Building, installing as root and testing the latest version shouldn't
cause any problems/conflicts on your system. Note that there is a script
in kernel-shark/build called "cmake_uninstall.sh". It is guaranteed that
this script removes every single file that has been installed.
And BTW from the patch I see that you still use the old version that
comes together with trace-cmd. If you are keen to try the latest
version, checkout this one:
https://git.kernel.org/pub/scm/utils/trace-cmd/kernel-shark.git/
This is a brand new version that has a lot of changes under the hood and
needs user testing. We will be extremely happy to receive bug reports ;)
or patches for this new version.
Thanks!
Yordan
next prev parent reply other threads:[~2021-03-12 6:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 13:12 [PATCH] kernel-shark: Do not hardcode /usr prefix for polkit policies Michal Sojka
2021-03-11 14:09 ` Steven Rostedt
2021-03-11 14:48 ` Michal Sojka
2021-03-11 14:50 ` [PATCH v2] " Michal Sojka
2021-03-11 14:54 ` Steven Rostedt
2021-03-11 17:01 ` Yordan Karadzhov (VMware)
2021-03-11 17:57 ` Michal Sojka
2021-03-12 6:46 ` Yordan Karadzhov (VMware) [this message]
2021-03-12 11:47 ` Dario Faggioli
2021-03-12 13:02 ` Yordan Karadzhov (VMware)
2021-03-17 12:59 ` Michal Sojka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1aaeb84b-2820-0818-4ab6-fcfd7b5fa52c@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=michal.sojka@cvut.cz \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).