linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Michal Sojka <michal.sojka@cvut.cz>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] kernel-shark: Do not hardcode /usr prefix for polkit policies
Date: Thu, 11 Mar 2021 09:09:46 -0500	[thread overview]
Message-ID: <20210311090946.7d24cb40@gandalf.local.home> (raw)
In-Reply-To: <20210311131221.13600-1-michal.sojka@cvut.cz>

On Thu, 11 Mar 2021 14:12:21 +0100
Michal Sojka <michal.sojka@cvut.cz> wrote:

Hi Michal,

Thanks for the fix!

Note, even when submitting an "obvious" patch, it's always good to add some
content to the change log body. Basically, why it shouldn't be hard coded.
That is, what failed because of it. I can think of a few things, but we try
to have content in the change log body for all commits, even obvious ones.
The only exception is spelling fixes don't need content.

Thanks!

-- Steve


> ---
>  kernel-shark/src/CMakeLists.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel-shark/src/CMakeLists.txt b/kernel-shark/src/CMakeLists.txt
> index 457c100..687e150 100644
> --- a/kernel-shark/src/CMakeLists.txt
> +++ b/kernel-shark/src/CMakeLists.txt
> @@ -92,7 +92,7 @@ if (Qt5Widgets_FOUND AND Qt5Network_FOUND)
>              DESTINATION ${_INSTALL_PREFIX}/share/icons/${KS_APP_NAME})
>  
>      install(FILES "${KS_DIR}/org.freedesktop.kshark-record.policy"
> -            DESTINATION /usr/share/polkit-1/actions/)
> +            DESTINATION ${_INSTALL_PREFIX}/share/polkit-1/actions/)
>  
>      install(PROGRAMS "${KS_DIR}/bin/kshark-su-record"
>              DESTINATION ${_INSTALL_PREFIX}/bin/)


  reply	other threads:[~2021-03-11 14:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11 13:12 [PATCH] kernel-shark: Do not hardcode /usr prefix for polkit policies Michal Sojka
2021-03-11 14:09 ` Steven Rostedt [this message]
2021-03-11 14:48   ` Michal Sojka
2021-03-11 14:50     ` [PATCH v2] " Michal Sojka
2021-03-11 14:54       ` Steven Rostedt
2021-03-11 17:01       ` Yordan Karadzhov (VMware)
2021-03-11 17:57         ` Michal Sojka
2021-03-12  6:46           ` Yordan Karadzhov (VMware)
2021-03-12 11:47             ` Dario Faggioli
2021-03-12 13:02               ` Yordan Karadzhov (VMware)
2021-03-17 12:59             ` Michal Sojka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210311090946.7d24cb40@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=michal.sojka@cvut.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).