linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] trace-cmd: Fix make clean error
@ 2018-12-03  9:19 Slavomir Kaslev
  2018-12-04  5:56 ` Steven Rostedt
  0 siblings, 1 reply; 2+ messages in thread
From: Slavomir Kaslev @ 2018-12-03  9:19 UTC (permalink / raw)
  To: rostedt; +Cc: linux-trace-devel, ykaradzhov

Fix make clean failing when cmake hasn't generated Makefile for KernelShark:

    $ make clean
    # ...
    make -C /home/kaslevs/src/trace-cmd/kernel-shark-qt/build clean
    make[1]: *** No rule to make target 'clean'.  Stop.
    make: *** [Makefile:365: clean] Error 2

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 7ee9e0d..562afd1 100644
--- a/Makefile
+++ b/Makefile
@@ -361,11 +361,11 @@ clean:
 	$(RM) tags TAGS cscope*
 	$(MAKE) -C $(src)/lib/traceevent clean
 	$(MAKE) -C $(src)/lib/trace-cmd clean
-	$(MAKE) -C $(src)/kernel-shark clean
-	$(MAKE) -C $(kshark-dir)/build clean
 	$(MAKE) -C $(src)/plugins clean
 	$(MAKE) -C $(src)/python clean
 	$(MAKE) -C $(src)/tracecmd clean
+	$(MAKE) -C $(src)/kernel-shark clean
+	if [ -f $(kshark-dir)/build/Makefile ]; then $(MAKE) -C $(kshark-dir)/build clean; fi
 
 
 ##### PYTHON STUFF #####
-- 
2.19.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] trace-cmd: Fix make clean error
  2018-12-03  9:19 [PATCH] trace-cmd: Fix make clean error Slavomir Kaslev
@ 2018-12-04  5:56 ` Steven Rostedt
  0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2018-12-04  5:56 UTC (permalink / raw)
  To: Slavomir Kaslev; +Cc: linux-trace-devel, ykaradzhov

On Mon,  3 Dec 2018 11:19:36 +0200
Slavomir Kaslev <kaslevs@vmware.com> wrote:

> Fix make clean failing when cmake hasn't generated Makefile for KernelShark:
> 
>     $ make clean
>     # ...
>     make -C /home/kaslevs/src/trace-cmd/kernel-shark-qt/build clean
>     make[1]: *** No rule to make target 'clean'.  Stop.
>     make: *** [Makefile:365: clean] Error 2
> 
> Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>

Applied. Thanks Slavomir!

-- Steve

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-04  5:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-03  9:19 [PATCH] trace-cmd: Fix make clean error Slavomir Kaslev
2018-12-04  5:56 ` Steven Rostedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).