[PATCH] trace-cmd: fix deletion of histogram triggers

[PATCH] trace-cmd: fix deletion of histogram triggers

[Tzvetomir Stoyanov]

This patch fixes the clear_trigger() function to delete
configured histograms. Unlike other triggers, histograms
must be deleted specifying the whole trigger string.

Signed-off-by: Tzvetomir Stoyanov <tstoyanov@vmware.com>
---
 tracecmd/trace-record.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c
index a9bcd8d..37a2d1d 100644
--- a/tracecmd/trace-record.c
+++ b/tracecmd/trace-record.c
@@ -1680,7 +1680,7 @@ static void clear_trigger(const char *file)
 	 * to the file for each trigger.
 	 */
 	do {
-		len = find_trigger(file, trigger+1, BUFSIZ-1, 1);
+		len = find_trigger(file, trigger+1, BUFSIZ-1, 3);
 		if (len)
 			write_trigger(file, trigger);
 	} while (len);
-- 
2.19.2

Re: [PATCH] trace-cmd: fix deletion of histogram triggers

[Steven Rostedt]

On Tue, 18 Dec 2018 12:39:28 +0200
Tzvetomir Stoyanov <tstoyanov@vmware.com> wrote:

> This patch fixes the clear_trigger() function to delete
> configured histograms. Unlike other triggers, histograms
> must be deleted specifying the whole trigger string.
> 
> Signed-off-by: Tzvetomir Stoyanov <tstoyanov@vmware.com>

Applied. Thanks Tzvetomir!

-- Steve

> ---
>  tracecmd/trace-record.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c
> index a9bcd8d..37a2d1d 100644
> --- a/tracecmd/trace-record.c
> +++ b/tracecmd/trace-record.c
> @@ -1680,7 +1680,7 @@ static void clear_trigger(const char *file)
>  	 * to the file for each trigger.
>  	 */
>  	do {
> -		len = find_trigger(file, trigger+1, BUFSIZ-1, 1);
> +		len = find_trigger(file, trigger+1, BUFSIZ-1, 3);
>  		if (len)
>  			write_trigger(file, trigger);
>  	} while (len);