From: Yordan Karadzhov <ykaradzhov@vmware.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org,
Yordan Karadzhov <ykaradzhov@vmware.com>
Subject: [PATCH v2 4/4] kernel-shark: Fix a bug in KsPluginManager
Date: Thu, 7 Mar 2019 17:43:16 +0200 [thread overview]
Message-ID: <20190307154316.19194-5-ykaradzhov@vmware.com> (raw)
In-Reply-To: <20190307154316.19194-1-ykaradzhov@vmware.com>
const char *lib = plugin.toStdString().c_str();
This line is a bad idea because the returned array may (will) be
invalidated when the destructor of std::string is called.
Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com>
---
kernel-shark/src/KsUtils.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel-shark/src/KsUtils.cpp b/kernel-shark/src/KsUtils.cpp
index 34b2e2d..d7b1753 100644
--- a/kernel-shark/src/KsUtils.cpp
+++ b/kernel-shark/src/KsUtils.cpp
@@ -439,7 +439,7 @@ void KsPluginManager::registerFromList(kshark_context *kshark_ctx)
auto lamRegUser = [&kshark_ctx](const QString &plugin)
{
- const char *lib = plugin.toStdString().c_str();
+ const char *lib = plugin.toLocal8Bit().data();
kshark_register_plugin(kshark_ctx, lib);
};
@@ -474,7 +474,7 @@ void KsPluginManager::unregisterFromList(kshark_context *kshark_ctx)
auto lamUregUser = [&kshark_ctx](const QString &plugin)
{
- const char *lib = plugin.toStdString().c_str();
+ const char *lib = plugin.toLocal8Bit().data();
kshark_unregister_plugin(kshark_ctx, lib);
};
--
2.19.1
next prev parent reply other threads:[~2019-03-07 15:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 15:43 [PATCH v2 0/4] Various minor modifications and fixes toward KS 1.0 Yordan Karadzhov
2019-03-07 15:43 ` [PATCH v2 1/4] kernel-shark: Specify the OpenGL interface used by KernelShark Yordan Karadzhov
2019-03-07 15:43 ` [PATCH v2 2/4] kernel-shark: Fix a bug in ksmodel_zoom Yordan Karadzhov
2019-03-13 13:51 ` Steven Rostedt
2019-03-13 13:57 ` Yordan Karadzhov
2019-03-07 15:43 ` [PATCH v2 3/4] kernel-shark: Fix Doxygen warning from sched_events Yordan Karadzhov
2019-03-07 15:43 ` Yordan Karadzhov [this message]
2019-03-11 12:09 ` [PATCH v2 4/4] kernel-shark: Fix a bug in KsPluginManager Slavomir Kaslev
2019-03-11 13:20 ` Yordan Karadzhov (VMware)
2019-03-11 13:44 ` Slavomir Kaslev
2019-03-11 17:55 ` Yordan Karadzhov (VMware)
2019-03-11 18:15 ` Steven Rostedt
2019-03-26 1:58 ` Steven Rostedt
2019-03-26 13:37 ` Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307154316.19194-5-ykaradzhov@vmware.com \
--to=ykaradzhov@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).