From: Yordan Karadzhov <ykaradzhov@vmware.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "linux-trace-devel@vger.kernel.org" <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] kernel-shark: Fix a bug in ksmodel_zoom
Date: Wed, 13 Mar 2019 13:57:16 +0000 [thread overview]
Message-ID: <569517bb-9eb6-01a4-a90c-d79c4713c0fe@vmware.com> (raw)
In-Reply-To: <20190313095159.6b2609b2@gandalf.local.home>
On 13.03.19 г. 15:51 ч., Steven Rostedt wrote:
> On Thu, 7 Mar 2019 17:43:14 +0200
> Yordan Karadzhov <ykaradzhov@vmware.com> wrote:
>
>> When zooming-in the model is supposed to avoid over-zooming by
>> recalculation the Scale factor. The new value of the Scale factor is
>> supposed to be such that the size of the bin cannot be smaller than 5
>> ns. This patch fixes a naive bug in the way the new scale value is
>> calculated.
>
> BTW, what if the resolution of time stamps isn't in ns, and we can have
> more than one event in a 5 unit bin. Does that mean we never display
> multiple events in that small of a time scale?
For the moment Yes.
We have to make this value (5 units /ns) a parameter that can be configured.
Yordan
>
> -- Steve
>
next prev parent reply other threads:[~2019-03-13 13:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 15:43 [PATCH v2 0/4] Various minor modifications and fixes toward KS 1.0 Yordan Karadzhov
2019-03-07 15:43 ` [PATCH v2 1/4] kernel-shark: Specify the OpenGL interface used by KernelShark Yordan Karadzhov
2019-03-07 15:43 ` [PATCH v2 2/4] kernel-shark: Fix a bug in ksmodel_zoom Yordan Karadzhov
2019-03-13 13:51 ` Steven Rostedt
2019-03-13 13:57 ` Yordan Karadzhov [this message]
2019-03-07 15:43 ` [PATCH v2 3/4] kernel-shark: Fix Doxygen warning from sched_events Yordan Karadzhov
2019-03-07 15:43 ` [PATCH v2 4/4] kernel-shark: Fix a bug in KsPluginManager Yordan Karadzhov
2019-03-11 12:09 ` Slavomir Kaslev
2019-03-11 13:20 ` Yordan Karadzhov (VMware)
2019-03-11 13:44 ` Slavomir Kaslev
2019-03-11 17:55 ` Yordan Karadzhov (VMware)
2019-03-11 18:15 ` Steven Rostedt
2019-03-26 1:58 ` Steven Rostedt
2019-03-26 13:37 ` Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569517bb-9eb6-01a4-a90c-d79c4713c0fe@vmware.com \
--to=ykaradzhov@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).