linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-trace-devel@vger.kernel.org
Cc: Yordan Karadzhov <y.karadz@gmail.com>
Subject: [PATCH 0/2] kernel-shark: Be more careful with kshark-su-record
Date: Tue, 23 Jul 2019 18:50:44 -0400	[thread overview]
Message-ID: <20190723225044.576298160@goodmis.org> (raw)

Two issues with kshark-su-record.

1) It just calls kshark-record with no path, which can be an issue
   if pkexec removes PATH variable, or sets it to something
   that kshark-record is not in.

2) Need to set DISPLAY variable, because on some of my machines,
   the kshark-record failed to execute due to pkexec removing the
   DISPLAY variable.


Steven Rostedt (VMware) (2):
      kernel-shark: Execute kshark-record from same dir as kshark-su-record
      kernel-shark: Set the DISPLAY environment for pkexec kshark-record

----
 kernel-shark/bin/kshark-su-record | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

             reply	other threads:[~2019-07-23 22:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23 22:50 Steven Rostedt [this message]
2019-07-23 22:50 ` [PATCH 1/2] kernel-shark: Execute kshark-record from same dir as kshark-su-record Steven Rostedt
2019-07-25  9:01   ` Yordan Karadzhov (VMware)
2019-07-25 12:45     ` Steven Rostedt
2019-07-25 13:59       ` Yordan Karadzhov (VMware)
2019-07-25 14:00       ` Yordan Karadzhov (VMware)
2019-07-23 22:50 ` [PATCH 2/2] kernel-shark: Set the DISPLAY environment for pkexec kshark-record Steven Rostedt
2019-07-24 10:42   ` Yordan Karadzhov (VMware)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190723225044.576298160@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=y.karadz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).